httpd: rewrite not handled correctly + fix

checked for NULL in server_file_access() in an attempt to detect an infinite recursive loop. I've attached a patch for your consideration. It makes a lot of sense to me to simply use a counter. This even improves readability. Let me know what you think,

OpenSMTPD: status set incorrectly on envelope expiration + fix

Our OpenSMTPD daemon sent us the following confusing message: A message is delayed for more than 0 seconds for the following list of recipients: b...@gus.test: Envelope expired The enclosed patch will fix the issue permanently. Sincerely, Erik Index: usr.sbin/smtpd/queue.c

Re: Document hostctl commands for XenServer

ct.org/developers/teams/xapi.html>. It is used in the world's largest clouds and enterprises. Commercial support for XenServer <https://xenserver.org/get-support.html> is available from Citrix. [/quote] [snip] Maybe that helps. Regards, Erik

Proxy ARP and npppd (tun)

arp cache. Is there an other way of doing this? Regards Erik

if_pfsync error counter

Hi, I noticed by looking at the code that in sys/net/if_pfsync.c : pfsync_sendout() a failed ip_output() does not increment sc->sc_if.if_oerrors++ only pfsyncstats.pfsyncs_oerrors++. Similar pattern do in eg. if_pflow.c. Should it?

httpd with fcgi send garbage after non-chunked response

Hi, In the case where httpds fcgi module handles the end marker, it should abort if fcgi_chunked is not true. Now it sends 8 bytes of garbage after each request (it's often NUL terminated so it doesn't seem to show up in browsers). This patched fixed it for me. Index: usr.sbin/httpd/server_fcgi.c

relayd: crash with two listen on (one is ssl)

Hi, In relayd, if a relay is configured with two "listen on" directives, one with ssl and one without. In the relay_inherit function the ssl pointers (cert and key) are copied to the latter, and used/freed even if F_SSL is not set. This causes a double free later in purge_relay. relay "http" {

setpassent(1) not working

Hi, I noticed that setpassent(1) probably doesn't work as intended, as this program should open the spwd.db file once, not four times? int main() { setpassent(1); getpwnam("root"); getpwnam("root"); getpwuid(0); getpwuid(0); return 0; } It seems to be due to faulty logic

pfsync in rdomain

This patch seems to fix running pfsync in rdomains. --- sys/net/if_pfsync.c.origThu Nov 14 15:58:00 2013 +++ sys/net/if_pfsync.c Thu Nov 14 16:51:30 2013 @@ -1682,6 +1682,8 @@ sc->sc_if.if_opackets++; sc->sc_if.if_obytes += m->m_pkthdr.len; + m->m_pkthdr.rdomain = sc->s

relayd: statistics are broken [patches]

s crashing in a simple "dns forward" test. If the big patch is applied, env is always set in relay.c and relay_udp.c, so we should let this patch decide if another bug report is needed. (reported by Tom Knienieder: relayd UDP bug and patch .

Re: [patch] em: interrupt starvation

y > that it fixes the problem. Thanks, I run my testcase with your patch on two different em cards (82573L, 82583V) successfully. Erik

[patch] em: interrupt starvation

. I fixed this problem by adding a em_start() call in em_intr() after the link status has changed. Maybe the em_start() a few lines up could be moved below the em_update_link_status(), however this fix was more non-intrusive and worked for me. Ideas? Erik --- if_em.c.orig2012-02-15 05:06:27

tcpbench: crash with -n and -b

Hi, I noticed that tcpbench sometimes crashes when using -n and -b combined, this is because of a double-free in the client initialization loop. See patch below Erik Index: usr.bin/tcpbench/tcpbench.c === RCS file: /cvs/src

Re: relayd: statistics are broken [resend patches]

On 3/7/12 11:53 AM, Erik Lax wrote: > ... > > Two patches attached below. Sorry for the noise, apparently the patches got broken in transit, blaming the MUA. -- cut -- Index: relay.c === RCS file: /cvs/src/usr.sbin/relayd/

relayd: statistics are broken

enced for sc_timeout in relay_udp.c, thus crashing in a simple "dns forward" test. If the big patch is applied, env is always set in relay.c and relay_udp.c, so we should let this patch decide if another bug report is needed. Regards Erik Two patc

Re: relayd and rdomain/prio defaults

On 3/2/12 5:09 PM, Gabriel Linder wrote: Since 5.0 rules injected by relayd includes "on rdomain 0" and "prio 0", I guess that's not intended ? I think you're right. And if so, the same problem seem to exist for the ftp-proxy (filter.c) as well. I guess this is what happens when default values

tcpbench: setpgid

sid(). I attached a patch (against 5.0) to remove the code :) Regards Erik Lax Index: usr.bin/tcpbench/tcpbench.c === RCS file: /cvs/src/usr.bin/tcpbench/tcpbench.c,v retrieving revision 1.22 diff -u -r1.22 tcpbench.c --- usr.bin/tcpbench/

libpthread fork and malloc

this bug. Regards Erik Index: lib/libpthread/uthread/uthread_fork.c === RCS file: /cvs/src/lib/libpthread/uthread/uthread_fork.c,v retrieving revision 1.22 diff -u -r1.22 uthread_fork.c --- lib/libpthread/uthread/uthread_fork.c1

Re: ifconfig vlan tag range

Op 10-2-2011 12:08, Henning Brauer schreef: not only in openbsd - that's what you can fit in the 12 bits;) Time to implement half bits next April 1. ;) Also solves the ip address range problem, and numerous other things. Erik

open(2) can return EBUSY

his happens at least with OpenBSD 4.6. This possibility is not documented in the manual page open(2), neither in 4.6, nor in 4.7. Best regards, Mats Erik Andersson, fil. dr