Re: [patch] eliminate -Wsign-compare warning in imsg.c with clang on FreeBSD

2015-12-09 Thread Craig Rodrigues
On Wed, Dec 9, 2015 at 4:03 AM, Theo Buehler wrote: > Committed, thanks! Thank you! I took your advice and imported the latest changes to imsg.c from OpenBSD changes to FreeBSD: https://svnweb.freebsd.org/base/head/lib/libopenbsd/imsg.c -- Craig

[patch] eliminate -Wsign-compare warning in imsg.c with clang on FreeBSD

2015-12-08 Thread Craig Rodrigues
Index: imsg.c === RCS file: /cvs/src/lib/libutil/imsg.c,v retrieving revision 1.12 diff -u -r1.12 imsg.c --- imsg.c5 Dec 2015 13:06:52 -1.12 +++ imsg.c9 Dec 2015 05:04:05 - @@ -72,7 +72,7 @@ again: if (getdta

Re: Reducing compilation warnings in imsg.c on FreeSBD

2015-11-16 Thread Craig Rodrigues
On Mon, Nov 16, 2015 at 9:03 AM, Philip Guenther wrote: > >> integers of different signs: 'unsigned long' and 'int' [-Wsign-compare] > >> >= getdtablesize()) { > >> ^ ~~~ > >> 1 warning generated. > > Out of curiousity, in your experience how often is that war

Reducing compilation warnings in imsg.c on FreeSBD

2015-11-16 Thread Craig Rodrigues
Hi, Recently, I imported imsg.c from OpenBSD to the FreeBSD base system's libopenbsd: https://svnweb.freebsd.org/changeset/base/290375 When compiling on FreeBSD, we get a compiler warning with clang: cc -O2 -pipe -I/opt2/branches/head2/lib/libopenbsd -std=gnu99 -fstack-protector-strong -Wsys