athn auto media type (Was: Re: Explicit NULL assignment after free)

2023-01-01 Thread Ali Farzanrad
Stefan Sperling wrote: > On Sun, Jan 01, 2023 at 09:00:30PM +0000, Ali Farzanrad wrote: > > Hi Stefan, > > > > Stefan Sperling wrote: > > > On Sun, Jan 01, 2023 at 05:00:35PM +, Ali Farzanrad wrote: > > > > Hi tech@, > > > > > >

Re: Explicit NULL assignment after free

2023-01-01 Thread Ali Farzanrad
Hi Stefan, Stefan Sperling wrote: > On Sun, Jan 01, 2023 at 05:00:35PM +0000, Ali Farzanrad wrote: > > Hi tech@, > > > > Happy new year! > > I have some weird problems with my athn interface which drives me crazy. > > > > 1. Whenever I configure my ath

Explicit NULL assignment after free

2023-01-01 Thread Ali Farzanrad
Hi tech@, Happy new year! I have some weird problems with my athn interface which drives me crazy. 1. Whenever I configure my athn as `media auto' for the first time it correctly detects correct media subclass, but as soon as I select exact same media subclass manually, it diverts to DS1 media su

Re: acme-client: check token names

2022-05-04 Thread Ali Farzanrad
Florian Obser wrote: > On 2022-05-03 17:41 +0430, Ali Farzanrad wrote: > > > > Hi Florian, > > > > Yes, I read the RFC, it should work, but I couldn't test it yet, because > > my domain manager is a little lazy (I've registeret 2 subdomains for my >

Re: acme-client: check token names

2022-05-03 Thread Ali Farzanrad
Florian Obser wrote: > On 2022-05-02 03:04 +0430, Ali Farzanrad wrote: > > Hi tech@, > > > > I know that acme-client is unveiled properly, but isn't it better to > > check token names? > > Nice catch, the token is untrusted input. > We should validate th

acme-client: check token names

2022-05-01 Thread Ali Farzanrad
Hi tech@, I know that acme-client is unveiled properly, but isn't it better to check token names? === RCS file: /cvs/src/usr.sbin/acme-client/chngproc.c,v retrieving revision 1.16 diff -u -p -r1.16 chngproc.c --- chngproc.c 12 Jul 2

Re: stpecpy(): A better string copy and concatenation function

2022-02-25 Thread Ali Farzanrad
"Alejandro Colomar (man-pages)" wrote: >char dest[SIZE]; >char *end; > >end = &dest[SIZE - 1]; >stpecpy(dest, "Hello world", end); Perfect way to introduce new hidden backdoors! Just use realloc `dest' to a new value, but forget to update `end' pro

Re: Bad comparison between double and uint64_t

2021-06-24 Thread Ali Farzanrad
roblems if you don't cast to double? > -- > ASOU Masato > > From: Ali Farzanrad > Date: Wed, 23 Jun 2021 20:24:27 + > > > Oh, my bad, sorry. > > I assumed that val is alway

Re: Bad comparison between double and uint64_t

2021-06-23 Thread Ali Farzanrad
(double)ULLONG_MAX) return (-1);/* too big/small */ if (*val == 0 && *unit == buf) return (-1);/* No conversion performed. */ Ali Farzanrad wrote: > Hi tech@, > > disklabel shows a warning at build time which might be important. > F

Bad comparison between double and uint64_t

2021-06-23 Thread Ali Farzanrad
Hi tech@, disklabel shows a warning at build time which might be important. Following diff will surpass the warning. === RCS file: /cvs/src/sbin/disklabel/editor.c,v retrieving revision 1.368 diff -u -p -r1.368 editor.c --- editor.c

Re: Undefined Behavior at jsmn.c

2020-07-12 Thread Ali Farzanrad
Florian Obser wrote: > On Sun, Jul 12, 2020 at 09:10:57AM +0200, Otto Moerbeek wrote: > > On Sun, Jul 12, 2020 at 09:57:02AM +0430, Ali Farzanrad wrote: > > > > > Hi @tech, > > > > > > I was comparing jsmn.c in acme-client with jsmn.c in FreeBSD [1]. >

Undefined Behavior at jsmn.c

2020-07-11 Thread Ali Farzanrad
Hi @tech, I was comparing jsmn.c in acme-client with jsmn.c in FreeBSD [1]. I found a switch without a default case which is an undefined behavior: @@ -69,6 +69,8 @@ case '\t' : case '\r' : case '\n' : case ' ' : case ',' : case ']' : case '}' :

pkg_info: recommend -aQ over -Q

2020-06-16 Thread Ali Farzanrad
Hi, Today I was searching for postgresql-server package using pkg_info, but I didn't found that (OpenBSD-6.7-STABLE)! $ pkg_info -Q postgres dovecot-postgresql-2.3.10.1v0 After a bit of research I found the problem in this file: /usr/libdata/perl5/OpenBSD/PackageRepositoryList.pm: ... sub match

Re: delete ligature support for Arabic "la" from the less(1) command line

2019-09-09 Thread Ali Farzanrad
Hi Ingo, Thanks for your effort in unicode support. I hope my feedback as a native Persian would be helpful. Ingo Schwarze wrote: > If i understand correctly, xterm(1) does indeed have that problem. > I prepared a test file that contains, in this order, > > - some Latin characters > - the Ar

Re: src/usr.sbin/slowcgi: possible bug

2017-01-16 Thread Ali Farzanrad
Florian Obser wrotes: >On Mon, Jan 02, 2017 at 04:29:21PM +0330, temp+...@frad.ir wrote: >> Hi tech@, >> >> I recently checked the slowcgi(8) and found that it might have an issue >> when buf_pos is at the end of buffer and buf_len is zero. >> >> Am I right? > >we can simplify this even more. The

Re: src/usr.sbin/slowcgi: possible bug

2017-01-02 Thread Ali Farzanrad
>I recently checked the slowcgi(8) and found that it might have an issue >when buf_pos is at the end of buffer and buf_len is zero. > >Am I right? It seems that all fastcgi blocks are aligned in 8-bytes and buffer size is 8+65535+255 = 65798 bytes which is not aligned in 8-bytes. It seems that slo