Re: Please test: make ipsec(4) timeouts mpsafe

2023-10-16 Thread Vitaliy Makkoveev
> On 13 Oct 2023, at 18:40, Hrvoje Popovski wrote: > > On 12.10.2023. 20:10, Vitaliy Makkoveev wrote: >> Hi, MP safe process timeouts were landed to the tree, so time to test >> them with network stack :) Diff below makes tdb and ids garbage >> collector timeout handlers running without kernel lo

Re: installer: support encryption with key disks

2023-10-16 Thread Klemens Nanni
On Mon, Sep 04, 2023 at 09:57:40PM +, Klemens Nanni wrote: > Extend the yes/no question to no/passphrase/keydisk and have users pick an > existing, preformated RAID partition; no support (yet) for creating one. > > Thanks to how ask_which() works, users can always say 'done' to land back > at

nfsd: don't clear SB_NOINTR flag

2023-10-16 Thread Vitaliy Makkoveev
This socket comes from userland, so this flag is never set. This makes SB_NOINTR flag immutable, because we only set this bit on NFS client socket buffers for all it's lifetime. I want to do this because this flag modifies sblock() behaviour and it's not clean which lock should protect it for stan

Re: timeout(1): align execvp(3) failure statuses with GNU timeout

2023-10-16 Thread Todd C . Miller
On Mon, 16 Oct 2023 10:33:18 -0500, Scott Cheloha wrote: > Per deraadt@, update EXIT STATUS, too. Looks good to me. > Do we need to keep the "128 + signal" bit? I thought that was a > normal Unix thing, and we tend to avoid saying things that are > implicitly true for every utility. I could go

Re: timeout(1): align execvp(3) failure statuses with GNU timeout

2023-10-16 Thread Scott Cheloha
On Sun, Oct 15, 2023 at 01:48:13PM -0600, Todd C. Miller wrote: > On Sun, 15 Oct 2023 13:53:46 -0500, Scott Cheloha wrote: > > > Align timeout(1)'s execvp(3) failure statuses with those of GNU > > timeout. 127 for ENOENT, 126 for everything else. > > Looks correct to me. OK millert@ Per deraad

Re: vmd testers: serial console hangs fix

2023-10-16 Thread Alexandr Nedvedicky
Hello, I've applied diff to 7.3. it works I can paste to serial console, hitting tab, etc.. Everything seems to work as expected. thanks and regards sashan On Mon, Oct 09, 2023 at 10:51:05AM -0400, Dave Voutila wrote: > Looking for folks that use the serial console connection in vmd(8) and > ex

Re: timeout(1): align execvp(3) failure statuses with GNU timeout

2023-10-16 Thread Theo de Raadt
This manual page provides details for the EXIT STATUS. This should be added. Scott Cheloha wrote: > Align timeout(1)'s execvp(3) failure statuses with those of GNU > timeout. 127 for ENOENT, 126 for everything else. > > $ cd /tmp > $ touch script.sh > $ ls -l script.sh > -rw-r--r-- 1 ssc wh

log.c use buffered IO

2023-10-16 Thread Claudio Jeker
I dislike how log.c does all these asprintf() calls with dubious workaround calls in case asprintf() fails. IMO it is easier to use the stdio provided buffers and fflush() to get "atomic" writes on stderr. At least from my understanding this is the reason to go all this lenght to do a single fprint

Re: Improve IPv6 link-local support in bgpd

2023-10-16 Thread Theo Buehler
On Mon, Oct 16, 2023 at 09:23:12AM +0200, Claudio Jeker wrote: > This diff fixes a few more things when establishing connections with > link-local IPv6 addresses. In get_alternate_addr() the interface scope > of the connection is recovered and then passed to the RDE. The RDE can > then use this sco

Re: Improve IPv6 link-local support in bgpd

2023-10-16 Thread Claudio Jeker
On Mon, Oct 16, 2023 at 09:23:12AM +0200, Claudio Jeker wrote: > This diff fixes a few more things when establishing connections with > link-local IPv6 addresses. In get_alternate_addr() the interface scope > of the connection is recovered and then passed to the RDE. The RDE can > then use this sco

Improve IPv6 link-local support in bgpd

2023-10-16 Thread Claudio Jeker
This diff fixes a few more things when establishing connections with link-local IPv6 addresses. In get_alternate_addr() the interface scope of the connection is recovered and then passed to the RDE. The RDE can then use this scope id to insert link-local addresses with the correct scope. I built a