Re: Some bwfm(4) diffs

2023-10-09 Thread Peter J. Philipp
On Mon, Oct 09, 2023 at 10:07:36PM +0200, Mark Kettenis wrote: > > Date: Mon, 09 Oct 2023 20:31:04 +0200 > > From: Mark Kettenis > > > > > Date: Mon, 9 Oct 2023 06:09:57 +0200 > > > From: "Peter J. Philipp" > > > > > > On Sun, Oct 08, 2023 at 07:42:54PM +0200, Mark Kettenis wrote: > > > > Hecto

Re: ipsecctl(8): handle non-null-terminated strings

2023-10-09 Thread Tobias Heider
On Mon, Oct 09, 2023 at 11:55:36PM +0200, Theo Buehler wrote: > On Mon, Oct 09, 2023 at 11:50:14PM +0200, Tobias Heider wrote: > > On Mon, Oct 09, 2023 at 11:24:19PM +0200, Theo Buehler wrote: > > > On Mon, Oct 09, 2023 at 10:49:53PM +0200, Tobias Heider wrote: > > > > ipsecctl wrongly assumes that

Re: ipsecctl(8): handle non-null-terminated strings

2023-10-09 Thread Theo Buehler
On Mon, Oct 09, 2023 at 11:50:14PM +0200, Tobias Heider wrote: > On Mon, Oct 09, 2023 at 11:24:19PM +0200, Theo Buehler wrote: > > On Mon, Oct 09, 2023 at 10:49:53PM +0200, Tobias Heider wrote: > > > ipsecctl wrongly assumes that strings like the pf tag or > > > the identities are always null termi

Re: ipsecctl(8): handle non-null-terminated strings

2023-10-09 Thread Tobias Heider
On Mon, Oct 09, 2023 at 11:24:19PM +0200, Theo Buehler wrote: > On Mon, Oct 09, 2023 at 10:49:53PM +0200, Tobias Heider wrote: > > ipsecctl wrongly assumes that strings like the pf tag or > > the identities are always null terminated. > > The diff below fixes the cases that always kill my > > ipsec

Re: ipsecctl(8): handle non-null-terminated strings

2023-10-09 Thread Theo Buehler
On Mon, Oct 09, 2023 at 10:49:53PM +0200, Tobias Heider wrote: > ipsecctl wrongly assumes that strings like the pf tag or > the identities are always null terminated. > The diff below fixes the cases that always kill my > ipsecctl -m when running a fuzzer. > > ok? > > Index: pfkdump.c > =

Re: Some bwfm(4) diffs

2023-10-09 Thread Patrick Wildt
On Sun, Oct 08, 2023 at 07:42:54PM +0200, Mark Kettenis wrote: > Hector Martin has added support for the BCM4388 that is found on the > last generation of Apple Macs. Based on his commits I've managed to > get it working on my M2 Pro mini. I still have to clean up some of > that stuff, but here i

ipsecctl(8): handle non-null-terminated strings

2023-10-09 Thread Tobias Heider
ipsecctl wrongly assumes that strings like the pf tag or the identities are always null terminated. The diff below fixes the cases that always kill my ipsecctl -m when running a fuzzer. ok? Index: pfkdump.c === RCS file: /mount/openb

Re: Some bwfm(4) diffs

2023-10-09 Thread Tobias Heider
On Sun, Oct 08, 2023 at 07:42:54PM +0200, Mark Kettenis wrote: > Hector Martin has added support for the BCM4388 that is found on the > last generation of Apple Macs. Based on his commits I've managed to > get it working on my M2 Pro mini. I still have to clean up some of > that stuff, but here i

Re: Some bwfm(4) diffs

2023-10-09 Thread Mark Kettenis
> Date: Mon, 09 Oct 2023 20:31:04 +0200 > From: Mark Kettenis > > > Date: Mon, 9 Oct 2023 06:09:57 +0200 > > From: "Peter J. Philipp" > > > > On Sun, Oct 08, 2023 at 07:42:54PM +0200, Mark Kettenis wrote: > > > Hector Martin has added support for the BCM4388 that is found on the > > > last gene

Re: Some bwfm(4) diffs

2023-10-09 Thread Mark Kettenis
> Date: Mon, 9 Oct 2023 06:09:57 +0200 > From: "Peter J. Philipp" > > On Sun, Oct 08, 2023 at 07:42:54PM +0200, Mark Kettenis wrote: > > Hector Martin has added support for the BCM4388 that is found on the > > last generation of Apple Macs. Based on his commits I've managed to > > get it working

pf_pull_hdr useless action pointer and fragment logic

2023-10-09 Thread Alexander Bluhm
Hi, pf_pull_hdr() allows to pass an action pointer parameter as output value. This is never used, all callers pass a NULL argument. Remove ACTION_SET() entirely. The logic if (fragoff >= len) in pf_pull_hdr() looks odd. One is the offset in the IP packet, the latter the length of some header w

vmd testers: serial console hangs fix

2023-10-09 Thread Dave Voutila
Looking for folks that use the serial console connection in vmd(8) and experience the host CPU spikes & delays associated with things like hitting the up key (to cycle shell command history) or copy/paste in X. vmd(8) approximates edge triggered interrupts with the emulated i8259 interrupt control

Re: ipsecctl(8): pledge stdio before parsing pfkey

2023-10-09 Thread Tobias Heider
On Mon, Oct 09, 2023 at 12:29:43AM +0200, Tobias Heider wrote: > The diff below adds pledge("stdio") calls for the pfkey dump subset > of ipsecctl commands. > > In particular ipsecctl -s which prints all SAs or flows in the kernel > and more importantly ipsecctl -m which contiously parses and prin