Re: scheduler_start: move static timeout structs into callback functions

2023-09-16 Thread Claudio Jeker
On Sat, Sep 16, 2023 at 11:31:45AM -0500, Scott Cheloha wrote: > The schedcpu() and loadavg() timeout structures are already hidden > from the global namespace. We can further simplify scheduler_start() > by moving the structures into the callback functions and statically > initializing them with

Re: Add ENOTDIR as possible error to unveil(2)

2023-09-16 Thread Philip Guenther
On Sat, Sep 16, 2023 at 9:47 AM Ingo Schwarze wrote: > Janne Johansson wrote on Sat, Sep 16, 2023 at 11:49:10AM +0200: > > > In case someone wants the change in a diff format, those 5 seconds > > of work are available here: > > http://c66.it.su.se:8080/obsd/unveil.2.diff > > How come jj@ forgot w

Re: Add ENOTDIR as possible error to unveil(2)

2023-09-16 Thread Zack Newman
On 9/16/23 11:01, Zack Newman wrote: Looking at sys_unveil in /sys/kern/vfs_syscalls.c, i suspect that errno actually comes from a lower layer, likely namei(9), rather than from unveil(2) itself. That is also true for EFAULT which is described. I also noticed that EACCESS is returned on line 6

Re: Add ENOTDIR as possible error to unveil(2)

2023-09-16 Thread Zack Newman
On 9/16/23 10:45, Ingo Schwarze wrote: That diff is certainly not OK. It is misleading because a "path" argument pointing to a file that is not a directory is actually valid. The problem only occurs when you add a trailing slash to the name of a file that is not a directory, like this: Yes, wh

Re: Add ENOTDIR as possible error to unveil(2)

2023-09-16 Thread Ingo Schwarze
Hi, Janne Johansson wrote on Sat, Sep 16, 2023 at 11:49:10AM +0200: > In case someone wants the change in a diff format, those 5 seconds > of work are available here: > http://c66.it.su.se:8080/obsd/unveil.2.diff How come jj@ forgot we want diffs inline? > +.It Bq Er ENOTDIR > +.Fa path > +po

scheduler_start: move static timeout structs into callback functions

2023-09-16 Thread Scott Cheloha
The schedcpu() and loadavg() timeout structures are already hidden from the global namespace. We can further simplify scheduler_start() by moving the structures into the callback functions and statically initializing them with TIMEOUT_INITIALIZER(9). ok? Index: sched_bsd.c ==

Re: rc.d/unbound: enable configtest

2023-09-16 Thread Stuart Henderson
On 2023/09/16 14:26, Bjorn Ketelaars wrote: > Currently /etc/rc.d/unbound only checks a configuration (using > unbound-checkconf) upon starting as part of rc_pre(). It would would be > nice to have a configtest, which checks a configuration before > restarting/reloading as well. > > I recently got

rc.d/unbound: enable configtest

2023-09-16 Thread Bjorn Ketelaars
Currently /etc/rc.d/unbound only checks a configuration (using unbound-checkconf) upon starting as part of rc_pre(). It would would be nice to have a configtest, which checks a configuration before restarting/reloading as well. I recently got bitten by a cron script, which made _invalid_ changes t

Re: Add ENOTDIR as possible error to unveil(2)

2023-09-16 Thread Janne Johansson
In case someone wants the change in a diff format, those 5 seconds of work are available here: http://c66.it.su.se:8080/obsd/unveil.2.diff I did not sort the existing return values in alphabetical order, there were two out of order in there, but that is a separate commit I guess. Den fre 15 sep

Re: [patch] Sort of fix for game "phantasia"

2023-09-16 Thread Theo de Raadt
It is a poor trade. Giving a user an additional gid or uid (for program lifetime), in programs which have not been reviewed (or -- cannot be reviewed and fixed), is not good. Before, setgid games could be used along with another bug to fill /var. Now, you can just fill /var because you made it w