Re: PATCH: a bit of introspection in make

2023-08-07 Thread Marc Espie
On Mon, Aug 07, 2023 at 10:05:37PM -0400, Thomas Frohwein wrote: > I looked through the file and it seems that varname_list_changed is > never set to anything but true. Is there a bit missing, like down lower > in varname_list_retrieve()? Yep, I removed it at some point because it looked like some

agtimer(4/arm64): simplify agtimer_delay()

2023-08-07 Thread Scott Cheloha
The agtimer(4/arm64) delay(9) implementation is quite complicated. This patch simplifies it. Am I missing something here? There's no reason to implement the busy-loop like this, right? ok? Index: agtimer.c === RCS file: /cvs/src/sy

Re: PATCH: a bit of introspection in make

2023-08-07 Thread Thomas Frohwein
On Mon, Aug 07, 2023 at 04:42:54PM +0200, Marc Espie wrote: > I think it could be occasionally useful to know which variables have > been defined in make. > > Incidentally, this DOES exist in GNU make, so I've reused the same name > for basically the same functionality. > > I haven't checked whet

Re: sec(4): route based ipsec vpns

2023-08-07 Thread David Gwynne
On Mon, Aug 07, 2023 at 05:36:27PM +0200, Tobias Heider wrote: > On Mon, Aug 07, 2023 at 02:22:23PM +1000, David Gwynne wrote: > > tobhe@ wrote the iked bits, so he'll commit them when he's ready. > > > > your config looks pretty much the same as mine except you specify a lot > > more stuff around

Re: standardize and simplify GitHub submodule handling in ports?

2023-08-07 Thread Stuart Henderson
On 2023/08/07 14:53, Thomas Frohwein wrote: > On Mon, Aug 07, 2023 at 06:59:15PM +0100, Stuart Henderson wrote: > [...] > > > I haven't looked at other ports, but asterisk, vim and vmm-firmware do > > not use git submodules. > > With vim, it's the way colorschemes are pulled in that *could* be >

Re: Bringing in OpenBSD

2023-08-07 Thread enh
On Mon, Aug 7, 2023 at 9:48 AM Theo de Raadt wrote: > > enh wrote: > > > (fwiw, Android has someone working on adding this header to upstream > > LLVM right now, so hopefully it should come "for free" in llvm 18. > > what, if anything, to _do_ with it is another question though :-) ) > > Will std

Re: standardize and simplify GitHub submodule handling in ports?

2023-08-07 Thread Thomas Frohwein
On Mon, Aug 07, 2023 at 06:59:15PM +0100, Stuart Henderson wrote: [...] > I haven't looked at other ports, but asterisk, vim and vmm-firmware do > not use git submodules. With vim, it's the way colorschemes are pulled in that *could* be reworked using GH_SUBMODULES syntax. The old way continues t

Re: standardize and simplify GitHub submodule handling in ports?

2023-08-07 Thread Brian Callahan
On 8/7/2023 1:59 PM, Stuart Henderson wrote: > On 2023/08/07 12:44, Thomas Frohwein wrote: >> I tested this with the about 30 ports I could identify that use GitHub >> submodules, by adjusting the Makefile to use GH_SUBMODULES. Here a few >> points from what I've observed: > .. >> >> The full table

Re: standardize and simplify GitHub submodule handling in ports?

2023-08-07 Thread Stuart Henderson
On 2023/08/07 12:44, Thomas Frohwein wrote: > I tested this with the about 30 ports I could identify that use GitHub > submodules, by adjusting the Makefile to use GH_SUBMODULES. Here a few > points from what I've observed: .. > > The full table of what I tested and the result up to if the port st

Re: Bringing in OpenBSD

2023-08-07 Thread Theo de Raadt
enh wrote: > (fwiw, Android has someone working on adding this header to upstream > LLVM right now, so hopefully it should come "for free" in llvm 18. > what, if anything, to _do_ with it is another question though :-) ) Will stdckdint.h come into common usage before or after 32-bit time_t wraps

Re: Bringing in OpenBSD

2023-08-07 Thread Theo de Raadt
Lucian Popescu wrote: > I noticed that some parts of OpenBSD use awkward techniques to detect > undefined behavior in arithmetic operations, for example: ... > The snippet was taken from lib/libexpat/lib/xmlparse.c libexpat is outside source, which we incorporate We have no influence over what

Re: standardize and simplify GitHub submodule handling in ports?

2023-08-07 Thread Thomas Frohwein
On Sun, Aug 06, 2023 at 07:00:49PM +0200, Marc Espie wrote: [...] > > > I'm also wondering if keeping the main GH_* stuff in bsd.port.mk makes a > > > lot > > > of sense, instead of grouping everything in github.port.mk > > > > I'm for it, maybe as a second step after the module for just the >

Re: Bringing in OpenBSD

2023-08-07 Thread enh
(fwiw, Android has someone working on adding this header to upstream LLVM right now, so hopefully it should come "for free" in llvm 18. what, if anything, to _do_ with it is another question though :-) ) On Mon, Aug 7, 2023 at 9:09 AM Lucian Popescu wrote: > > Hi, > > I noticed that some parts of

Bringing in OpenBSD

2023-08-07 Thread Lucian Popescu
Hi, I noticed that some parts of OpenBSD use awkward techniques to detect undefined behavior in arithmetic operations, for example: > static size_t > poolBytesToAllocateFor(int blockSize) { > /* Unprotected math would be: > ** return offsetof(BLOCK, s) + blockSize * sizeof(XML_Char); > ** >

Re: sec(4): route based ipsec vpns

2023-08-07 Thread Tobias Heider
On Mon, Aug 07, 2023 at 02:22:23PM +1000, David Gwynne wrote: > tobhe@ wrote the iked bits, so he'll commit them when he's ready. > > your config looks pretty much the same as mine except you specify a lot > more stuff around lifetimes and crypto than i do. maybe try without "tunnel > esp"? > > d

PATCH: a bit of introspection in make

2023-08-07 Thread Marc Espie
I think it could be occasionally useful to know which variables have been defined in make. Incidentally, this DOES exist in GNU make, so I've reused the same name for basically the same functionality. I haven't checked whether NetBSD/FreeBSD introduced something similar. This is a fairly straigh

Re: ldomctl: status: Make stopped ldom utilization appear as zero

2023-08-07 Thread Klemens Nanni
On Sat, Apr 22, 2023 at 12:00:44AM +, Klemens Nanni wrote: > On Fri, Apr 21, 2023 at 11:29:11PM +, Koakuma wrote: > > I noticed that when using `ldomctl status` the utilization value of > > stopped ldoms is always a copy of the previous entry's value, > > which is probably incorrect? Right

Re: installer: always create new softraid volume

2023-08-07 Thread Christian Weisgerber
Klemens Nanni: > If the root disk contains a valid CRYPTO volume, bioctl(8) by default > unlocks that instead of creating a new one. > > Use `-C force' to prevent reuse of old volumes, Yes, I like this. During testing I ran into the case where it re-used an existing crypto volume and I thought