Re: Stop using direct syscall(2) from perl(1)

2023-07-20 Thread Philip Guenther
On Thu, Jul 20, 2023 at 10:59 PM Theo de Raadt wrote: > Andrew Hewus Fresh wrote: > > > One thing to note, on the advice of miod@, I adjusted the mapping of > > size_t from u_int to u_long, but that means we no longer recognize > > getlogin_r. When I asked, miod@ suggested that syscalls.master

Re: Stop using direct syscall(2) from perl(1)

2023-07-20 Thread Theo de Raadt
Andrew Hewus Fresh wrote: > One thing to note, on the advice of miod@, I adjusted the mapping of > size_t from u_int to u_long, but that means we no longer recognize > getlogin_r. When I asked, miod@ suggested that syscalls.master was > confused. > > $ grep getlogin_r /usr/src/sys/kern/syscalls

Re: Stop using direct syscall(2) from perl(1)

2023-07-20 Thread Andrew Hewus Fresh
Here's a new patch, mostly for sthen@'s obvious fix, although I have added some of gkoehler@'s suggestions, although I have some questions and comments inline. I am looking at some of the other suggestions, but they showed up while I was testing this set. One thing to note, on the advice of miod@

Re: ietp cleanup

2023-07-20 Thread Vladimir 'phcoder' Serbinenko
Looks good toi me Le jeu. 20 juil. 2023, 20:58, joshua stein a écrit : > bmercer@ noticed there was no newline printed after a successful > attachment. I did some other minor cleanup removing duplicate > dv_xname printing during attachment and wrapping at 80 chars. > > ok? > > > Index: sys/dev/

Re: [v2] statclock: move profil(2), GPROF code into other clock interrupts

2023-07-20 Thread Scott Cheloha
On Thu, Jul 20, 2023 at 07:21:06PM +, Mike Larkin wrote: > On Thu, Jul 20, 2023 at 01:23:01PM -0500, Scott Cheloha wrote: > > On Wed, Jul 19, 2023 at 05:09:04AM +, Mike Larkin wrote: > > > On Tue, Jul 18, 2023 at 08:21:41AM -0500, Scott Cheloha wrote: > > > > This patch moves the profil(2)-

inetd echo localhost

2023-07-20 Thread Alexander Bluhm
Hi, I wonder why UDP echo does not work with inetd on 127.0.0.1. Note that it is default off. One of my regress machines has it enabled for other tests. There perl dist/Net-Ping/t/510_ping_udp.t expects that UDP echo works on 127.0.0.1. It was disabled with this commit: ---

Re: [v2] statclock: move profil(2), GPROF code into other clock interrupts

2023-07-20 Thread Mike Larkin
On Thu, Jul 20, 2023 at 01:23:01PM -0500, Scott Cheloha wrote: > On Wed, Jul 19, 2023 at 05:09:04AM +, Mike Larkin wrote: > > On Tue, Jul 18, 2023 at 08:21:41AM -0500, Scott Cheloha wrote: > > > This patch moves the profil(2)- and GPROF-specific parts of > > > statclock() out into into separate

loopback bpf tcpdump curruption

2023-07-20 Thread Alexander Bluhm
Hi, When running tcpdump on loopback, I see a currupted packet for each valid packet. root@v74:.../~# tcpdump -ni lo0 -X -vvv tcpdump: listening on lo0, link-type LOOP 21:01:07.645880 : e161 ff01 7f00 0001 7f00 0001 .a.. 0010: 0800 00df 3a4f d257 38fa 0236 0129

Re: ietp cleanup

2023-07-20 Thread Mike Larkin
On Thu, Jul 20, 2023 at 12:58:33PM -0500, joshua stein wrote: > bmercer@ noticed there was no newline printed after a successful attachment. > I did some other minor cleanup removing duplicate dv_xname printing during > attachment and wrapping at 80 chars. > > ok? > ok mlarkin > > Index: sys/dev/

Re: [v2] statclock: move profil(2), GPROF code into other clock interrupts

2023-07-20 Thread Scott Cheloha
On Wed, Jul 19, 2023 at 05:09:04AM +, Mike Larkin wrote: > On Tue, Jul 18, 2023 at 08:21:41AM -0500, Scott Cheloha wrote: > > This patch moves the profil(2)- and GPROF-specific parts of > > statclock() out into into separate clock interrupt routines. The > > profil(2) part moves into profclock

ietp cleanup

2023-07-20 Thread joshua stein
bmercer@ noticed there was no newline printed after a successful attachment. I did some other minor cleanup removing duplicate dv_xname printing during attachment and wrapping at 80 chars. ok? Index: sys/dev/i2c/ietp.c === RCS f

Re: bgpd: adjust ctl_neighbor usage

2023-07-20 Thread Claudio Jeker
On Thu, Jul 20, 2023 at 05:22:25PM +0200, Theo Buehler wrote: > On Thu, Jul 20, 2023 at 05:06:00PM +0200, Claudio Jeker wrote: > > I think it is better to use a safe ideom when matching against a peer name > > instead of forcefully NUL terminate the string somewhere unrelated. > > By default all th

Re: bgpd: adjust ctl_neighbor usage

2023-07-20 Thread Theo de Raadt
Theo Buehler wrote: > On Thu, Jul 20, 2023 at 05:22:25PM +0200, Theo Buehler wrote: > > On Thu, Jul 20, 2023 at 05:06:00PM +0200, Claudio Jeker wrote: > > > I think it is better to use a safe ideom when matching against a peer name > > > instead of forcefully NUL terminate the string somewhere un

Re: bgpd: adjust ctl_neighbor usage

2023-07-20 Thread Theo de Raadt
Theo Buehler wrote: > On Thu, Jul 20, 2023 at 05:06:00PM +0200, Claudio Jeker wrote: > > I think it is better to use a safe ideom when matching against a peer name > > instead of forcefully NUL terminate the string somewhere unrelated. > > By default all these string buffers use the same size so

Re: bgpd: adjust ctl_neighbor usage

2023-07-20 Thread Theo Buehler
On Thu, Jul 20, 2023 at 05:22:25PM +0200, Theo Buehler wrote: > On Thu, Jul 20, 2023 at 05:06:00PM +0200, Claudio Jeker wrote: > > I think it is better to use a safe ideom when matching against a peer name > > instead of forcefully NUL terminate the string somewhere unrelated. > > By default all th

Re: bgpd: adjust ctl_neighbor usage

2023-07-20 Thread Theo Buehler
On Thu, Jul 20, 2023 at 05:06:00PM +0200, Claudio Jeker wrote: > I think it is better to use a safe ideom when matching against a peer name > instead of forcefully NUL terminate the string somewhere unrelated. > By default all these string buffers use the same size so strncmp() will > not clip sinc

bgpd: adjust ctl_neighbor usage

2023-07-20 Thread Claudio Jeker
I think it is better to use a safe ideom when matching against a peer name instead of forcefully NUL terminate the string somewhere unrelated. By default all these string buffers use the same size so strncmp() will not clip since the peer description is enforced by bgpd to be smaller. Another opti

Re: bgpd, use right buffer in strlcpy

2023-07-20 Thread Theo Buehler
On Thu, Jul 20, 2023 at 12:54:33PM +0200, Claudio Jeker wrote: > Use the destination for the buffer len not the source. ok > > -- > :wq Claudio > > Index: control.c > === > RCS file: /cvs/src/usr.sbin/bgpd/control.c,v > retrieving

bgpd, use right buffer in strlcpy

2023-07-20 Thread Claudio Jeker
Use the destination for the buffer len not the source. -- :wq Claudio Index: control.c === RCS file: /cvs/src/usr.sbin/bgpd/control.c,v retrieving revision 1.110 diff -u -p -r1.110 control.c --- control.c 20 Apr 2023 12:53:27 -000