Re: huge pfsync rewrite

2023-06-28 Thread David Gwynne
On Mon, Jun 26, 2023 at 01:16:40AM +0200, Alexandr Nedvedicky wrote: > Hello, > > The new code looks much better. It's huge leap forward. I don't mind if this > big diff will get committed. Hrvoje did test the whole diff. Trying to split > it > to smaller changes might bring in code which is not

Re: profclock, gmonclock: new callbacks for profil(2)/GPROF statclock() code

2023-06-28 Thread Scott Cheloha
On Fri, Jun 23, 2023 at 04:31:59PM -0500, Scott Cheloha wrote: > On Tue, Jun 20, 2023 at 08:35:11AM -0600, Theo de Raadt wrote: > > Claudio Jeker wrote: > > > > > On Mon, Jun 19, 2023 at 06:41:14PM -0500, Scott Cheloha wrote: > > > > > On Jun 19, 2023, at 18:07, Theo de Raadt wrote: > > > > > >

Re: ftp: drop needless strcspn

2023-06-28 Thread Theo Buehler
On Wed, Jun 28, 2023 at 07:01:34PM +0200, Omar Polo wrote: > On 2023/06/28 18:47:17 +0200, Theo Buehler wrote: > > On Wed, Jun 28, 2023 at 06:37:43PM +0200, Omar Polo wrote: > > > A similar thing could be applied to rpki-client' http.c as well, it > > > should work the same. > > > > Could you ple

Re: ftp: drop needless strcspn

2023-06-28 Thread Todd C . Miller
On Wed, 28 Jun 2023 18:37:43 +0200, Omar Polo wrote: > since fetch.c revision 1.211 ("strip spaces at end of header lines and > in chunked encoding headers") ftp removes trailing whitespaces early > so we don't need to re-do that upon every header we parse. > > it can also be misleading since one

Re: ftp: drop needless strcspn

2023-06-28 Thread Omar Polo
On 2023/06/28 18:47:17 +0200, Theo Buehler wrote: > On Wed, Jun 28, 2023 at 06:37:43PM +0200, Omar Polo wrote: > > A similar thing could be applied to rpki-client' http.c as well, it > > should work the same. > > Could you please send a diff? The files have diverged, but keeping the > shared part

Re: ftp: drop needless strcspn

2023-06-28 Thread Theo Buehler
On Wed, Jun 28, 2023 at 06:37:43PM +0200, Omar Polo wrote: > since fetch.c revision 1.211 ("strip spaces at end of header lines and > in chunked encoding headers") ftp removes trailing whitespaces early > so we don't need to re-do that upon every header we parse. > > it can also be misleading sinc

ftp: drop needless strcspn

2023-06-28 Thread Omar Polo
since fetch.c revision 1.211 ("strip spaces at end of header lines and in chunked encoding headers") ftp removes trailing whitespaces early so we don't need to re-do that upon every header we parse. it can also be misleading since one can wonder why LAST_MODIFIED doesn't have " \t" but only "\t",

Re: wsmouse(4): multi-touch buttons again

2023-06-28 Thread Tobias Heider
On Wed, Jun 28, 2023 at 12:03:41AM +0200, Ulf Brosziewski wrote: > This version of the diff adds a wsconsctl field, named "mouse.tp. > mtbuttons", and an update to the wsmouse.4 page. Apart from that, it > contains only stylistic changes. > > The new wsconsctl field is just a boolean, I don't thi

Re: iked processes are orphans

2023-06-28 Thread Tobias Heider
On Wed, Jun 28, 2023 at 08:38:16AM +, Gerhard Roth wrote: > Hi Tobi, > > a recent change to iked.c moved the call to daemon() behind proc_init(). > Now iked forks all its children and afterwards daemonizes itself into > background leaving the kids behind orphaned. > > The patch below restores

Re: mg.1: add no-tab-mode to set-default-mode description

2023-06-28 Thread Omar Polo
Hi, On 2023/06/27 18:53:44 -0700, "Simon Branch" wrote: > Hello! > > I've been enjoying the resurrection of no-tab-mode in mg(1). > It is simple to enable by default: > > set-default-mode notab > > The manual page says that "built in modes include fill, indent and > overwrite". This patch

iked processes are orphans

2023-06-28 Thread Gerhard Roth
Hi Tobi, a recent change to iked.c moved the call to daemon() behind proc_init(). Now iked forks all its children and afterwards daemonizes itself into background leaving the kids behind orphaned. The patch below restores the parent/child relationship. With it, the parent calls daemon() first. An