all platforms, main(): call clockqueue_init() just before sched_init_cpu()

2023-06-12 Thread Scott Cheloha
We need to initialize the per-CPU clockintr_queue struct before we can call clockintr_establish() from sched_init_cpu(). Initialization is done with a call to clockqueue_init(). Currently we call it during clockintr_cpu_init(), i.e. each CPU initializes its own clockintr_queue struct. This patch

Re: First step towards improved unlocking in the VFS layer.

2023-06-12 Thread Thordur I. Bjornsson
On Mon, Jun 12, 2023 at 9:15 PM Bob Beck wrote: > > On Mon, Jun 12, 2023 at 11:01:18AM -0600, Theo de Raadt wrote: > > + KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche"); > > That part of the diff is not OK. If everyone did this, we would have a > > mess on our hands. > (or I

Re: seq: fix check for rounding error/truncation

2023-06-12 Thread Todd C . Miller
On Mon, 12 Jun 2023 18:48:56 +0100, Stuart Henderson wrote: > Neither of these are really ideal, and mean that we still need gseq > for integers >= 1,000,000 > > $ seq 99 99 > 99 > $ seq 100 100 > 1e+06 > > $ gseq 105 105 > 105 That probably requires a separate cod

Re: First step towards improved unlocking in the VFS layer.

2023-06-12 Thread Bob Beck
On Mon, Jun 12, 2023 at 11:01:18AM -0600, Theo de Raadt wrote: > + KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche"); > > That part of the diff is not OK. If everyone did this, we would have a > mess on our hands. Yeah, thats me nodding to my own past stupidity ;) changed t

Re: seq: fix check for rounding error/truncation

2023-06-12 Thread Stuart Henderson
On 2023/06/12 11:20, Todd C. Miller wrote: > We need to compare the printable version of the last value displayed, > not the floating point representation. Otherwise, we may print the > last value twice. > > Old: > > $ seq 105 105 > 1.05e+06 > 1.05e+06 > > New: > > $ se

Re: seq: fix check for rounding error/truncation

2023-06-12 Thread Todd C . Miller
For context, see: https://chaos.social/@Gottox/110527807405964874 https://github.com/chimera-linux/chimerautils/commit/1ecc1e99d4a309631e846a868b5a422f996704ac

seq: fix check for rounding error/truncation

2023-06-12 Thread Todd C . Miller
We need to compare the printable version of the last value displayed, not the floating point representation. Otherwise, we may print the last value twice. Old: $ seq 105 105 1.05e+06 1.05e+06 New: $ seq 105 105 1.05e+06 We really need seq regression tests.

Re: First step towards improved unlocking in the VFS layer.

2023-06-12 Thread Theo de Raadt
+ KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche"); That part of the diff is not OK. If everyone did this, we would have a mess on our hands.

First step towards improved unlocking in the VFS layer.

2023-06-12 Thread Bob Beck
Minimal diff, further cleanup and dead code removal to follow. --- sys/kern/vfs_syscalls.c | 7 +++ sys/sys/mount.h | 2 +- sys/ufs/ffs/ffs_softdep.c | 2 ++ sys/ufs/ffs/ffs_vfsops.c | 16 +++- 4 files changed, 9 insertions(+), 18 deletions(-) diff --git a/sys/ker

tso ip6 forward

2023-06-12 Thread Alexander Bluhm
Hi, I found a little inconsistency in IPv6 forwarding with TSO. Sending with TSO should only done if the large packet does not fit in the interface MTU. In case tcp_if_output_tso() does not process the packet, we should send an ICMP6 error. Rearrange the code that it looks more like other calls

Re: Kill if_detached_ioctl()

2023-06-12 Thread Alexander Bluhm
On Wed, Jun 07, 2023 at 01:36:23PM +0300, Vitaliy Makkoveev wrote: > In this point the interface is already removed from the list of all > interfaces and from the interface index map and all possible > concurrent ioctl() threads finished. Remove this dead code. Should we set ifp->if_ioctl to NULL?

Re: if_detach(): move nd6_ifdetach() out of netlock

2023-06-12 Thread Alexander Bluhm
On Wed, Jun 07, 2023 at 01:15:46PM +0300, Vitaliy Makkoveev wrote: > In this point, the interface is disconnected from everywhere. No need to > hold netlock for dummy 'nd_ifinfo' release. Netlock is also not needed > for TAILQ_EMPTY(&ifp->if_*hooks) assertions. OK bluhm@ > Index: sys/net/if.c > =

Re: [patch] urtwn(4): add Mercusys MW150US to the urtwn hardware list.

2023-06-12 Thread Jonathan Gray
On Mon, Jun 12, 2023 at 07:47:01PM +0900, Daeil Lee wrote: > Hello tech@, > > This patch adds Mercusys MW150US to urtwn(4) supported hardware. I tested > two devices and both worked. > > # dmesg > urtwn0 at uhub0 port 1 configuration 1 interface 0 "Realtek 802.11n NIC" > rev 2.00/0.00 addr

[patch] urtwn(4): add Mercusys MW150US to the urtwn hardware list.

2023-06-12 Thread Daeil Lee
Hello tech@, This patch adds Mercusys MW150US to urtwn(4) supported hardware. I tested two devices and both worked. # dmesg urtwn0 at uhub0 port 1 configuration 1 interface 0 "Realtek 802.11n NIC" rev 2.00/0.00 addr 2 urtwn0: MAC/BB RTL8188EU, RF 6052 1T1R, address 00:eb:d8:xx:xx:xx # u

Re: bgpd: simplify IMSG_CTL_SHOW_RIB_ATTR handling

2023-06-12 Thread Theo Buehler
On Mon, Jun 12, 2023 at 12:35:33PM +0200, Claudio Jeker wrote: > On Mon, Jun 12, 2023 at 12:18:19PM +0200, Theo Buehler wrote: > > On Mon, Jun 12, 2023 at 11:43:11AM +0200, Claudio Jeker wrote: > > > To generate the IMSG_CTL_SHOW_RIB_ATTR message just use attr_writebuf() > > > instead of going via

Re: bgpd: simplify IMSG_CTL_SHOW_RIB_ATTR handling

2023-06-12 Thread Claudio Jeker
On Mon, Jun 12, 2023 at 12:18:19PM +0200, Theo Buehler wrote: > On Mon, Jun 12, 2023 at 11:43:11AM +0200, Claudio Jeker wrote: > > To generate the IMSG_CTL_SHOW_RIB_ATTR message just use attr_writebuf() > > instead of going via ibuf_reserve() and attr_write(). > > > > While there make a pointer !=

Re: bgpd: simplify IMSG_CTL_SHOW_RIB_ATTR handling

2023-06-12 Thread Theo Buehler
On Mon, Jun 12, 2023 at 11:43:11AM +0200, Claudio Jeker wrote: > To generate the IMSG_CTL_SHOW_RIB_ATTR message just use attr_writebuf() > instead of going via ibuf_reserve() and attr_write(). > > While there make a pointer != NULL check more obvious. ok > @@ -2934,12 +2933,8 @@ rde_dump_rib_as(

bgpd: simplify IMSG_CTL_SHOW_RIB_ATTR handling

2023-06-12 Thread Claudio Jeker
To generate the IMSG_CTL_SHOW_RIB_ATTR message just use attr_writebuf() instead of going via ibuf_reserve() and attr_write(). While there make a pointer != NULL check more obvious. -- :wq Claudio Index: rde.c === RCS file: /cvs/src/