Re: libtls, smtpd: switch to EC_KEY_METHOD

2023-05-25 Thread Theo Buehler
On Thu, May 25, 2023 at 07:23:48PM +0200, Omar Polo wrote: > As far as I (and grep) can see, smtpd and the part it needs in libtls > are the only user of ECDSA_METHOD in tree. Yes, nothing else should be using this anymore, including ports. ECDSA_METHOD and ECDH_METHOD were merged into EC_KEY_MET

Re: pfioctl: drop net lock from SIOC{S,G}LIMIT

2023-05-25 Thread Alexandr Nedvedicky
Hello, On Thu, May 25, 2023 at 07:14:54AM +, Klemens Nanni wrote: > On Thu, May 25, 2023 at 03:28:45AM +, Klemens Nanni wrote: > > On Thu, May 25, 2023 at 03:20:04AM +, Klemens Nanni wrote: > > > pfsync_in_bus() looks like the only place where the static array > > > pf_pool_limits[] is

Re: ix(4): LRO forwarding

2023-05-25 Thread Jan Klemkow
On Wed, May 24, 2023 at 05:28:58PM +0200, Alexander Bluhm wrote: > On Tue, May 23, 2023 at 02:14:57PM +0200, Jan Klemkow wrote: > > Hi, > > > > This diff sets needed offloading flags and the calculated mss to LRO > > mbufs in ix(4). Thus, we can forward this packets and process them via > > tcp_i

libtls, smtpd: switch to EC_KEY_METHOD

2023-05-25 Thread Omar Polo
As far as I (and grep) can see, smtpd and the part it needs in libtls are the only user of ECDSA_METHOD in tree. What I've understood talking with tb (and apologizes if I'm making mistakes) is that ECDSA_METHOD was replaced with EC_KEY_METHOD. "We" inherited the former, it got used in smtpd, and

Re: userdel: remove login group for =uid

2023-05-25 Thread Todd C . Miller
On Thu, 25 May 2023 06:54:08 +0100, Stuart Henderson wrote: > > As Aisha pointed out, pkg_delete hints could be updated too. > > If that is done, pkg_delete would need to check whether the group will > actually get removed i.e. make sure that no other user has been added > to the group. If pkg_de

Re: bgpd fix for possible crash in SE

2023-05-25 Thread Claudio Jeker
On Thu, May 25, 2023 at 02:20:37PM +0100, Stuart Henderson wrote: > On 2023/05/25 15:06, Claudio Jeker wrote: > > sthen@ reported a bgpd SE crash to me and after inspection of the report > > it looks like he managed to trigger a mistake in session_process_msg(). > > When for example a NOTIFICATION

Re: bgpd fix for possible crash in SE

2023-05-25 Thread Stuart Henderson
On 2023/05/25 15:06, Claudio Jeker wrote: > sthen@ reported a bgpd SE crash to me and after inspection of the report > it looks like he managed to trigger a mistake in session_process_msg(). > When for example a NOTIFICATION message is received then the state change > clears the rbuf. Now normally

Re: bgpd fix for possible crash in SE

2023-05-25 Thread Theo Buehler
On Thu, May 25, 2023 at 03:06:05PM +0200, Claudio Jeker wrote: > sthen@ reported a bgpd SE crash to me and after inspection of the report > it looks like he managed to trigger a mistake in session_process_msg(). > When for example a NOTIFICATION message is received then the state change > clears th

bgpd fix for possible crash in SE

2023-05-25 Thread Claudio Jeker
sthen@ reported a bgpd SE crash to me and after inspection of the report it looks like he managed to trigger a mistake in session_process_msg(). When for example a NOTIFICATION message is received then the state change clears the rbuf. Now normally the for loop starts over afterwards and the if (p-

Re: smtpd.h: drop two unused define

2023-05-25 Thread giovanni
On 5/25/23 11:18, Omar Polo wrote: both values have been unused for quite some time. last PROC_COUNT use was removed in 'Implement the fork+exec pattern in smtpd' by eric@ in 2016. I've checked the other #defines and they seem to be all used, except these two. ok? sure, ok giovanni@ Cheers

Re: smtpd.h: drop two unused define

2023-05-25 Thread Theo Buehler
On Thu, May 25, 2023 at 11:18:00AM +0200, Omar Polo wrote: > both values have been unused for quite some time. last PROC_COUNT use > was removed in 'Implement the fork+exec pattern in smtpd' by eric@ in > 2016. > > I've checked the other #defines and they seem to be all used, except > these two.

Re: Virtio fix for testing

2023-05-25 Thread Klemens Nanni
On Wed, May 24, 2023 at 08:50:26PM +0200, Stefan Fritsch wrote: > I forgot to mention that no stress test is necessary. If it boots and the > virtio devices work at all, that should be enough. amd64 bsd.mp keeps working with disks and network interfaces behind VirtIO, no dmesg or behaviour change

smtpd.h: drop two unused define

2023-05-25 Thread Omar Polo
both values have been unused for quite some time. last PROC_COUNT use was removed in 'Implement the fork+exec pattern in smtpd' by eric@ in 2016. I've checked the other #defines and they seem to be all used, except these two. ok? diff /usr/src commit - 6f5cff98d90c274a5222db1a9bd17d5c26da7920 p

Re: 443 udp for /etc/services

2023-05-25 Thread Tom Smyth
... If IANA say it (and Stuart says it) ... then .. Im not going to contradict :) (or at least persist in contradicting Stuart :) Thanks for the clarificaiton... On Thu, 25 May 2023 at 10:38, Stuart Henderson wrote: > > On 2023/05/25 10:29, Tom Smyth wrote: > > Folks, > > > > Can I suggest call

Re: 443 udp for /etc/services

2023-05-25 Thread Stuart Henderson
On 2023/05/25 10:29, Tom Smyth wrote: > Folks, > > Can I suggest calling it quic as opposed to https I think it should follow the name in the IANA registry which uses https. > do we want PF Firewal to match https for TCP and UDP (for traditional) > servers that only require https TCP ... PF req

Re: 443 udp for /etc/services

2023-05-25 Thread Tom Smyth
Folks, Can I suggest calling it quic as opposed to https do we want PF Firewal to match https for TCP and UDP (for traditional) servers that only require https TCP ... Just a thought On Thu, 25 May 2023 at 10:27, Stuart Henderson wrote: > > - Forwarded message from Renaud Allard - >

443 udp for /etc/services

2023-05-25 Thread Stuart Henderson
- Forwarded message from Renaud Allard - From: Renaud Allard Date: Thu, 25 May 2023 10:48:24 +0200 To: po...@openbsd.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: http3 in nginx On 5/24/23 18:01, Theo Buehler wrote: > This i

installer: simplify yes/no answer handling

2023-05-25 Thread Klemens Nanni
ask_yn() returns 0/1 for no/yes, so almost all users in install.sub use the same 'ask_yn && do-it', 'ask_yn || skip' idioms. Adjust two MD calls accordingly. OK? Index: amd64/common/install.md === RCS file: /cvs/src/distrib/amd64/co

Re: pfioctl: drop net lock from SIOC{S,G}LIMIT

2023-05-25 Thread Klemens Nanni
On Thu, May 25, 2023 at 03:28:45AM +, Klemens Nanni wrote: > On Thu, May 25, 2023 at 03:20:04AM +, Klemens Nanni wrote: > > pfsync_in_bus() looks like the only place where the static array > > pf_pool_limits[] is accessed without the pf lock, so grab it there. > > > > Limits themselves are