Re: pkg-config tweaks

On Mon, May 22, 2023 at 09:33:48AM +0200, Marc Espie wrote: > - move to 5.36: signatures + prototypes mostly everywhere > Not used for Getopt::Long, because the calling conventions are somewhat > too verbose. > - use constant for the mode{libs} and mode{cflags} values > - remove two completely unne

vmd: fix local prefix validation from vm.conf

As mentioned before on bugs@ [1], the custom local prefix feature of vmd broke with some of the recent changes. Since fixing this touches a lot of parts of vmd, I'm breaking it up to make it reviewable by others and hopefully less daunting. This diff fixes an existing issue (predating recent chang

Re: syn cache tcp checksum

On 22.5.2023. 22:17, Alexander Bluhm wrote: > Hi, > > I noticed a missing checksum count in netstat tcp packets sent > software-checksummed. Turns out that our syn cache does the checksum > calculation by hand, instead of the established mechanism in ip > output. > > Just set the flag M_TCP_CSUM

syn cache tcp checksum

Hi, I noticed a missing checksum count in netstat tcp packets sent software-checksummed. Turns out that our syn cache does the checksum calculation by hand, instead of the established mechanism in ip output. Just set the flag M_TCP_CSUM_OUT and let in_proto_cksum_out() do the work later. While

Re: synaptics touchpad with no multifinger support

Sorry for being so late with my reply. Checking SYNAPTICS_CAP_MULTIFINGER is not sufficient. There are Synaptics touchpads that don't report this capability but do provide contact counts (and that's not a rare case). Adding a test for AGM support seems to be a viable workaround, see https:/

Re: rpki-client: use ASN1_INTEGER_get_uint64()

On Mon, May 22, 2023 at 05:48:01PM +0200, Theo Buehler wrote: > LibreSSL 3.6 added ASN1_INTEGER_get_uint64() from OpenSSL. While this > still isn't great, at least it allows for unambiguous error checking. > > In as_id_parse() we can replace some hand-rolled parsing which > simplifies things a bit

Re: rpki-client convert -f output to json_do api

On Mon, May 22, 2023 at 04:26:20PM +0200, Claudio Jeker wrote: > On Wed, May 03, 2023 at 10:04:33AM +0200, Claudio Jeker wrote: > > This diff converts the current print code of -f to use json_do api. > > I did some minimal refactoring to reduce code repetition and more is for > > sure possible. I c

rpki-client: use ASN1_INTEGER_get_uint64()

LibreSSL 3.6 added ASN1_INTEGER_get_uint64() from OpenSSL. While this still isn't great, at least it allows for unambiguous error checking. In as_id_parse() we can replace some hand-rolled parsing which simplifies things a bit. The ASN1_INTEGER_get() API should not be used since it doesn't allow

Re: rpki-client convert -f output to json_do api

On Wed, May 03, 2023 at 10:04:33AM +0200, Claudio Jeker wrote: > This diff converts the current print code of -f to use json_do api. > I did some minimal refactoring to reduce code repetition and more is for > sure possible. I changed the way how the errstr is dumped but apart from > that the objec

Re: rpki-client: use OpenSSL 1.1 ASN1_TIME API

On Tue, May 09, 2023 at 05:30:26PM +0200, Theo Buehler wrote: > beck ported the OpenSSL ASN1_TIME API to use the ASN1_time* API under > the hood, so for LibreSSL the diff here is a noop. > > This allows us to eliminate most of the gross openssl hacks in regress. > The unistd.h thing is still neede

Re: Add LRO counter in ix(4)

On 18.5.2023. 10:46, Jan Klemkow wrote: > On Thu, May 18, 2023 at 12:01:44AM +0200, Alexander Bluhm wrote: >> On Tue, May 16, 2023 at 09:11:48PM +0200, Jan Klemkow wrote: >>> @@ -412,6 +412,10 @@ tcp_stats(char *name) >>> p(tcps_outhwtso, "\t\t%u output TSO packet%s hardware processed\n"); >>>

pkg-config tweaks

- move to 5.36: signatures + prototypes mostly everywhere Not used for Getopt::Long, because the calling conventions are somewhat too verbose. - use constant for the mode{libs} and mode{cflags} values - remove two completely unneeded [] in regexps - fix indentation and parentheses in a few location