Re: smtpd: some fatal -> fatalx

2023-05-18 Thread Giovanni Bechis
On Tue, May 16, 2023 at 02:51:44PM +0200, Omar Polo wrote: > while debugging a pebkac in -portable, I noticed that in various > places we use fatal() for libtls failures. errno doesn't generally > contains anything useful after libtls functions, and in most it's > explicitly cleared to avoid misus

ypldap: try servers until one succeeds

2023-05-18 Thread Jonathan Matthew
We sometimes run into situations where one of the three servers a ypldap can talk to will accept a TCP connection but won't do TLS properly, or won't perform LDAP searches. ypldap currently only tries servers until one accepts the connection, so when this happens, it is less successful at updating

Re: net_tq_barriers()

2023-05-18 Thread Claudio Jeker
On Fri, May 19, 2023 at 01:56:38PM +1000, David Gwynne wrote: > this is a tiny slice off a big pfsync diff i've been working on. when > you bring pfsync down i need it to wait until all the work it's been > doing in the network stack has finished, which means i need a barrier > for all the network

net_tq_barriers()

2023-05-18 Thread David Gwynne
this is a tiny slice off a big pfsync diff i've been working on. when you bring pfsync down i need it to wait until all the work it's been doing in the network stack has finished, which means i need a barrier for all the network taskqs. that's what this implements. a barrier per taskq would mean i

Re: user: handle paths with whitespace / metacharacters

2023-05-18 Thread Omar Polo
On 2023/05/18 11:28:58 -0600, Todd C. Miller wrote: > On Thu, 18 May 2023 18:13:57 +0200, Omar Polo wrote: > > > + if (ret != 0) > > > + warnx("[Warning] unable to run `%s'", buf); > > > > more than "unable to run" I'd say "failed to run" or "command > > fai

Re: install.sub: two little ergonomic tweaks

2023-05-18 Thread Theo de Raadt
Alexander Klimov wrote: > Wait a second! > (Yes, one of my biggest talents is to "oversee elephants"TM, but not this > time.) > E.g. I use the (C)ustom layout which *clearly indicates* its one-(C)har > shortcut. > Other prompts, like my diff(1)ed one, *do not*. > > Change my mind. > > Now, gi

Re: install.sub: two little ergonomic tweaks

2023-05-18 Thread Alexander Klimov
On 18.05.23 15:56, Theo de Raadt wrote: Alexander Klimov wrote: --- distrib/miniroot/install.sub.orig Thu May 18 12:37:52 2023 +++ distrib/miniroot/install.subThu May 18 12:44:49 2023 @@ -2306,15 +2306,15 @@ [[ $START_SSHD == y ]] || return if [[ -z $ADMIN ]]; t

Re: user: handle paths with whitespace / metacharacters

2023-05-18 Thread Todd C . Miller
On Thu, 18 May 2023 18:13:57 +0200, Omar Polo wrote: > existing code just used 0 and 1 (e.g. creategid.) lone zeros as > arguments are not really readable, but still I can't make myself > liking stdbool. not that my tastes matters, but it seems to be used > very sparsingly in usr.sbin This was

Re: ix hardware tso

2023-05-18 Thread Peter Stuge
Alexander Bluhm wrote: > we cannot do hardware TSO in a bridge. Maybe we could if all > bridge members support it. Just a note that I've discussed another "if all bridge members" case with dlg; switch drivers eventually knowing to do bridge offloading. //Peter

Re: user: handle paths with whitespace / metacharacters

2023-05-18 Thread Omar Polo
On 2023/05/18 09:11:59 -0600, Todd C. Miller wrote: > The way user(8) runs commands via system(3) is fragile. It does > not correctly handle paths with whitespace or shell metacharacters. > Rather than try to quote everything (which is also fragile) I think > it is safest to just exec the command

user: handle paths with whitespace / metacharacters

2023-05-18 Thread Todd C . Miller
The way user(8) runs commands via system(3) is fragile. It does not correctly handle paths with whitespace or shell metacharacters. Rather than try to quote everything (which is also fragile) I think it is safest to just exec the commands directly. OK? - todd Index: usr.sbin/user/user.c ==

Re: install.sub: two little ergonomic tweaks

2023-05-18 Thread Theo de Raadt
Alexander Klimov wrote: > First of all, my compliment. > The installer is already quite ergonomic (for a CLI ;) ). > But there are the following two little diff(1)s standing > between it and its perfection IMAO. > > > --- distrib/miniroot/install.sub.orig Thu May 18 12:37:52 2023 > +++ distri

Re: install.sub: two little ergonomic tweaks

2023-05-18 Thread Theo de Raadt
Alexander Klimov wrote: > --- distrib/miniroot/install.sub.orig Thu May 18 12:37:52 2023 > +++ distrib/miniroot/install.subThu May 18 12:44:49 2023 > @@ -2306,15 +2306,15 @@ > [[ $START_SSHD == y ]] || return > > if [[ -z $ADMIN ]]; then > echo "Since no

install.sub: two little ergonomic tweaks

2023-05-18 Thread Alexander Klimov
Hello devs! First of all, my compliment. The installer is already quite ergonomic (for a CLI ;) ). But there are the following two little diff(1)s standing between it and its perfection IMAO. --- distrib/miniroot/install.sub.orig Thu May 18 12:37:52 2023 +++ distrib/miniroot/install.sub

Re: Unlock ip6_sysctl()

2023-05-18 Thread Florian Obser
On 2023-05-18 00:14 +02, Alexander Bluhm wrote: > And why is this ip6_soiikey in the kernel anyway? I guess it is > from a time when address configuration was done in the kernel. > Could slaacd(8) just read /etc/soii.key? Originally we implemented RFC 7217 for link-local addresses, too. The valu

Re: Unlock ip6_sysctl()

2023-05-18 Thread Claudio Jeker
On Thu, May 18, 2023 at 01:56:13AM +0300, Vitaliy Makkoveev wrote: > > On 18 May 2023, at 01:14, Alexander Bluhm wrote: > > > > On Wed, May 17, 2023 at 12:46:02PM +0300, Vitaliy Makkoveev wrote: > >> Introduce `ip6_soiikey_lock' rwlock(9) to protect `ip6_soiikey'. It > >> accessed only by ip6_sys

Re: Add LRO counter in ix(4)

2023-05-18 Thread Jan Klemkow
On Thu, May 18, 2023 at 12:01:44AM +0200, Alexander Bluhm wrote: > On Tue, May 16, 2023 at 09:11:48PM +0200, Jan Klemkow wrote: > > @@ -412,6 +412,10 @@ tcp_stats(char *name) > > p(tcps_outhwtso, "\t\t%u output TSO packet%s hardware processed\n"); > > p(tcps_outpkttso, "\t\t%u output TSO pa