Re: patch: profiling using utrace(2) (compatible with pledge and unveil)

2023-05-08 Thread Job Snijders
Hi Sebastien, Super super interesting stuff! On Tue, Apr 11, 2023 at 09:28:31AM +0200, Sebastien Marie wrote: > ## compile and collect profil information (-tu option on ktrace is optional) > $ cc -static -pg test.c > $ ktrace -di -tu ./a.out > > ## get gmon.out file > $ kdump -u gmon.out | unvis

[patch] Discontinued Toshiba dynadock lines for usbdevs and udl driver

2023-05-08 Thread S V
Good Day, https://uk.dynabook.com/discontinued-products/pa3542e-2prp/ one more device with old (probably DL-160, but unsure so leaving DLUNK) DisplayLink chip. works ok. $ less /var/log/Xorg.0.log | grep wsudl [ 114.394] (II) LoadModule: "wsudl" [ 114.395] (II) Loading /usr/X11R6/lib/modules

Re: passwd: fix error paths and undefined behaviour

2023-05-08 Thread Todd C . Miller
On Mon, 08 May 2023 16:17:51 -, Tobias Stoeckmann wrote: > Turns out that we have yet another possibility to trigger a theoretical > signed integer overflow if pwd_tries is INT_MAX. This one avoids such > situation as well. OK millert@ - todd

Re: passwd: fix error paths and undefined behaviour

2023-05-08 Thread Tobias Stoeckmann
I have committed the error handling aspects of the patch. Turns out that we have yet another possibility to trigger a theoretical signed integer overflow if pwd_tries is INT_MAX. This one avoids such situation as well. Okay? Index: local_passwd.c =

Re: less proto cksum out

2023-05-08 Thread Claudio Jeker
On Mon, May 08, 2023 at 02:29:12PM +0200, Alexander Bluhm wrote: > Hi, > > The call to in_proto_cksum_out() is only needed before the packet > is passed to ifp->if_output(). The fragment code has its own > checksum calculation and the other paths end in goto bad. > > My TSO tcp_copper() will als

less proto cksum out

2023-05-08 Thread Alexander Bluhm
Hi, The call to in_proto_cksum_out() is only needed before the packet is passed to ifp->if_output(). The fragment code has its own checksum calculation and the other paths end in goto bad. My TSO tcp_copper() will also do its own checksum handling, so I have to move the call to in_proto_cksum_ou

Re: nd6 RTM_ADD logic

2023-05-08 Thread Claudio Jeker
On Thu, May 04, 2023 at 08:43:19AM +0200, Alexander Bluhm wrote: > Hi, > > To make ND6 mp-safe, I have to guarantee the life time of ln = > rt->rt_llinfo. This call to nd6_llinfo_settimer(ln) looks strange. > > The complicated logic can be replaced with what we have in ARP. > Digging through the

Fix possible mem-leak in snmpd/usm.c

2023-05-08 Thread Gerhard Roth
Rev 1.25 introduced a mem-leak: Index: usr.sbin/snmpd/usm.c === RCS file: /cvs/src/usr.sbin/snmpd/usm.c,v retrieving revision 1.25 diff -u -p -r1.25 usm.c --- usr.sbin/snmpd/usm.c20 Dec 2022 20:01:25 - 1.25 +++ usr.s

Partial chains for rpki-client

2023-05-08 Thread Theo Buehler
The diff below is based on a hint by beck and was discussed extensively with beck, claudio and job during and after m2k23. It results in a quite significant reduction of the runtime of an ordinary rpki-client run as usually done from cron. One problem we're facing with the generally rather poor qu

Re: installer: disk crypto: crank KDF rounds to hardware based default

2023-05-08 Thread Klemens Nanni
On Sun, Apr 23, 2023 at 05:07:30PM +, Klemens Nanni wrote: > For new installs, it seems adequate to base the number on the actual hardware, > assuming the CRYPTO volume will stay in that hardware for a while. > > The current default of 16 is from old PKCS5 PBKDF2 times and changing it in > bio