All cases do the same check up first, so merge it before the switch.
It could be hoisted further in both in_ioctl() and in_ioctl_change_ifaddr(),
but that meant a change in errno return semantic, so leave it for now.
Feedback? Objection OK?
Index: in.c
===
On Fri, Apr 14, 2023 at 10:30:57PM +, Klemens Nanni wrote:
> Saw 'error = ifioctl(); return error;' which I did not fold when removing
> the lock around the call back then.
>
> That should be simplified, but the variable could be dropped completely.
> Or is it likely to be used in future versi
Saw 'error = ifioctl(); return error;' which I did not fold when removing
the lock around the call back then.
That should be simplified, but the variable could be dropped completely.
Or is it likely to be used in future versions of this function?
Index: kern/sys_socket.c
=
On Sat, Dec 10, 2022 at 03:40:35AM +, Klemens Nanni wrote:
> On Wed, Nov 30, 2022 at 06:17:51PM +, Klemens Nanni wrote:
> > Follow up on how in6_ioctl() does it: grab the kernel lock in all the
> > ioctl specific functions, where needed and not earlier, i.e. exactly where
> > the net lock
Dear tech,
while reading through ffs code I was looking for calls to ffs_truncate.
This would have saved me a few seconds.
OK?
mbuhl
Index: ufs/ffs/ffs_vfsops.c
===
RCS file: /cvs/src/sys/ufs/ffs/ffs_vfsops.c,v
retrieving revision 1
hi list,
The current route-reflector option in openbgpd is to set it per neighbor
address.
When the ipv4 neighbor address has capabilities for VPNv4 and IPv4 unicast,
how would one disable route-reflection for only the VPNv4 part?
I also noticed that the cluster-id is prepended on the RIB-In wher
On Thu, Apr 13, 2023 at 10:43:30AM +0800, Kevin Lo wrote:
> M_CANFAIL
> In the M_WAITOK case, if not enough memory is available,
> return NULL instead of calling panic(9). If mallocarray()
Did you see such a panic? If yes it would be better to understand
and fix the root cause.
>
