installer: disk crypto: always correct root disk default

2023-04-01 Thread Klemens Nanni
For install, the root disk defaults to the first available [sw]d* disk. The new encryption question creates a softraid volume for you, which is obviously to be used as root disk. But on systems with multiple disks, the next one available may be another. Available disks are: sd0 sd1.

Re: wire in efi_reset on MSFT Surface systems to rix reboots

2023-04-01 Thread Mike Larkin
On Sat, Jan 21, 2023 at 09:59:13AM -0500, Dave Voutila wrote: > I've long moaned about how my Go3 can't reboot. Woe is me. Now that > kettenis@ landed some scaffolding for efi(4), I would love to get my Go3 > working in the reboot department. > > The approach I'm thinking, in the diff below, is to

malloc: variation in junk locations

2023-04-01 Thread Otto Moerbeek
Hi, by default an allocation isn't fully written with junk bytes, only at certain spots. This introduces variations in the spot, so we have a bigger chance of catching write-after-frees in specific spots. After a remark from jsing@ that variation would be nice to have for this. -Otto In

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-01 Thread Steffen Nurpmeso
Jared Harper wrote in : |On Sat, Apr 1, 2023 at 12:06 AM Theo Buehler wrote: ... |I'm not sure these are equivalent. My (limited?) understanding is these |examples are checking whether the file's owner has the specified |permissions. | |The intention for my patch is to return true if the c

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-01 Thread Jared Harper
On Sat, Apr 1, 2023 at 12:06 AM Theo Buehler wrote: > > While I agree with Solène that we don't necessarily want or need this > patch, I think it is nicely done. I myself don't find the -perm primary > very intuitive and I find its manual hard to decipher, so your patch > would save me a few minut

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-01 Thread Klemens Nanni
01.04.2023 13:33, Mikhail пишет: > Currently default answer for the question is 'yes', which is not true > for install case, but correct for upgrade one. True for sysupgrade(8) (at least with default /home/_sysupgrade), but certainly not true in general for every update scenario. > Changing defau

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-01 Thread Omar Polo
On 2023/04/01 16:33:39 +0300, Mikhail wrote: > Currently default answer for the question is 'yes', which is not true > for install case, but correct for upgrade one. > > Changing default answer depending on the mode of the installer looks > like a good approach. Idea by Christian (naddy@), implem

[installer] default answer to "Is the disk partition already mounted?"

2023-04-01 Thread Mikhail
Currently default answer for the question is 'yes', which is not true for install case, but correct for upgrade one. Changing default answer depending on the mode of the installer looks like a good approach. Idea by Christian (naddy@), implementation and testing are mine. diff /usr/src commit - c

refactor single_thread_check_locked

2023-04-01 Thread Claudio Jeker
This just reverses the first if statement in the function so that the code can be deindented by on level. diff -b output: @@ -2018,7 +2018,9 @@ single_thread_check_locked(struct proc * SCHED_ASSERT_LOCKED(); - if (pr->ps_single != NULL && pr->ps_single != p) { + if (pr->ps_

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-01 Thread Theo Buehler
On Fri, Mar 31, 2023 at 07:40:45PM -0700, Jared Harper wrote: > I have put together a patch that adds -executable, -readable, and > -writable to /usr/bin/find. While I agree with Solène that we don't necessarily want or need this patch, I think it is nicely done. I myself don't find the -perm prim