On Thu, 9 Mar 2023 at 06:50, joshua stein wrote:
> On Thu, 09 Mar 2023 at 06:41:50 +1100, Darren Tucker wrote:
> > This seems to be one too many parens? ie
> > if (negate = (attrib[0] == '!'))
>
> clang warns if there's not the extra set of parens in case it's an
> accidental = instead of ==
Right.
Developers will perform these tasks when they encounter it. Please do
not submit diffs of this kind.
>Thanks. I dislike trailing whitespace since it screws up code navigation,
>and I tend to remove it in code I'm working on since it distracts me.
>
>However, to be honest, sending diffs r
On Thu, 9 Mar 2023, Darren Tucker wrote:
> On Thu, 9 Mar 2023 at 02:09, joshua stein wrote:
> > cppcheck found these, are they worth fixing?
> >
> > In the non-fail case, done is set to NULL and then free()d.
> > free(NULL) is legal but maybe worth removing?
>
> ssh uses this pattern a lot, a
Thanks. I dislike trailing whitespace since it screws up code navigation,
and I tend to remove it in code I'm working on since it distracts me.
However, to be honest, sending diffs removing it is a waste of time.
Someone has to check the diff, apply it, compile it, write a message and
commit it. T
The installer deletes obsolete libLLVM.so versions during an upgrade.
However, a number of libLLVM.so versions have come and gone and the
installer hasn't been synced. We're now at .7.0, so delete all the
earlier ones.
ok?
---
remove obsolete libLLVM.s
On Thu, 09 Mar 2023 at 06:41:50 +1100, Darren Tucker wrote:
> > + if ((negate = (attrib[0] == '!')))
>
> This seems to be one too many parens? ie
> if (negate = (attrib[0] == '!'))
clang warns if there's not the extra set of parens in case it's an
accidental = instead of ==.
On Thu, 9 Mar 2023 at 02:09, joshua stein wrote:
> cppcheck found these, are they worth fixing?
>
> In the non-fail case, done is set to NULL and then free()d.
> free(NULL) is legal but maybe worth removing?
ssh uses this pattern a lot, and I agree with millert that it's not
worth changing.
char
On Wed, 08 Mar 2023 09:02:08 -0600, joshua stein wrote:
> In the non-fail case, done is set to NULL and then free()d.
> free(NULL) is legal but maybe worth removing?
Please leave this as-is. I don't think it is worth appeasing
cppcheck in this case.
> diff --git usr.bin/ssh/scp.c usr.bin/ssh/
friendly 12 week ping :)
On 2022/12/15 09:19:27 +0100, Omar Polo wrote:
> > > > On 2022/10/13 12:25:00 +0200, Omar Polo wrote:
> > > > > shell-command (M-!) and shell-command-on-region (M-|) works by
> > > > > displaying the output of the command in a new buffer, but in emacs
> > > > > using a p
Index: param.h
===
RCS file: /cvs/src/sys/sys/param.h,v
retrieving revision 1.140
diff -u -p -r1.140 param.h
--- param.h 4 Mar 2023 14:49:37 - 1.140
+++ param.h 8 Mar 2023 00:17:10 -
@@ -216,7 +216,7 @@
*/
#def
cppcheck found these, are they worth fixing?
In the non-fail case, done is set to NULL and then free()d.
free(NULL) is legal but maybe worth removing?
diff --git usr.bin/ssh/scp.c usr.bin/ssh/scp.c
index f0f09bba623..acb7bd8a8a1 100644
--- usr.bin/ssh/scp.c
+++ usr.bin/ssh/scp.c
@@ -935,19 +93
06.03.2023 14:13, Jonathan Gray пишет:
> Parts of bwfm already mention wep. Is it just a matter of needing to
> set IEEE80211_C_WEP or is more needed?
stsp quote from the initial 'Re: ifconfig: return non-zero on failed "nwkey"'
https://marc.info/?l=openbsd-tech&m=163587479013162&w=2 :
> But reg
06.03.2023 13:52, Mark Kettenis пишет:
> Maybe we should drop WEP support in the installer completely at some
> point. Your diff makes that easier, so no objection from me.
To push the alternatives and/or because there would be a significant
size reduction in install media?
I'm not familiar with
On Tue, Feb 28, 2023 at 01:11:14PM +0100, Claudio Jeker wrote:
> When I implemented RFC9234 support I was a bit to conservative and only
> enabled the loop detection if the capability was enabled. This is
> how every other capability works but RFC9234 is special.
> On top of this with the addition
14 matches
Mail list logo
