Re: npppd(8): remove "pipex" option

2023-01-30 Thread YASUOKA Masahiko
Hi, On Sun, 29 Jan 2023 14:35:05 +0300 Vitaliy Makkoveev wrote: > While switchind pppx(4) and pppac(4) from selwakeup() to KNOTE(9), I > found npppd(8) doesn't create pppx interface with "pipex no" in > npppd.conf, but successfully connects the client. So packets don't flow. > However, the pppac(

Re: Does openssl know about ROP?

2023-01-30 Thread Theo de Raadt
Seth David Schoen wrote: > It makes perfect sense to me that the tables in particular ought to go > back in .rodata (as they are, well, read-only data). I wouldn't think > that optimizations should be allowed to bypass code/data separation > policies. However that is the decision that was inten

Re: Double underlining and strikeout console patch

2023-01-30 Thread Crystal Kolipe
On Mon, Jan 30, 2023 at 09:15:51PM -0300, Crystal Kolipe wrote: > But just because the original goal is well within sight, I didn't see that > as a reason to stop. Just to clarify, I mean a reason to stop writing further code for evaluation. Not 'not a reason to stop', as in continue bloating the

Re: Does openssl know about ROP?

2023-01-30 Thread Seth David Schoen
Theo de Raadt writes: > Yes there are tools for that. google for "rop gadget scanner" and you'll > find the first few. > > But that isn't the right approach. > > If you find just one gadget, how do you react? You can't the constant table > to have different values. > > You move the table to ro

Re: Double underlining and strikeout console patch

2023-01-30 Thread Crystal Kolipe
On Mon, Jan 30, 2023 at 04:53:02PM -0700, Theo de Raadt wrote: > Whoosh, you missed the point. > > I've used xterm for decades and never used any of that. > > If those operations turn into "no-op" or perform the minimum rendering > change, it is still valid xterm escape processing. > > There is

Re: Double underlining and strikeout console patch

2023-01-30 Thread Theo de Raadt
Whoosh, you missed the point. I've used xterm for decades and never used any of that. If those operations turn into "no-op" or perform the minimum rendering change, it is still valid xterm escape processing. There is a difference betwen parsing an escape sequence, and performing a discrete & spe

Re: Double underlining and strikeout console patch

2023-01-30 Thread Crystal Kolipe
On Tue, Jan 31, 2023 at 12:03:53AM +0100, Christian Weisgerber wrote: > Crystal Kolipe: > > > Here is the latest version of the double underline and strikeout parts of my > > console patchset. > > I'm sorry, but I gotta ask: Who or what uses something like this?? It's useful on displays that lac

Re: Double underlining and strikeout console patch

2023-01-30 Thread Christian Weisgerber
Crystal Kolipe: > Here is the latest version of the double underline and strikeout parts of my > console patchset. I'm sorry, but I gotta ask: Who or what uses something like this?? Offhand, I don't even know if xterm can do it. If you want this kind of typographic detail, shouldn't you be usin

Re: Does openssl know about ROP?

2023-01-30 Thread Theo de Raadt
Seth David Schoen wrote: > Theo de Raadt writes: > > > This is a bit different than polymorphism (which is interpreting > > variable-sized instruction sequences at alternative offsets), but it is > > worse (data tables placed into code without giving a shit about the > > bytes in the data tables

Re: Does openssl know about ROP?

2023-01-30 Thread Seth David Schoen
Theo de Raadt writes: > This is a bit different than polymorphism (which is interpreting > variable-sized instruction sequences at alternative offsets), but it is > worse (data tables placed into code without giving a shit about the > bytes in the data tables having meaning as instructions) Is th

Re: Does openssl know about ROP?

2023-01-30 Thread Theo de Raadt
Steffen Nurpmeso wrote: e> Theo de Raadt wrote in > <53203.1675056...@cvs.openbsd.org>: > |I was reading some openssl source code, in particular the x86 assembly > |language files (which accelerate some crypto operations), and I find > |many cases where data tables are intentionally inserted

Re: Does openssl know about ROP?

2023-01-30 Thread Steffen Nurpmeso
Theo de Raadt wrote in <53203.1675056...@cvs.openbsd.org>: |I was reading some openssl source code, in particular the x86 assembly |language files (which accelerate some crypto operations), and I find |many cases where data tables are intentionally inserted into text (code) |segments, and thos

Re: vmd(8): fix serial console race leading to interrupt storm

2023-01-30 Thread Mike Larkin
On Mon, Jan 30, 2023 at 08:03:52PM +, Mike Larkin wrote: > On Mon, Jan 30, 2023 at 12:32:22PM -0500, Dave Voutila wrote: > > vmd's serial console has a race condition and can generate interrupt > > storms as the ns8250 device constantly asserts and deasserts its irq. > > > > Easiest way to see

Re: refactor mbuf parsing on driver level

2023-01-30 Thread Jan Klemkow
On Fri, Jan 27, 2023 at 04:44:36PM +0100, Christian Weisgerber wrote: > > The ether_extract_headers() diff was reverted, because is wrong for the > > cases other than tcp/udp/icmp. We need to fix it and recommit again > > before continue. > > I think (TCP or) UDP fragments are the problem. Fragme

Re: vmd(8): fix serial console race leading to interrupt storm

2023-01-30 Thread Mike Larkin
On Mon, Jan 30, 2023 at 12:32:22PM -0500, Dave Voutila wrote: > vmd's serial console has a race condition and can generate interrupt > storms as the ns8250 device constantly asserts and deasserts its irq. > > Easiest way to see this is on older, slower hardware OR running nested > such as OpenBSD

vmd(8): fix serial console race leading to interrupt storm

2023-01-30 Thread Dave Voutila
vmd's serial console has a race condition and can generate interrupt storms as the ns8250 device constantly asserts and deasserts its irq. Easiest way to see this is on older, slower hardware OR running nested such as OpenBSD guest inside OpenBSD vmm atop Linux KVM. I don't know enough about how c

update pixman to 0.42.2

2023-01-30 Thread james
? autom4te.cache Index: INSTALL === RCS file: /cvs/xenocara/lib/pixman/INSTALL,v retrieving revision 1.2 diff -u -p -u -p -r1.2 INSTALL --- INSTALL 3 Oct 2007 20:53:30 - 1.2 +++ INSTALL 30 Jan 2023 14:05:29 - @@ -

Re: Replace selwakeup() with KNOTE() in tun(4) and tap(4)

2023-01-30 Thread Vitaliy Makkoveev
> On 30 Jan 2023, at 06:39, Visa Hankala wrote: > > Replace selwakeup() with KNOTE() in tun(4) and tap(4). > > This patch makes the tun(4) and tap(4) event filters MP-safe. > > This is similar to the change that just got committed to pppac(4) > and pppx(4). However, tun(4) and tap(4) can be des

Re: bgpd adjust ext-community match code

2023-01-30 Thread Claudio Jeker
On Mon, Jan 30, 2023 at 05:37:25PM +0100, Theo Buehler wrote: > On Mon, Jan 30, 2023 at 03:29:49PM +0100, Claudio Jeker wrote: > > Extended communities are annoying, especially the ASnum encodings are a > > problem since the same extended community can be encoded in more than one > > way. This resu

Re: bgpd adjust ext-community match code

2023-01-30 Thread Theo Buehler
On Mon, Jan 30, 2023 at 03:29:49PM +0100, Claudio Jeker wrote: > Extended communities are annoying, especially the ASnum encodings are a > problem since the same extended community can be encoded in more than one > way. This results in strange behaviour when used with local-as and/or > neighbor-as.

Re: hardclock: don't call statclock(), stathz is always non-zero

2023-01-30 Thread Mark Kettenis
> Date: Sat, 21 Jan 2023 17:02:48 -0600 > From: Scott Cheloha > > All the platforms have switched to clockintr. > > Let's start by isolating statclock() from hardclock(). stathz is now > always non-zero: statclock() must be called separately. Update > several of the the stathz users to reflect

Re: Do not call (*pr_ctloutput)() after success sosplice()

2023-01-30 Thread Vitaliy Makkoveev
Guess, the "Push solock() down to sosetopt()" diff is better. On Sat, Jan 28, 2023 at 02:08:36PM +0300, Vitaliy Makkoveev wrote: > It will be null op in any cases. I want to do this, because it allows > to push solock() down to sosplice() and make future sblock()/solock() > dances easier with stan

bgpd adjust ext-community match code

2023-01-30 Thread Claudio Jeker
Extended communities are annoying, especially the ASnum encodings are a problem since the same extended community can be encoded in more than one way. This results in strange behaviour when used with local-as and/or neighbor-as. This diff changes the match function for any community with masks (ei

Push solock() down to sosetopt()

2023-01-30 Thread Vitaliy Makkoveev
It makes sense to push solock() down to sosetopt() too. For a half cases (*pr_ctloutput)() is just null op, so there is no reason to call it. Also, a lot of things could be done without solock() held. Index: sys/kern/uipc_socket.c ===

Double underlining and strikeout console patch

2023-01-30 Thread Crystal Kolipe
Here is the latest version of the double underline and strikeout parts of my console patchset. Previously, the double underline was always painted two pixels above the normal underline. This worked well for most font sizes, but to improve the visual effect with the smallest and largest fonts the

Intel Arc / DG2

2023-01-30 Thread Jonathan Gray
The current generation of Intel Arc branded graphics cards are part of what drm and Mesa refers to as DG2. https://ark.intel.com/content/www/us/en/ark/products/codename/226095/products-formerly-alchemist.html In -current we now have Mesa 22.3 which has support for DG2. There is support in inteldr

Nuke unused reference to removed isgray lookup table

2023-01-30 Thread Crystal Kolipe
We recently removed rasops_isgray, but this got left behind. Index: rasops.h === RCS file: /cvs/src/sys/dev/rasops/rasops.h,v retrieving revision 1.25 diff -u -p -r1.25 rasops.h --- rasops.h25 May 2020 09:55:49 - 1.25 +++

256 colour console patch

2023-01-30 Thread Crystal Kolipe
I've separated out the 256 colour code from the rest of my console enhancement patchset, because it seems that the bold and italic code was causing some problems that I haven't yet fully resolved. Also, various bits from the previous mega-patch are now in cvs, so it no longer applies cleanly. Ind

Re: bgpd: remove ASDOT support

2023-01-30 Thread Claudio Jeker
On Sun, Jan 29, 2023 at 02:02:08PM +, Job Snijders wrote: > ASDOT started out as sort of a joke, but unfortunately gained some > popularity in the 2010s with the rise of 4-byte ASNs and some people > thinking "cute, I can write my longish number in a shorter exotic > notation". > > Then, many