Re: [patch] italic text on the console!

2023-01-18 Thread Crystal Kolipe
The earlier version of this patch leaked memory if a font was locked multiple times. This version fixes the leak: Index: dev/rasops/rasops.c === RCS file: /cvs/src/sys/dev/rasops/rasops.c,v retrieving revision 1.69 diff -u -p -r1.69

Re: refactor mbuf parsing on driver level

2023-01-18 Thread Vitaliy Makkoveev
> On 19 Jan 2023, at 01:39, Jan Klemkow wrote: > > On Wed, Jan 18, 2023 at 10:50:25AM +0300, Vitaliy Makkoveev wrote: >> On Tue, Jan 17, 2023 at 11:09:17PM +0100, Jan Klemkow wrote: >>> we have several drivers which have to parse the content of mbufs. This >>> diff suggest a central parsing func

Re: refactor mbuf parsing on driver level

2023-01-18 Thread Theo de Raadt
Jan Klemkow wrote: > On Wed, Jan 18, 2023 at 10:50:25AM +0300, Vitaliy Makkoveev wrote: > > On Tue, Jan 17, 2023 at 11:09:17PM +0100, Jan Klemkow wrote: > > > we have several drivers which have to parse the content of mbufs. This > > > diff suggest a central parsing function for this. Thus, we

Re: refactor mbuf parsing on driver level

2023-01-18 Thread Jan Klemkow
On Wed, Jan 18, 2023 at 10:50:25AM +0300, Vitaliy Makkoveev wrote: > On Tue, Jan 17, 2023 at 11:09:17PM +0100, Jan Klemkow wrote: > > we have several drivers which have to parse the content of mbufs. This > > diff suggest a central parsing function for this. Thus, we can reduce > > redundant code

Re: ifconfig.c redundancy the second

2023-01-18 Thread Stefan Sperling
On Fri, Jan 13, 2023 at 09:18:30PM +0100, Mathias Koehler wrote: > Ehm well it should look like this, sorry: This code duplication has now been removed. Thanks! > === > RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v > retrieving revis

Re: libevent manuals

2023-01-18 Thread Ingo Schwarze
Hi Ted, Ted Bullock wrote on Mon, Jan 16, 2023 at 12:56:06PM -0700: > The impetus is that the event(3) manual page isn't all that good for > documenting how to use the library and it is missing functions that are > included in the API and available in the shared library. That seems true, and tho

Re: rpki-client: require version 4 UUIDs in RRDP session IDs

2023-01-18 Thread Claudio Jeker
On Wed, Jan 18, 2023 at 07:09:56PM +0100, Theo Buehler wrote: > On Wed, Jan 18, 2023 at 06:01:46PM +, Job Snijders wrote: > > All RRDP servers in the field now issue session IDs using the correct > > UUID version & type. > > Thanks for taking care of this. Indeed. > > OK? > > ok OK > >

Re: mem.4: be more accurate about securelevel

2023-01-18 Thread Theo de Raadt
But you should not start a sentence with also. Also you should not start a sentence with but. Not the best english. jmc can weight in perhaps. Jan Klemkow wrote: > On Tue, Jan 17, 2023 at 11:02:07PM +0100, Theo Buehler wrote: > > > at least this tool works for me: > > > > Surely you have kern

Re: mem.4: be more accurate about securelevel

2023-01-18 Thread Jan Klemkow
On Tue, Jan 17, 2023 at 11:02:07PM +0100, Theo Buehler wrote: > > at least this tool works for me: > > Surely you have kern.allowkmem=1 set. This diff should phrase it correctly. ok? Thanks, Jan Index: man4.alpha/mem.4 === RCS fil

Re: rpki-client: require version 4 UUIDs in RRDP session IDs

2023-01-18 Thread Theo Buehler
On Wed, Jan 18, 2023 at 06:01:46PM +, Job Snijders wrote: > All RRDP servers in the field now issue session IDs using the correct > UUID version & type. Thanks for taking care of this. > OK? ok > > Kind regards, > > Job > > Index: validate.c >

rpki-client: require version 4 UUIDs in RRDP session IDs

2023-01-18 Thread Job Snijders
All RRDP servers in the field now issue session IDs using the correct UUID version & type. OK? Kind regards, Job Index: validate.c === RCS file: /cvs/src/usr.sbin/rpki-client/validate.c,v retrieving revision 1.53 diff -u -p -r1.53

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Theo Buehler
> But those calls have either a break or continue, so either the loop is > exited or restarted (depending on PEERFLAG_EVALUATE_ALL). That's what I was missing. Not sure how. > So there should be no way to go from a rde_filterstate_clean(&state) to > prefix_adjout_update(new). > > There is a miss

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Claudio Jeker
On Wed, Jan 18, 2023 at 05:53:10PM +0100, Theo Buehler wrote: > On Wed, Jan 18, 2023 at 05:37:37PM +0100, Claudio Jeker wrote: > > On Wed, Jan 18, 2023 at 05:18:58PM +0100, Theo Buehler wrote: > > > On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > > > > This is the next step in vsta

italic text test program

2023-01-18 Thread Crystal Kolipe
Here is a trivial program to test the italic text patch I just sent to -tech: #include int main() { printf ("\n\x1b[mThis is normal text.\n"); printf ("\x1b[1mThis is bold text.\n"); printf ("\x1b[22;3mThis is italic text.\n"); printf ("\x1b[1mThis is bold and italic text.\n"); printf ("\x1b[mBa

[patch] italic text on the console!

2023-01-18 Thread Crystal Kolipe
Wouldn't it be nice if we could do italic text on the console? Well, now we can! I've separated out this diff from my main 'console enhancement' patchset for easier testing. This is against -current as of a few minutes ago, and adds just the following features: * Italic text. * Bold text using

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Theo Buehler
On Wed, Jan 18, 2023 at 05:37:37PM +0100, Claudio Jeker wrote: > On Wed, Jan 18, 2023 at 05:18:58PM +0100, Theo Buehler wrote: > > On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > > > This is the next step in vstate cleanup. > > > Since the vstate is now part of struct filterstate u

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Claudio Jeker
On Wed, Jan 18, 2023 at 05:18:58PM +0100, Theo Buehler wrote: > On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > > This is the next step in vstate cleanup. > > Since the vstate is now part of struct filterstate use that information > > instead of passing an explicit vstate to the va

Re: xonly on amd64: testing wanted

2023-01-18 Thread Theo de Raadt
Matthias Schmidt wrote: > I have the kernel patch running on my amd64 machine since you posted it > and noticed no regression so far. All my programs continue to work > (terminal stuff + FF, Chrome, Tor Browser). you mean your old binaries continue working. new ones, there are some problems.

Re: xonly on amd64: testing wanted

2023-01-18 Thread Matthias Schmidt
Hi, * Theo de Raadt wrote: > Some of you have probably noticed activity about "xonly" happening > to a bunch of architectures. First arm64, then riscv64, then hppa, > and ongoing efforts with octeon, sparc64 (sun4u only), and more of this > is going to come in the future. > > Like past work deca

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Theo Buehler
On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > This is the next step in vstate cleanup. > Since the vstate is now part of struct filterstate use that information > instead of passing an explicit vstate to the various update functions. It took me a moment to understand that rde_fi

Re: Preferred TERM for pkg_add

2023-01-18 Thread Stuart Henderson
Is there any benefit to pkg_add's TERM handling now that it no longers uses the full terminal width? To my eye the visual output looks the same with TERM=dumb (though presumably it will avoid the intermittent problem where somewhere between pkg_add, termcap and urxvt, pkg_add -u output jumps to th

bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Claudio Jeker
This is the next step in vstate cleanup. Since the vstate is now part of struct filterstate use that information instead of passing an explicit vstate to the various update functions. -- :wq Claudio Index: rde.c === RCS file: /cvs/s

Re: bgpd, small optimisation

2023-01-18 Thread Theo Buehler
On Wed, Jan 18, 2023 at 12:06:08PM +0100, Claudio Jeker wrote: > In the RDE the poll loop needs to know if any additional work is pending. > This is done calling various functions and if anyone has pending work the > timeout is reduced to 0. > > Now some of the functions will more often trigger th

bgpd, small optimisation

2023-01-18 Thread Claudio Jeker
In the RDE the poll loop needs to know if any additional work is pending. This is done calling various functions and if anyone has pending work the timeout is reduced to 0. Now some of the functions will more often trigger than others. So it is best to order them accordingly. Check for incoming an