Re: [patch(es)] fix a few typos in /src

2022-12-25 Thread Jason McIntyre
On Thu, Dec 22, 2022 at 10:49:06PM -0500, Paul Tagliamonte wrote: > > Updated patch attached with your feedback, thank you Crystal > hi. i'm rejecting these parts of this diff: Index: lib/libcurses/term.5 Index: lib/libcurses/tinfo/comp_hash.c Index: lib/libcurses/tty/hashmap.c Index: lib/libe

Re: [patch(es)] fix a few typos in /src

2022-12-25 Thread Jason McIntyre
On Thu, Dec 22, 2022 at 10:49:06PM -0500, Paul Tagliamonte wrote: hi. i've committed the parts of this diff relating to libssl. jmc > Index: lib/libssl/d1_both.c > === > Index: lib/libssl/ssl.h > =

Re: [patch(es)] fix a few typos in /src

2022-12-25 Thread Jason McIntyre
On Thu, Dec 22, 2022 at 10:49:06PM -0500, Paul Tagliamonte wrote: > > Updated patch attached with your feedback, thank you Crystal > hi. i know by now you have the message that diffs need to be manageable ;) i'll try and work through your changes as best i can. so this is a heads up that i com

Re: Machine after unhibernate *sometimes* won't suspend/hibernate again or dim screen

2022-12-25 Thread Abel Abraham Camarillo Ojeda
On Mon, Dec 26, 2022 at 12:08 AM Mike Larkin wrote: > On Sun, Dec 25, 2022 at 11:39:29PM -0600, Abel Abraham Camarillo Ojeda > wrote: > > On Sun, Dec 25, 2022 at 9:46 PM Mike Larkin wrote: > > > > > On Fri, Dec 23, 2022 at 03:13:53PM -0600, Abel Abraham Camarillo Ojeda > > > wrote: > > > > On Fr

Re: Machine after unhibernate *sometimes* won't suspend/hibernate again or dim screen

2022-12-25 Thread Mike Larkin
On Sun, Dec 25, 2022 at 11:39:29PM -0600, Abel Abraham Camarillo Ojeda wrote: > On Sun, Dec 25, 2022 at 9:46 PM Mike Larkin wrote: > > > On Fri, Dec 23, 2022 at 03:13:53PM -0600, Abel Abraham Camarillo Ojeda > > wrote: > > > On Fri, Dec 23, 2022 at 2:46 PM Abel Abraham Camarillo Ojeda < > > > aca

Re: Machine after unhibernate *sometimes* won't suspend/hibernate again or dim screen

2022-12-25 Thread Abel Abraham Camarillo Ojeda
# apmd -d battery status: high. external power status: not connected. estimated battery life 97% (223 minutes life time estimate) can't disable driver messages, error: Inappropriate ioctl for device apmevent index 0 (press zzz in another xterm) system suspending battery status: high. external

Re: Machine after unhibernate *sometimes* won't suspend/hibernate again or dim screen

2022-12-25 Thread Abel Abraham Camarillo Ojeda
On Sun, Dec 25, 2022 at 9:46 PM Mike Larkin wrote: > On Fri, Dec 23, 2022 at 03:13:53PM -0600, Abel Abraham Camarillo Ojeda > wrote: > > On Fri, Dec 23, 2022 at 2:46 PM Abel Abraham Camarillo Ojeda < > > acam...@verlet.org> wrote: > > > > > Forgot to mention I don't think this is a regression, ju

Re: hostctl: Change from fixed length to variable length

2022-12-25 Thread Masato Asou
I was rewrited the patch for hostctl command and sys/dev/pvbus. From: "Theo de Raadt" Date: Tue, 11 Oct 2022 19:09:42 -0600 > An example of this mechanism is SIOCGIFCONF. The ioctl passes a pointer > to a struct containing length & pointer to data. See net/if.c ifconf() > There are other simil

Re: Machine after unhibernate *sometimes* won't suspend/hibernate again or dim screen

2022-12-25 Thread Mike Larkin
On Fri, Dec 23, 2022 at 03:13:53PM -0600, Abel Abraham Camarillo Ojeda wrote: > On Fri, Dec 23, 2022 at 2:46 PM Abel Abraham Camarillo Ojeda < > acam...@verlet.org> wrote: > > > Forgot to mention I don't think this is a regression, just started to use > > hibernate/unhibernate more often lately. >

Re: ksh.1: Add a missing Ns

2022-12-25 Thread Jason McIntyre
On Sat, Dec 24, 2022 at 12:25:15PM -0500, Josiah Frentsos wrote: > Index: ksh.1 > === > RCS file: /cvs/src/bin/ksh/ksh.1,v > retrieving revision 1.217 > diff -u -p -r1.217 ksh.1 > --- ksh.1 13 Sep 2022 20:26:26 - 1.217 > +

Re: copystr(9) vs strlcpy

2022-12-25 Thread Crystal Kolipe
On Sun, Dec 25, 2022 at 08:07:11PM +, Miod Vallat wrote: > Indeed! So the third copystr() call could be replaced with this: > > Index: sys/kern/vfs_lookup.c > === > RCS file: /OpenBSD/src/sys/kern/vfs_lookup.c,v > retrieving revis

Re: copystr(9) vs strlcpy

2022-12-25 Thread Miod Vallat
> > In other words, > > copystr(src, dst, dstsiz, len) > > is equivalent to: > > if (strlcpy(dst, src, dstsiz) >= dstsiz) > > return ENAMETOOLONG; > > if (len != NULL) > > *len = strlen(dst); > > This should be *len = strlen(dst)+1 as copystr includes the termin

PMAP_PREFER dead code

2022-12-25 Thread Miod Vallat
With the introduction of the PMAP_PREFER_{ALIGN,OFFSET} macros a long time ago, there are actually no more uses of the PMAP_PREFER macro left in the kernel. The following diff removes PMAP_PREFER() but keeps a simple #define for it to let uvm knows the PMAP_PREFER_{ALIGN,OFFSET} macros are availab

Re: copystr(9) vs strlcpy

2022-12-25 Thread Crystal Kolipe
Hi Miod, On Sun, Dec 25, 2022 at 05:21:50PM +, Miod Vallat wrote: > In other words, > copystr(src, dst, dstsiz, len) > is equivalent to: > if (strlcpy(dst, src, dstsiz) >= dstsiz) > return ENAMETOOLONG; > if (len != NULL) > *len = strlen(dst); Thi

Re: em(4) multiqueue

2022-12-25 Thread Hrvoje Popovski
On 15.8.2022. 20:51, Hrvoje Popovski wrote: > On 12.8.2022. 22:15, Hrvoje Popovski wrote: >> Hi, >> >> I'm testing forwarding over >> >> em0 at pci7 dev 0 function 0 "Intel 82576" rev 0x01, msix, 4 queues, >> em1 at pci7 dev 0 function 1 "Intel 82576" rev 0x01, msix, 4 queues, >> em2 at pci8 dev 0

Re: copystr(9) vs strlcpy

2022-12-25 Thread Todd C . Miller
On Sun, 25 Dec 2022 17:21:50 +, Miod Vallat wrote: > Now, there are three uses of copystr() left in the kernel, and two of > them ignore the return value of copystr(), and do not need the length of > the result to be returned. > > These two can be trivially replaced with strlcpy() calls. Sure

copystr(9) vs strlcpy

2022-12-25 Thread Miod Vallat
Ho ho ho, copystr(9) is a very old and seldom used kernel function, which performs a bounded string copy and optionally returns the length of the copied string. In other words, copystr(src, dst, dstsiz, len) is equivalent to: if (strlcpy(dst, src, dstsiz) >= dstsiz)

only open /dev/vmm once in vmd(8)

2022-12-25 Thread Dave Voutila
During h2k22 there was some discussion around how vmd(8) manages vms and the vmm(4) device's role. While looking into something related, I found vmd opens /dev/vmm in each subprocess during the initial fork+execve dance. The only vmd process that needs /dev/vmm is the vmm process. The diff below

Re: Size reduction experiments for LLVM-built sparc64 kernel

2022-12-25 Thread Koakuma
Some weekend updates: 1. The clang-built kernels seem to be working well enough that I could complete building a (GCC-built) userland. 2. I tried a larger set of LLVM patches (D51206, D128263, D130006, D132465, D135515, D138532, D138741, D138887, D138922, D139535, and D140515) and while i

Add Apple heic/heif to magic(5) file

2022-12-25 Thread Stefan Hagen
Hi, I'd like to add the mime magic for the Apple heic/heif formats, which are used by Apple devices in recent years to store media. This format family can contain still images, short sequences (live photos) and videos. The rules are taken from FreeBSD. OK? Best Regards, Stefan Index: usr.bin/