patch: atfork unlock

2022-12-07 Thread Joel Knight
Hi. As first mentioned on misc[1], I've identified a deadlock in libc when a process forks, the children are multi-threaded, and they set one or more atfork callbacks. The diff below causes ATFORK_UNLOCK() to release the lock even when the process isn't multi-threaded. This avoids the deadlock. Wit

Re: pvbus: pass M_ZERO properly

2022-12-07 Thread Theo de Raadt
Yes YASUOKA Masahiko wrote: > This is obvious. M_ZERO must be for 3rd argument. > > ok? > > Index: sys/dev/pv/pvbus.c > === > RCS file: /cvs/src/sys/dev/pv/pvbus.c,v > retrieving revision 1.25 > diff -u -p -r1.25 pvbus.c > --- sy

Re: pvbus: pass M_ZERO properly

2022-12-07 Thread Masato Asou
ok asou@ From: YASUOKA Masahiko Date: Thu, 08 Dec 2022 11:35:33 +0900 (JST) > This is obvious. M_ZERO must be for 3rd argument. > > ok? > > Index: sys/dev/pv/pvbus.c > === > RCS file: /cvs/src/sys/dev/pv/pvbus.c,v > retrieving re

ksh, test: test -t file descriptor isn't optional

2022-12-07 Thread Lucas
Hi tech@, Both test.1 and ksh.1 (under the non-POSIX compatibility flag) state that `test -t` will default to test whether fd 1 is a TTY if the argument is omitted. This isn't the case, and both treat `-t` as the equivalent of `test -n -t`, ie, test if `-t` is a non-empty string, trivially true.

Re: Configure interface by lladdr during install

2022-12-07 Thread Andrew Hewus Fresh
On Wed, Dec 07, 2022 at 09:51:51AM -0800, Andrew Hewus Fresh wrote: > On Wed, Dec 07, 2022 at 10:28:05AM +, Stuart Henderson wrote: > > On 2022/12/06 19:57, Andrew Hewus Fresh wrote: > > > Which interface do you wish to configure? (name, lladdr, '?', or 'done') > > > [vio0] ? > > > Available n

Re: pvbus: pass M_ZERO properly

2022-12-07 Thread Vitaliy Makkoveev
ok mvs@ > On 8 Dec 2022, at 05:35, YASUOKA Masahiko wrote: > > This is obvious. M_ZERO must be for 3rd argument. > > ok? > > Index: sys/dev/pv/pvbus.c > === > RCS file: /cvs/src/sys/dev/pv/pvbus.c,v > retrieving revision 1.25 > d

Re: pvbus: pass M_ZERO properly

2022-12-07 Thread Mike Larkin
On Thu, Dec 08, 2022 at 11:35:33AM +0900, YASUOKA Masahiko wrote: > This is obvious. M_ZERO must be for 3rd argument. > > ok? > > Index: sys/dev/pv/pvbus.c > === > RCS file: /cvs/src/sys/dev/pv/pvbus.c,v > retrieving revision 1.25 >

pvbus: pass M_ZERO properly

2022-12-07 Thread YASUOKA Masahiko
This is obvious. M_ZERO must be for 3rd argument. ok? Index: sys/dev/pv/pvbus.c === RCS file: /cvs/src/sys/dev/pv/pvbus.c,v retrieving revision 1.25 diff -u -p -r1.25 pvbus.c --- sys/dev/pv/pvbus.c 25 Aug 2022 17:38:16 - 1

Re: Get rid of UVM_VNODE_CANPERSIST

2022-12-07 Thread Mark Kettenis
> Date: Wed, 7 Dec 2022 16:51:49 +0100 > From: Theo Buehler > > On Wed, Dec 07, 2022 at 03:56:56PM +0100, Alexander Bluhm wrote: > > On Mon, Nov 28, 2022 at 03:04:17PM +0100, Mark Kettenis wrote: > > > So here is an updated diff that checks the UVM_VNODE_DYING flag and > > > skips the refcount ma

agtimer(4/armv7): switch to clockintr

2022-12-07 Thread Scott Cheloha
ARMv7 has four interrupt clocks available. I think it'll be easier to review/test if we do the clockintr switch driver by driver instead of all at once in a massive single email. When all four driver patches are confirmed to work, I'll commit them. Here's a patch to switch agtimer(4/armv7) to cl

Re: Document 'uidinfo' structure locks

2022-12-07 Thread Vitaliy Makkoveev
> On 7 Dec 2022, at 18:10, Alexander Bluhm wrote: > > On Thu, Dec 01, 2022 at 09:50:47PM +0300, Vitaliy Makkoveev wrote: > > You could also document these globals with [I] in kern_proc.c > > LIST_HEAD(uihashhead, uidinfo) *uihashtbl; > u_long uihash; /* size of hash table - 1 */ > > O

Re: Configure interface by lladdr during install

2022-12-07 Thread Andrew Hewus Fresh
On Wed, Dec 07, 2022 at 10:28:05AM +, Stuart Henderson wrote: > On 2022/12/06 19:57, Andrew Hewus Fresh wrote: > > Which interface do you wish to configure? (name, lladdr, '?', or 'done') > > [vio0] ? > > Available network interfaces are: vio0 vlan0. > > vio0: lladdr fe:e1:bb:d1:dd:97 > > Whi

Re: match ATI unknown as amdgpu in fw_update(8)

2022-12-07 Thread Theo de Raadt
OK with me. Jonathan Gray wrote: > pci ids for newer amdgpu parts may not be known as all non-radeon ati > display ids are matched in newer versions of amdgpu. > > in dmesg unknown products take the form: > vga1 at pci12 dev 0 function 0 vendor "ATI", unknown product 0x687f rev 0xc3 > vendor "A

Re: Get rid of UVM_VNODE_CANPERSIST

2022-12-07 Thread Theo Buehler
On Wed, Dec 07, 2022 at 03:56:56PM +0100, Alexander Bluhm wrote: > On Mon, Nov 28, 2022 at 03:04:17PM +0100, Mark Kettenis wrote: > > So here is an updated diff that checks the UVM_VNODE_DYING flag and > > skips the refcount manipulation if it is set. > > My macppc has build a full release with it

Re: Get rid of UVM_VNODE_CANPERSIST

2022-12-07 Thread Theo de Raadt
> We should try and commit this. I don't want to do this as a snapshot diff. So yes, that feels like the right approach.

Re: Document 'uidinfo' structure locks

2022-12-07 Thread Alexander Bluhm
On Thu, Dec 01, 2022 at 09:50:47PM +0300, Vitaliy Makkoveev wrote: You could also document these globals with [I] in kern_proc.c LIST_HEAD(uihashhead, uidinfo) *uihashtbl; u_long uihash; /* size of hash table - 1 */ OK bluhm@ > Index: sys/sys/proc.h > ==

Re: Get rid of UVM_VNODE_CANPERSIST

2022-12-07 Thread Alexander Bluhm
On Mon, Nov 28, 2022 at 03:04:17PM +0100, Mark Kettenis wrote: > So here is an updated diff that checks the UVM_VNODE_DYING flag and > skips the refcount manipulation if it is set. My macppc has build a full release with it. So it seems to fix the issue. I will continue testing. I also made a p

Re: Configure interface by lladdr during install

2022-12-07 Thread Stuart Henderson
On 2022/12/06 19:57, Andrew Hewus Fresh wrote: > Which interface do you wish to configure? (name, lladdr, '?', or 'done') > [vio0] ? > Available network interfaces are: vio0 vlan0. > vio0: lladdr fe:e1:bb:d1:dd:97 > Which interface do you wish to configure? (name, lladdr, '?', or 'done') > [vio0