Re: riscv64 pmap: sync memory writes before remote sfence.vma

> From: Jeremie Courreges-Anglas > Date: Mon, 31 Oct 2022 22:44:01 +0100 > > > Here's the diff I've been using for the last bulk build on riscv64. It > resulted in a single kernel crash: > > cpu1: pool_do_get: pted free list modified: page 0xffc22cc0a000; item > addr > 0xffc22cc0a

Re: libX11 patch for X*IfEvent() API issues

Hello Matthieu, On Nov 01 2022, Matthieu Herrb wrote: > Hi, > > here's a libX11 patch that needs some wide testing, especially from > people who have experienced issues with various applications (fvwm[23] > from ports, Motif applications with Drag'n'Drop,..) with the upgrade > to libX11 1.8.1, be

Re: ber.c: Fix some minor issues in ober_read_element()

On Wed, 2022-11-02 at 18:34 +0100, Claudio Jeker wrote: > On Wed, Nov 02, 2022 at 05:56:21PM +0100, Martijn van Duren wrote: > > On Wed, 2022-11-02 at 17:47 +0100, Claudio Jeker wrote: > > > On Wed, Nov 02, 2022 at 05:25:12PM +0100, Martijn van Duren wrote: > > > > On Wed, 2022-11-02 at 17:00 +0100

Re: ber.c: Fix some minor issues in ober_read_element()

On Wed, Nov 02, 2022 at 05:56:21PM +0100, Martijn van Duren wrote: > On Wed, 2022-11-02 at 17:47 +0100, Claudio Jeker wrote: > > On Wed, Nov 02, 2022 at 05:25:12PM +0100, Martijn van Duren wrote: > > > On Wed, 2022-11-02 at 17:00 +0100, Claudio Jeker wrote: > > > > On Wed, Nov 02, 2022 at 07:33:14A

Re: ber.c: Fix some minor issues in ober_read_element()

On Wed, 2022-11-02 at 17:47 +0100, Claudio Jeker wrote: > On Wed, Nov 02, 2022 at 05:25:12PM +0100, Martijn van Duren wrote: > > On Wed, 2022-11-02 at 17:00 +0100, Claudio Jeker wrote: > > > On Wed, Nov 02, 2022 at 07:33:14AM +0100, Martijn van Duren wrote: > > > > I found 2 minor issues in the han

Re: ber.c: Fix some minor issues in ober_read_element()

On Wed, Nov 02, 2022 at 05:25:12PM +0100, Martijn van Duren wrote: > On Wed, 2022-11-02 at 17:00 +0100, Claudio Jeker wrote: > > On Wed, Nov 02, 2022 at 07:33:14AM +0100, Martijn van Duren wrote: > > > I found 2 minor issues in the handling of sequences/sets in > > > ober_read_element(): > > > 1) A

Re: rpki-client unify http logging a bit

On Wed, Nov 02, 2022 at 04:38:00PM +0100, Claudio Jeker wrote: > Based on Job's work lets introduce conn_info() which prints the URI / > host plus the IP address. This may be helpful to better understand errors. > > With this ip_info() becomes much simpler. I also decided to not check > snprintf r

Re: ber.c: Fix some minor issues in ober_read_element()

On Wed, 2022-11-02 at 17:00 +0100, Claudio Jeker wrote: > On Wed, Nov 02, 2022 at 07:33:14AM +0100, Martijn van Duren wrote: > > I found 2 minor issues in the handling of sequences/sets in > > ober_read_element(): > > 1) An empty sequence/set (which is basically always) unconditionally > >creat

Re: ber.c: Fix some minor issues in ober_read_element()

On Wed, Nov 02, 2022 at 07:33:14AM +0100, Martijn van Duren wrote: > I found 2 minor issues in the handling of sequences/sets in > ober_read_element(): > 1) An empty sequence/set (which is basically always) unconditionally >creates an (uninitialised) sub-element. Add the same length check >

rpki-client unify http logging a bit

Based on Job's work lets introduce conn_info() which prints the URI / host plus the IP address. This may be helpful to better understand errors. With this ip_info() becomes much simpler. I also decided to not check snprintf returns because the buffer is big enough and afaik encoding errors can't h

Fix kernel build without IPSEC option

Hi, if you build the kernel without IPSEC it will run into several compiler and linker errors. This diff add some missing #ifdefs to fix this. ok? bye, jan Index: net/if_pfsync.c === RCS file: /mount/openbsd/cvs/src/sys/net/if_pfs

Re: rpki-client keep http connection info around

On Wed, Nov 02, 2022 at 11:55:12AM +0100, Claudio Jeker wrote: > Job's diff made me realise that clearing the connection info (conn->res) > makes error reporting worse. It is not like we save lots of memory by > doing so. So do not call freeaddrinfo() in http_connect_done(), now > http_free() will

rpki-client keep http connection info around

Job's diff made me realise that clearing the connection info (conn->res) makes error reporting worse. It is not like we save lots of memory by doing so. So do not call freeaddrinfo() in http_connect_done(), now http_free() will free res0 before freeing conn. -- :wq Claudio Index: http.c

Re: rpki-client: missing length check in valid_uri()

On Wed, Nov 02, 2022 at 11:45:43AM +0100, Theo Buehler wrote: > Not all callers of valid_uri() ensure that the uri passed in is actually > a C string and the API implies at least that uri[usz - 1] != '\0' is > allowed. For example, x509_location() a priori doesn't pass a C string > and Job will soo

rpki-client: missing length check in valid_uri()

Not all callers of valid_uri() ensure that the uri passed in is actually a C string and the API implies at least that uri[usz - 1] != '\0' is allowed. For example, x509_location() a priori doesn't pass a C string and Job will soon add a second instance. I think we should explicitly length check uri

Re: Remove audio(9) speaker_ctl(), let open() handle speakers where needed

On Sun, Oct 30, 2022 at 11:02:39AM +, Klemens Nanni wrote: > Only five legacy half-duplex hardware drivers require this function to > change between playing and recording: > i386: ess(4), gus(4), pas(4), sb(4) > luna88k: nec86(4) > > If defined, it is always called early in audio_o

Re: rpki-client: fix x509_get_time() error checks

On Wed, Nov 02, 2022 at 10:38:57AM +0100, Theo Buehler wrote: > Like most x509_* functions, x509_get_time() returns 0 on error and 1 on > success, so rather than changing x509_get_time(), I changed the callers. OK claudio@ > Index: aspa.c > ===

rpki-client: fix x509_get_time() error checks

Like most x509_* functions, x509_get_time() returns 0 on error and 1 on success, so rather than changing x509_get_time(), I changed the callers. Index: aspa.c === RCS file: /cvs/src/usr.sbin/rpki-client/aspa.c,v retrieving revision 1.