Fix description in OPENBSD-PF-MIB

2022-10-18 Thread Martijn van Duren
As pointed out by Alec on misc@, there's a discrepancy between the name and description of several objects inside the pfIfTable. Looks like a simple copy-paste error. OK? martijn@ Index: OPENBSD-PF-MIB.txt === RCS file: /cvs/src/sh

Re: sys: use C99 struct init for struct audio_hw_if

2022-10-18 Thread Alexandre Ratchov
On Tue, Oct 18, 2022 at 08:02:34PM +, Klemens Nanni wrote: > > Here's the actual complete diff that was tested as per above, > the previous did not include a bunch of files. > > I can also send/commit this in smaller per driver/arch/whatever chunks > if that's preferred. Your call ;-) ok ra

Re: sys: use C99 struct init for struct audio_hw_if

2022-10-18 Thread Klemens Nanni
On Tue, Oct 18, 2022 at 02:17:54PM +, Klemens Nanni wrote: > audio(9) cleanup demands removing a member from this struct, which is > cumbersome in our current tree as drivers initialise it inconsistently, > i.e. a simple removal of ".member_name = driver_func," is not always > possible. > > Mo

Re: sys: use C99 struct init for struct audio_hw_if

2022-10-18 Thread Alexandre Ratchov
On Tue, Oct 18, 2022 at 02:17:54PM +, Klemens Nanni wrote: > audio(9) cleanup demands removing a member from this struct, which is > cumbersome in our current tree as drivers initialise it inconsistently, > i.e. a simple removal of ".member_name = driver_func," is not always > possible. > > Mo

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-10-18 Thread Hrvoje Popovski
On 15.10.2022. 22:01, Moritz Buhl wrote: > With the previous diffs I am seeing sporadic connection problems in tcpbench > via IPv6 on Intel 82546GB. > The diff was too big anyways. Here is a smaller diff that introduces > checksum offloading for the controllers that use the advanced descriptors. >

arm64: aplmca: constify _hw_if struct

2022-10-18 Thread Klemens Nanni
The only driver with a non-const struct. Seen while looking at it for audio(9). OK? diff --git a/sys/arch/arm64/dev/aplmca.c b/sys/arch/arm64/dev/aplmca.c index 07a53103be4..03ade86fee7 100644 --- a/sys/arch/arm64/dev/aplmca.c +++ b/sys/arch/arm64/dev/aplmca.c @@ -135,7 +135,7 @@ int aplmca_trigg

dev/isa: ess, pas: constify string table

2022-10-18 Thread Klemens Nanni
Each only used once for a printf() call in *_attach(). Seen while tweaking their *_hw_if struct. OK? Index: dev/isa/ess.c === RCS file: /cvs/src/sys/dev/isa/ess.c,v retrieving revision 1.28 diff -u -p -r1.28 ess.c --- dev/isa/ess.c

sys: use C99 struct init for struct audio_hw_if

2022-10-18 Thread Klemens Nanni
audio(9) cleanup demands removing a member from this struct, which is cumbersome in our current tree as drivers initialise it inconsistently, i.e. a simple removal of ".member_name = driver_func," is not always possible. Most drivers call their driver_*() functions like the member name, - some var

Re: fix use after free in proxy_parse_uri()

2022-10-18 Thread Theo Buehler
On Tue, Oct 18, 2022 at 03:25:36PM +0200, Claudio Jeker wrote: > With rev 1.65 proxy_parse_uri() can assign a pointer to proxyport > that is part of fullhost and so points to freed memory (once that function > returns). The fix is to copy the port as well. > > This should be a fix for > https://gi

fix use after free in proxy_parse_uri()

2022-10-18 Thread Claudio Jeker
With rev 1.65 proxy_parse_uri() can assign a pointer to proxyport that is part of fullhost and so points to freed memory (once that function returns). The fix is to copy the port as well. This should be a fix for https://github.com/rpki-client/rpki-client-portable/issues/74 -- :wq Claudio Index:

Re: smtpd bug in Received: header with one recipient

2022-10-18 Thread Chris Waddey
Ping. On Sun, Oct 09, 2022 at 08:01:01AM +0200, Martijn van Duren wrote: > Bit focused on other things atm and not familiar with this part of the > code, but some comments. > > On Sat, 2022-10-08 at 12:18 -0600, Chris Waddey wrote: >> A message with a single successful recipient but with a faile

Re: bgpctl show metric up/down time

2022-10-18 Thread Theo Buehler
On Tue, Oct 18, 2022 at 01:08:55PM +0200, Claudio Jeker wrote: > As mentioned I think having metric values that depend on session state is > not ideal. Introduce 'bgpd_peer_last_change_seconds' which is the last > time the session up/down state changed. It does not track every state > change only w

Re: initialize peer last_updown when peer is created

2022-10-18 Thread Theo Buehler
On Tue, Oct 18, 2022 at 01:13:27PM +0200, Claudio Jeker wrote: > Currently the last_updown stat is not initalized and 0 when a peer is > initially added. If the peer is passive or is unable to establish a > connection last_updown remains 0 which is not ideal. > > Initalize the last_updown timestam

initialize peer last_updown when peer is created

2022-10-18 Thread Claudio Jeker
Currently the last_updown stat is not initalized and 0 when a peer is initially added. If the peer is passive or is unable to establish a connection last_updown remains 0 which is not ideal. Initalize the last_updown timestamp in init_peer() which is called when a new peer is added or cloned. With

bgpctl show metric up/down time

2022-10-18 Thread Claudio Jeker
As mentioned I think having metric values that depend on session state is not ideal. Introduce 'bgpd_peer_last_change_seconds' which is the last time the session up/down state changed. It does not track every state change only when a session goes in and out of ESTABLISHED state. This replaces bgpd_

Re: audio: remove unused AUDIO_PROP_{MMAP,INDEPENDENT}

2022-10-18 Thread Klemens Nanni
On Tue, Oct 18, 2022 at 09:32:27AM +0200, Alexandre Ratchov wrote: > On Mon, Oct 17, 2022 at 07:45:33PM +, Klemens Nanni wrote: > > I was looking at one particular driver and needed to know what those > > flags are, turns out AUDIO_PROP_FULLDUPLEX is the only audio(9) property > > that is in us

Re: audio: remove unused AUDIO_PROP_{MMAP,INDEPENDENT}

2022-10-18 Thread Alexandre Ratchov
On Mon, Oct 17, 2022 at 07:45:33PM +, Klemens Nanni wrote: > I was looking at one particular driver and needed to know what those > flags are, turns out AUDIO_PROP_FULLDUPLEX is the only audio(9) property > that is in use. Even AUDIO_PROP_FULLDUPLEX (and the associated get_props() and setfd()