Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-10 Thread Mikolaj Kucharski
On Mon, Oct 10, 2022 at 11:17:32AM -0600, Theo de Raadt wrote: > It's been explained a few times that being up-to-date is not an error. > It's a good thing, and no action is neccessary when up-to-date. No action when up-to-date is not the same as action when not up-to-date, when you use -n and add

ksh: errexit executes ERR trap twice

2022-10-10 Thread Klemens Nanni
The ERR trap is supposed to be run once, regardless of errexit: $ ksh -c 'trap "echo ERR" ERR; false' ERR $ ksh -c 'trap "echo ERR" ERR; false' -e ERR ERR This duplication is a regression of the following bin/ksh/main.c commit: revision 1.52

Remove some useless uses of cat

2022-10-10 Thread Josiah Frentsos
Index: distrib/alpha/iso/Makefile === RCS file: /cvs/src/distrib/alpha/iso/Makefile,v retrieving revision 1.20 diff -u -p -r1.20 Makefile --- distrib/alpha/iso/Makefile 1 May 2019 20:53:34 - 1.20 +++ distrib/alpha/iso/Makefi

Re: EFI runtime services support on amd64

2022-10-10 Thread Dave Voutila
Mark Kettenis writes: > Here is a diff that implements EFI runtime services support on amd64 > in much the same way as we already do on arm64. This will be used in > the future to implement support for EFI variables. > > Some initial testing among OpenBSD developers did not uncover any > issue

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-10 Thread Theo de Raadt
It's been explained a few times that being up-to-date is not an error. It's a good thing, and no action is neccessary when up-to-date. Any non-zero value indicates an error, that would include 2. You are marking this as an error, when it isn't. You think this will help your scripting. Do you no

Re: Fix level-triggered ACPI GPIO interrupts on amd64

2022-10-10 Thread Matthias Schmidt
* Matthias Schmidt wrote: > Hi Mark, > > Addendum after 24h of testing. Your patch fixes the frequent touchpad > freezes I see on this model and which I reported back then in > https://marc.info/?l=openbsd-bugs&m=165328803822857&w=2 Any chance that this patch gets committed or wider testing in s

Re: pf.conf / scrub resulting in invalid checksum

2022-10-10 Thread Alexander Bluhm
> /* Enforce a minimum ttl, may cause endless packet loops */ > - if (min_ttl && af == AF_INET && h->ip_ttl < min_ttl) > + if (min_ttl && af == AF_INET && h->ip_ttl < min_ttl) { > + old = h->ip_ttl; > h->ip_ttl = min_ttl; > + pf_cksum_fixup(&h->ip

Re: ksh: trigger ERR trap on permanent I/O redirection failure

2022-10-10 Thread Klemens Nanni
On Sat, Oct 08, 2022 at 11:22:59AM -0600, Todd C. Miller wrote: > On Sat, 08 Oct 2022 16:01:18 -, Klemens Nanni wrote: > > > Account for this to make permanent redirection failure trigger the ERR > > trap: > > > > $ ./obj/ksh -c 'trap "echo ERR" ERR ; exec >/' > > ksh: cannot create /:

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-10 Thread Mikolaj Kucharski
On Fri, Oct 07, 2022 at 02:39:01PM -0400, Josh Grosse wrote: > For ease of running sysupgrade from within a script. > > diff --git a/usr.sbin/sysupgrade/sysupgrade.sh > b/usr.sbin/sysupgrade/sysupgrade.sh > index d80ff127ffa..ce5800093c9 100644 > --- a/usr.sbin/sysupgrade/sysupgrade.sh > +++ b/u