Re: make kernel build without INET6 again (pf_lb.c)

2022-08-30 Thread Alexandr Nedvedicky
surre, looks good to me. OK sashan On Tue, Aug 30, 2022 at 09:45:17PM +0200, Sebastian Benoit wrote: > ok? > > diff --git sys/net/pf_lb.c sys/net/pf_lb.c > index 588115cbff7..905af42e463 100644 > --- sys/net/pf_lb.c > +++ sys/net/pf_lb.c > @@ -519,13 +519,18 @@ pf_map_addr(sa_family_t af, struct

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Todd C . Miller
On Wed, 31 Aug 2022 00:19:20 +0200, Moritz Buhl wrote: > On Tue, Aug 30, 2022 at 10:59:43PM +0200, Claudio Jeker wrote: > > And nsd in base. It seems unbound does not use recvmmsg. > > After 'make -f Makefile.bsd-wrapper config' recvmmsg is picked up. > The config compile test currently defines N

Re: Boot failures on Raspberry Pi CM4 (arm64)

2022-08-30 Thread Ian R.
Oops, I noticed a somewhat significant typo in the long message I just sent. On step "4b.)" I listed the wrong EEPROM date. That line was supposed to say: On the *2nd and 3rd* CM4s (running the newer *2021-12-02* EEPROM/bootloader that they shipped with, On 8/30/22 15:06, Ian R. wrote: 4b.)

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Moritz Buhl
On Tue, Aug 30, 2022 at 10:59:43PM +0200, Claudio Jeker wrote: > And nsd in base. It seems unbound does not use recvmmsg. After 'make -f Makefile.bsd-wrapper config' recvmmsg is picked up. The config compile test currently defines NONBLOCKING_IS_BROKEN because of a missing include. Then vlen for

Boot failures on Raspberry Pi CM4 (arm64)

2022-08-30 Thread Ian R.
Hello, I've been trying (with limited success) to get OpenBSD 7.1 installed on some Raspberry Pi Compute Module 4 (a.k.a. 'CM4') boards' internal flash storage. I'm wondering if anyone else on this list might have tested these devices with OpenBSD? Please let me know if there's a more approp

Re: bgpd: only run one roa softreconfig process at a time

2022-08-30 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.08.30 22:54:43 +0200: > Currently if bgpd takes a long time to re-evaluate all prefixes because of > a ROA change a second update can come in before the first is processed. > This is not good. So add a barrier to only run one rde_roa_softreconfig

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Claudio Jeker
On Tue, Aug 30, 2022 at 09:51:46PM +0100, Stuart Henderson wrote: > btw a few ports will likely pick this up: > > paths/devel/glib2.log:Checking for function "recvmmsg" : NO > paths/net/tinc.log:checking for recvmmsg... no > paths/net/knot.log:checking for recvmmsg... no > paths/net/knot.log:U

bgpd: only run one roa softreconfig process at a time

2022-08-30 Thread Claudio Jeker
Currently if bgpd takes a long time to re-evaluate all prefixes because of a ROA change a second update can come in before the first is processed. This is not good. So add a barrier to only run one rde_roa_softreconfig dump at a time. If a dump is pending while a new roa set is received ignore tha

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Stuart Henderson
btw a few ports will likely pick this up: paths/devel/glib2.log:Checking for function "recvmmsg" : NO paths/net/tinc.log:checking for recvmmsg... no paths/net/knot.log:checking for recvmmsg... no paths/net/knot.log:Use recvmmsg: no paths/net/gdnsd.log:checking whether recvmmsg is dec

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Moritz Buhl
Hi tech@, the following diff only contains recvmmsg which should be the more useful syscall of the two. I implemented some minor feedback regarding the man page and attaching an error from recvit to the socket in case some messages were received before. I am also looking into passing the timeout

make kernel build without INET6 again (pf_lb.c)

2022-08-30 Thread Sebastian Benoit
ok? diff --git sys/net/pf_lb.c sys/net/pf_lb.c index 588115cbff7..905af42e463 100644 --- sys/net/pf_lb.c +++ sys/net/pf_lb.c @@ -519,13 +519,18 @@ pf_map_addr(sa_family_t af, struct pf_rule *r, struct pf_addr *saddr, * fall back to POOL_NONE if there is a single host

Re: delete unused variable in ix(4) rx checksum calc

2022-08-30 Thread Moritz Buhl
ok mbuhl On Tue, Aug 30, 2022 at 05:13:35PM +0200, Sebastian Benoit wrote: > ptype is never used. > ok? > > diff --git sys/dev/pci/if_ix.c sys/dev/pci/if_ix.c > index cb233034d23..72a221b97d9 100644 > --- sys/dev/pci/if_ix.c > +++ sys/dev/pci/if_ix.c > @@ -148,7 +148,7 @@ void ixgbe_enable_i

Re: bgpd move nexthops to RB tree

2022-08-30 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.08.30 19:11:15 +0200: > I'm on a mission to remove the hash tables :) > > This one is for struct nexthop. Hopefully it makes nexthop_get a bit > better. ok, but one __func__ below > > -- > :wq Claudio > > Index: rde.c > =

Re: pipex syzkaller keylen

2022-08-30 Thread YASUOKA Masahiko
Hi, Tested. ok yasuoka On Tue, 30 Aug 2022 15:41:29 +0200 Alexander Bluhm wrote: > Hi, > > I looks like syzkaller has found a missing input validation in pipex. > > https://syzkaller.appspot.com/bug?id=c7ac769bd7ee15549b8a2be188bcee07d98a5357 > > As I have no pipex setup, can anyone test thi

update: X server 21.1.4

2022-08-30 Thread Matthieu Herrb
Hi, The patch below brings the X server in xenocara in sync with X.Org 21.1.4. The security related bits of this release were commited for the last xserver errata, but there are a few other bug fixes in this release. In particular it should fix the crash reported on bugs@ by Walter Alejandro Igles

bgpd move nexthops to RB tree

2022-08-30 Thread Claudio Jeker
I'm on a mission to remove the hash tables :) This one is for struct nexthop. Hopefully it makes nexthop_get a bit better. -- :wq Claudio Index: rde.c === RCS file: /cvs/src/usr.sbin/bgpd/rde.c,v retrieving revision 1.569 diff -u -

Re: all architectures: put clockframe definition in frame.h?

2022-08-30 Thread Miod Vallat
> So we would get rid of all the 32-bit compat stuff from arch/sparc64? Yes, but this has never been used, so no worries about it. > Index: include/cpu.h > === > RCS file: /cvs/src/sys/arch/sparc64/include/cpu.h,v > retrieving revisi

delete unused variable in ix(4) rx checksum calc

2022-08-30 Thread Sebastian Benoit
ptype is never used. ok? diff --git sys/dev/pci/if_ix.c sys/dev/pci/if_ix.c index cb233034d23..72a221b97d9 100644 --- sys/dev/pci/if_ix.c +++ sys/dev/pci/if_ix.c @@ -148,7 +148,7 @@ voidixgbe_enable_intr(struct ix_softc *); void ixgbe_disable_intr(struct ix_softc *); intixgbe_txeof

Re: snmpd(8): Allow registering above subtree allocated region

2022-08-30 Thread Theo Buehler
On Tue, Aug 30, 2022 at 04:47:30PM +0200, Martijn van Duren wrote: > So right now we disallow allocation of a region if a sub-region has the > subtree flag set. This logic is inverted compared to it's intention, > which is that if you allocate a region with subtree it should check that > the entire

snmpd(8): Fix searchrange end length in agentx

2022-08-30 Thread Martijn van Duren
I think this one speaks for itself. OK? martijn@ ? obj Index: application_agentx.c === RCS file: /cvs/src/usr.sbin/snmpd/application_agentx.c,v retrieving revision 1.2 diff -u -p -r1.2 application_agentx.c --- application_agentx.c

snmpd(8): Allow registering above subtree allocated region

2022-08-30 Thread Martijn van Duren
So right now we disallow allocation of a region if a sub-region has the subtree flag set. This logic is inverted compared to it's intention, which is that if you allocate a region with subtree it should check that the entire region below it is available (application.c:242 should say "subtree" inste

snmpd(8): Better determining searchrange end

2022-08-30 Thread Martijn van Duren
Doing overlapping regions is hard... At application.c:1341 we currently assign region->ar_oid to oid. However, with overlapping regions this can cause a recursion, because region might be the parent of the previous region that would cause the oid to traverse back and cause a loop. This can easily

Re: i386/lapic.c: sync with amd64/lapic.c

2022-08-30 Thread Mike Larkin
On Sun, Aug 28, 2022 at 03:26:49PM -0500, Scott Cheloha wrote: > As promised off-list: in anticipation of merging the clock interrupt > code, let's sync up the lapic timer parts of i386/lapic.c with the > corresponding parts in amd64/lapic.c. They will need identical > changes to use the new code,

Re: pipex syzkaller keylen

2022-08-30 Thread Vitaliy Makkoveev
On Tue, Aug 30, 2022 at 03:41:29PM +0200, Alexander Bluhm wrote: > Hi, > > I looks like syzkaller has found a missing input validation in pipex. > > https://syzkaller.appspot.com/bug?id=c7ac769bd7ee15549b8a2be188bcee07d98a5357 > > As I have no pipex setup, can anyone test this diff please? > o

Re: update fontconfig to version 2.14.0

2022-08-30 Thread Matthieu Herrb
On Mon, Aug 15, 2022 at 11:12:20AM +0200, Matthieu Herrb wrote: > Hi, > > the patch below updates fontconfig to version 2.14.0. > > It contains bug fixes but also a few changes in the default config > files. So the way you favourite application displays them may change > (again). > > There are n

pipex syzkaller keylen

2022-08-30 Thread Alexander Bluhm
Hi, I looks like syzkaller has found a missing input validation in pipex. https://syzkaller.appspot.com/bug?id=c7ac769bd7ee15549b8a2be188bcee07d98a5357 As I have no pipex setup, can anyone test this diff please? bluhm Index: net/pipex.c =

Re: diff: b64decode(1) for long line

2022-08-30 Thread Claudio Jeker
On Tue, Aug 30, 2022 at 02:19:29PM +0200, Theo Buehler wrote: > > Ah, I showed the diff separated from first one. > > I'm sorry for confusing. The following diff is combined. > > Oh, I see. > > ok tb (feel free to land the diffs separately if you prefer). Also OK claudio -- :wq Claudio

Re: diff: b64decode(1) for long line

2022-08-30 Thread Theo Buehler
> Ah, I showed the diff separated from first one. > I'm sorry for confusing. The following diff is combined. Oh, I see. ok tb (feel free to land the diffs separately if you prefer).

Re: diff: b64decode(1) for long line

2022-08-30 Thread YASUOKA Masahiko
On Tue, 30 Aug 2022 14:09:40 +0200 Theo Buehler wrote: > On Tue, Aug 30, 2022 at 01:01:47PM +0200, YASUOKA Masahiko wrote: >> On Tue, 30 Aug 2022 11:56:53 +0200 >> Claudio Jeker wrote: >> > On Tue, Aug 30, 2022 at 11:18:01AM +0200, YASUOKA Masahiko wrote: >> >> @@ -423,11 +423,13 @@ uu_decode(voi

Re: rpki-client rrdp cleanup race

2022-08-30 Thread Theo Buehler
On Tue, Aug 30, 2022 at 12:06:35PM +0200, Claudio Jeker wrote: > Once rpki-client finished validating everything rpki moves valid files > into the validated cache. For RRDP invalid files currently in the valid > cache are moved back into the corresponding .rrdp directory. The problem > here is that

Re: diff: b64decode(1) for long line

2022-08-30 Thread Theo Buehler
On Tue, Aug 30, 2022 at 01:01:47PM +0200, YASUOKA Masahiko wrote: > On Tue, 30 Aug 2022 11:56:53 +0200 > Claudio Jeker wrote: > > On Tue, Aug 30, 2022 at 11:18:01AM +0200, YASUOKA Masahiko wrote: > >> @@ -423,11 +423,13 @@ uu_decode(void) > >>} > >> } > >> > >> +#define ROUNDDOWN(x,y) ((

Re: struct ifnet: remove unused if_switchport member

2022-08-30 Thread Klemens Nanni
On Fri, Aug 26, 2022 at 05:40:00PM +, Klemens Nanni wrote: > Full ports diff for completeness. Done with $ infrastructure/bin/portbump -r \ devel/libgtop2 \ games/warzone2100 \ mail/mozilla-thunderbird \ multimedia/gstrea

Re: diff: b64decode(1) for long line

2022-08-30 Thread YASUOKA Masahiko
On Tue, 30 Aug 2022 11:56:53 +0200 Claudio Jeker wrote: > On Tue, Aug 30, 2022 at 11:18:01AM +0200, YASUOKA Masahiko wrote: >> @@ -423,11 +423,13 @@ uu_decode(void) >> } >> } >> >> +#define ROUNDDOWN(x,y) (((x)/(y)) * (y)) >> + >> static int >> base64_decode(void) >> { >> int

rpki-client rrdp cleanup race

2022-08-30 Thread Claudio Jeker
Once rpki-client finished validating everything rpki moves valid files into the validated cache. For RRDP invalid files currently in the valid cache are moved back into the corresponding .rrdp directory. The problem here is that in the .rrdp a same file exists we override the newer invalid file wit

Re: diff: b64decode(1) for long line

2022-08-30 Thread Claudio Jeker
On Tue, Aug 30, 2022 at 11:18:01AM +0200, YASUOKA Masahiko wrote: > b64decode(8) fails if a long line is given. > > % wc test > 1 11370 test > % > % ./b64decode -r test > /dev/null > b64decode: test: /dev/stdout: error decoding base64 input stream > % > > uudecode.c > >

Re: pdaemon locking tweak

2022-08-30 Thread Jonathan Gray
On Tue, Aug 30, 2022 at 10:40:23AM +0200, Martin Pieuchot wrote: > On 30/08/22(Tue) 15:28, Jonathan Gray wrote: > > On Mon, Aug 29, 2022 at 01:46:20PM +0200, Martin Pieuchot wrote: > > > Diff below refactors the pdaemon's locking by introducing a new *trylock() > > > function for a given page. Thi

Re: diff: b64decode(1) for long line

2022-08-30 Thread Theo Buehler
> The diff fixes this by giving a string to b64_pton() which length is > multiple of 4. ok tb

diff: b64decode(1) for long line

2022-08-30 Thread YASUOKA Masahiko
b64decode(8) fails if a long line is given. % wc test 1 11370 test % % ./b64decode -r test > /dev/null b64decode: test: /dev/stdout: error decoding base64 input stream % uudecode.c 426 static int 427 base64_decode(void) 428 { 429 int n; 430

Re: pdaemon locking tweak

2022-08-30 Thread Martin Pieuchot
On 30/08/22(Tue) 15:28, Jonathan Gray wrote: > On Mon, Aug 29, 2022 at 01:46:20PM +0200, Martin Pieuchot wrote: > > Diff below refactors the pdaemon's locking by introducing a new *trylock() > > function for a given page. This is shamelessly stolen from NetBSD. > > > > This is part of my ongoing

Re: stub out initial mmio support for vmm(4)/vmd(8)

2022-08-30 Thread Mike Larkin
(see below) On Mon, Aug 15, 2022 at 03:06:05PM -0400, Dave Voutila wrote: > > Mike Larkin writes: > > > On Fri, Jul 15, 2022 at 12:27:04PM -0400, Dave Voutila wrote: > >> The following diff adds in formalization around mmio assists for nested > >> page/ept faults on Intel and AMD vmm(4) hosts. It