Re: [PATCH] Exclude pico-debug from the uhid driver

2022-08-22 Thread Jonathan Gray
On Mon, Aug 22, 2022 at 08:33:45PM +0200, Josuah Demangeon wrote: > The pico-debug [1] is a debug firmware, loaded on a Raspberry Pi RP2040 > microcontroller to provide a standard debug interface. > The host support tool OpenOCD already upstreamed it [2]. > > But it does not work with OpenBSD yet,

Re: [RFC] acpi: add acpitimer_delay(), acpihpet_delay()

2022-08-22 Thread Jonathan Gray
On Mon, Aug 22, 2022 at 09:37:02AM -0500, Scott Cheloha wrote: > On Wed, Aug 17, 2022 at 09:00:12PM +1000, Jonathan Gray wrote: > > On Wed, Aug 17, 2022 at 04:53:20PM +1000, Jonathan Gray wrote: > > > > > > It seems to me it would be cleaner if the decision of what to use for > > > delay could be

Re: [PATCH] Exclude pico-debug from the uhid driver

2022-08-22 Thread Stuart Henderson
On 2022/08/22 20:33, Josuah Demangeon wrote: > The pico-debug [1] is a debug firmware, loaded on a Raspberry Pi RP2040 > microcontroller to provide a standard debug interface. > The host support tool OpenOCD already upstreamed it [2]. > > But it does not work with OpenBSD yet, as uhid(4) takes ove

Re: mention double quotes for passwords with white spaces

2022-08-22 Thread Theo de Raadt
Stuart Henderson wrote: > > > .Nm > > > will hash the nwid along with the passphrase to create the key. > > > +If a passphrase contains one or more whitespaces, it can be surrounded > > > +by double quotes. > > The same applies for nwid, pppoekey, descr, pass (carp). > > The place this is nee

Re: mention double quotes for passwords with white spaces

2022-08-22 Thread Stuart Henderson
On 2022/08/22 16:41, Theo de Raadt wrote: > Hi, > > Do you recommend we do the same in the cat manual page, regarding filenames? > > Or for that matter, in hundreds of other manual pages. > > Unix does whitespace-seperated tokenization, nearly everywhere, so I > do not think this needs to be doc

Re: mention double quotes for passwords with white spaces

2022-08-22 Thread Theo de Raadt
Hi, Do you recommend we do the same in the cat manual page, regarding filenames? Or for that matter, in hundreds of other manual pages. Unix does whitespace-seperated tokenization, nearly everywhere, so I do not think this needs to be documented. Florian Viehweger wrote: > Hi, > > this is a

move PRU_RCVD request to (*pru_rcvd)()

2022-08-22 Thread Vitaliy Makkoveev
Another one. Since we never use `flags' arg within handlers, remove it from the pru_rcvd() args. Index: sys/sys/protosw.h === RCS file: /cvs/src/sys/sys/protosw.h,v retrieving revision 1.43 diff -u -p -r1.43 protosw.h --- sys/sys/pro

Re: mention double quotes for passwords with white spaces

2022-08-22 Thread Klemens Nanni
On Tue, Aug 23, 2022 at 12:01:14AM +0200, Florian Viehweger wrote: > Hi, > > this is a diff mentioning double quotes for using passphrases > containing whitespaces. > > Additionally adding a comma to a sentence for better clarity. > > Comments? > > Thanks! > > Index: ifconfig.8 > =

mention double quotes for passwords with white spaces

2022-08-22 Thread Florian Viehweger
Hi, this is a diff mentioning double quotes for using passphrases containing whitespaces. Additionally adding a comma to a sentence for better clarity. Comments? Thanks! Index: ifconfig.8 === RCS file: /daten/openbsdmirror/cvs/mir

Re: netlock igmp mld6 timer

2022-08-22 Thread Vitaliy Makkoveev
On Mon, Aug 22, 2022 at 10:42:05PM +0200, Alexander Bluhm wrote: > On Mon, Aug 22, 2022 at 08:14:05PM +0300, Vitaliy Makkoveev wrote: > > May be I misunderstood something, but what is the reason to compiler to > > drop this read? The value is not yet loaded, and we have no other > > unlocked access

Re: move PRU_SHUTDOWN request to (*pru_shutdown)()

2022-08-22 Thread Vitaliy Makkoveev
On Mon, Aug 22, 2022 at 08:22:11PM +0200, Alexander Bluhm wrote: > > + > > +out: > > + if (otp) > > + tcp_trace(TA_USER, ostate, tp, otp, NULL, PRU_SHUTDOWN, 0); > > return (0); > > This must be return (error). > Fixed, thanks! Index: sys/kern/uipc_usrreq.c =

Re: move PRU_SHUTDOWN request to (*pru_shutdown)()

2022-08-22 Thread Alexander Bluhm
On Mon, Aug 22, 2022 at 11:59:31PM +0300, Vitaliy Makkoveev wrote: > On Mon, Aug 22, 2022 at 08:22:11PM +0200, Alexander Bluhm wrote: > > > + > > > +out: > > > + if (otp) > > > + tcp_trace(TA_USER, ostate, tp, otp, NULL, PRU_SHUTDOWN, 0); > > > return (0); > > > > This must be return (er

Re: netlock igmp mld6 timer

2022-08-22 Thread Alexander Bluhm
On Mon, Aug 22, 2022 at 08:14:05PM +0300, Vitaliy Makkoveev wrote: > May be I misunderstood something, but what is the reason to compiler to > drop this read? The value is not yet loaded, and we have no other > unlocked access to this variable before rwlock. > > void > mld6_fasttimeo(void) > { >

Re: pf fragment lock

2022-08-22 Thread Alexandr Nedvedicky
Hello, On Mon, Aug 22, 2022 at 08:45:29PM +0200, Alexander Bluhm wrote: > Hi, > > Hrvoje managed to crash the kernel in pf fragment reassembly. > > > r620-1# pfctl -e > > pf enabled > > r620-1# pfctl -f /etc/pf.conf > > uvm_fault(0x824b9278, 0xb7, 0, 2) -> e > > kernel: page fault trap,

pf fragment lock

2022-08-22 Thread Alexander Bluhm
Hi, Hrvoje managed to crash the kernel in pf fragment reassembly. > r620-1# pfctl -e > pf enabled > r620-1# pfctl -f /etc/pf.conf > uvm_fault(0x824b9278, 0xb7, 0, 2) -> e > kernel: page fault trap, code=0 > Stopped at pf_free_fragment+0x77: movq%rax,0xb8(%rcx) > TIDPID

[PATCH] Exclude pico-debug from the uhid driver

2022-08-22 Thread Josuah Demangeon
The pico-debug [1] is a debug firmware, loaded on a Raspberry Pi RP2040 microcontroller to provide a standard debug interface. The host support tool OpenOCD already upstreamed it [2]. But it does not work with OpenBSD yet, as uhid(4) takes over the RP2040 once plugged, blocking full libusb access

Re: move PRU_SHUTDOWN request to (*pru_shutdown)()

2022-08-22 Thread Alexander Bluhm
On Mon, Aug 22, 2022 at 05:55:48PM +0300, Vitaliy Makkoveev wrote: > +/* > + * Mark the connection as being incapable of further output. > + */ > +int > +tcp_shutdown(struct socket *so) > +{ > + struct inpcb *inp; > + struct tcpcb *tp, *otp = NULL; > + int error; > + short ostate; >

Re: netlock igmp mld6 timer

2022-08-22 Thread Vitaliy Makkoveev
> On 22 Aug 2022, at 18:51, Alexander Bluhm wrote: > > On Mon, Aug 22, 2022 at 05:59:09PM +0300, Vitaliy Makkoveev wrote: >> On Mon, Aug 22, 2022 at 05:51:00PM +0300, Vitaliy Makkoveev wrote: >>> On Mon, Aug 22, 2022 at 03:59:39PM +0200, Alexander Bluhm wrote: On Sun, Aug 21, 2022 at 10:10:5

Re: netlock igmp mld6 timer

2022-08-22 Thread Alexander Bluhm
On Mon, Aug 22, 2022 at 05:59:09PM +0300, Vitaliy Makkoveev wrote: > On Mon, Aug 22, 2022 at 05:51:00PM +0300, Vitaliy Makkoveev wrote: > > On Mon, Aug 22, 2022 at 03:59:39PM +0200, Alexander Bluhm wrote: > > > On Sun, Aug 21, 2022 at 10:10:53PM +0300, Vitaliy Makkoveev wrote: > > > > On Sun, Aug 2

Re: netlock igmp mld6 timer

2022-08-22 Thread Vitaliy Makkoveev
On Mon, Aug 22, 2022 at 05:51:00PM +0300, Vitaliy Makkoveev wrote: > On Mon, Aug 22, 2022 at 03:59:39PM +0200, Alexander Bluhm wrote: > > On Sun, Aug 21, 2022 at 10:10:53PM +0300, Vitaliy Makkoveev wrote: > > > On Sun, Aug 21, 2022 at 07:19:23PM +0200, Alexander Bluhm wrote: > > > > When testing pa

move PRU_SHUTDOWN request to (*pru_shutdown)()

2022-08-22 Thread Vitaliy Makkoveev
Index: sys/kern/uipc_usrreq.c === RCS file: /cvs/src/sys/kern/uipc_usrreq.c,v retrieving revision 1.173 diff -u -p -r1.173 uipc_usrreq.c --- sys/kern/uipc_usrreq.c 22 Aug 2022 13:23:06 - 1.173 +++ sys/kern/uipc_usrreq.c

Re: netlock igmp mld6 timer

2022-08-22 Thread Vitaliy Makkoveev
On Mon, Aug 22, 2022 at 03:59:39PM +0200, Alexander Bluhm wrote: > On Sun, Aug 21, 2022 at 10:10:53PM +0300, Vitaliy Makkoveev wrote: > > On Sun, Aug 21, 2022 at 07:19:23PM +0200, Alexander Bluhm wrote: > > > When testing parallel UDP input, I see contention on the netlock > > > from the protocol t

Re: [RFC] acpi: add acpitimer_delay(), acpihpet_delay()

2022-08-22 Thread Scott Cheloha
On Wed, Aug 17, 2022 at 09:00:12PM +1000, Jonathan Gray wrote: > On Wed, Aug 17, 2022 at 04:53:20PM +1000, Jonathan Gray wrote: > > > > It seems to me it would be cleaner if the decision of what to use for > > delay could be moved into an md file. > > > > Or abstract it by having a numeric weight

Re: netlock igmp mld6 timer

2022-08-22 Thread Alexander Bluhm
On Sun, Aug 21, 2022 at 10:10:53PM +0300, Vitaliy Makkoveev wrote: > On Sun, Aug 21, 2022 at 07:19:23PM +0200, Alexander Bluhm wrote: > > When testing parallel UDP input, I see contention on the netlock > > from the protocol timer. There is a check to avoid loop traversal > > if igmp and mld6 are

Re: rpki-client: retire valid_cert()

2022-08-22 Thread Job Snijders
On Mon, Aug 22, 2022 at 12:14:53PM +0200, Theo Buehler wrote: > rpki-client portable makes sure that libcrypto has RFC 3779 support. > Therefore the X509_verify_cert() call in valid_x509() will already > perform the checks that the RFC 3779 extensions are covered along the > chain. While valid_cert

Re: running UDP input in parallel

2022-08-22 Thread Alexander Bluhm
On Sun, Aug 21, 2022 at 07:07:29PM +0200, Alexander Bluhm wrote: > On Fri, Aug 19, 2022 at 10:54:42PM +0200, Alexander Bluhm wrote: > > This diff allows to run udp_input() in parallel. Diff rebased to -current. Index: kern/uipc_socket.c

input protocol checksum

2022-08-22 Thread Alexander Bluhm
Hi, I was always wondering, why we calculate the protocol checksum in the IP input path. henning@ introduced it with this commit. revision 1.213 date: 2013/06/26 09:12:40; author: henning; state: Exp; lines: +4 -1; put the cksum diff back, of course with the bug f

Re: move PRU_DISCONNECT request to (*pru_disconnect)

2022-08-22 Thread Alexander Bluhm
On Mon, Aug 22, 2022 at 12:37:20PM +0300, Vitaliy Makkoveev wrote: > The former tcp_disconnect() was renamed to tcp_dodisconnect(). > > ok? OK bluhm@ > Index: sys/kern/uipc_usrreq.c > === > RCS file: /cvs/src/sys/kern/uipc_usrreq.c,

Re: installboot: fix argc check to prevent installing w/o disk

2022-08-22 Thread Klemens Nanni
This won't fly since an exact argc check breaks the case where a disk and an explicit first stage is given while for the second stage the default is used: installboot sd0 /usr/mdec/biosboot Also, the following mistyped/bogus usages are still argc-valid regarless of this diff: insta

rpki-client: retire valid_cert()

2022-08-22 Thread Theo Buehler
rpki-client portable makes sure that libcrypto has RFC 3779 support. Therefore the X509_verify_cert() call in valid_x509() will already perform the checks that the RFC 3779 extensions are covered along the chain. While valid_cert()'s errors would be nicer than the validator's, they can't be reached

move PRU_DISCONNECT request to (*pru_disconnect)

2022-08-22 Thread Vitaliy Makkoveev
The former tcp_disconnect() was renamed to tcp_dodisconnect(). ok? Index: sys/kern/uipc_usrreq.c === RCS file: /cvs/src/sys/kern/uipc_usrreq.c,v retrieving revision 1.172 diff -u -p -r1.172 uipc_usrreq.c --- sys/kern/uipc_usrreq.c

Re: inpcb notify rwlock

2022-08-22 Thread Vitaliy Makkoveev
On Mon, Aug 22, 2022 at 09:38:15AM +0200, Alexander Bluhm wrote: > Hi, > > To run over all PCB, I have introduced temporary notify lists. They > are necessary as the list of all PCB is protected by a mutex. Notify > may call ip_output() eventually which may sleep as pf lock is a > rwlock. Also

inpcb notify rwlock

2022-08-22 Thread Alexander Bluhm
Hi, To run over all PCB, I have introduced temporary notify lists. They are necessary as the list of all PCB is protected by a mutex. Notify may call ip_output() eventually which may sleep as pf lock is a rwlock. Also the SRP implementation of the route table might sleep. The same inp_notify i