Re: ampintc: minor nits

2022-08-15 Thread Anton Lindqvist
On Mon, Jul 18, 2022 at 12:37:00PM +0200, Anton Lindqvist wrote: > On Fri, Jul 15, 2022 at 06:58:33PM +0200, Mark Kettenis wrote: > > > Date: Mon, 11 Jul 2022 16:21:39 +0200 > > > From: Anton Lindqvist > > > > > > On Mon, Jul 11, 2022 at 09:02:20AM +0200, Mark Kettenis wrote: > > > > > Date: Mon,

Re: Add Intel Optane 900P/905P NVMe

2022-08-15 Thread Jonathan Gray
On Sun, Aug 14, 2022 at 04:03:59PM +0200, Andreas Bartelt wrote: > Hi, > > Intel Optane 905p NVMe devices were not yet recognized in CURRENT (e.g., > https://ark.intel.com/content/www/us/en/ark/products/148607/intel-optane-ssd-905p-series-380gb-m-2-110mm-pcie-x4-20nm-3d-xpoint.html > ). > > I've

Re: stub out initial mmio support for vmm(4)/vmd(8)

2022-08-15 Thread Dave Voutila
Mike Larkin writes: > On Fri, Jul 15, 2022 at 12:27:04PM -0400, Dave Voutila wrote: >> The following diff adds in formalization around mmio assists for nested >> page/ept faults on Intel and AMD vmm(4) hosts. It provides what little >> information is available to userland in terms of either the

Re: [RFC] acpi: add acpitimer_delay(), acpihpet_delay()

2022-08-15 Thread Mike Larkin
On Sun, Aug 14, 2022 at 11:24:37PM -0500, Scott Cheloha wrote: > Hi, > > In the future when the LAPIC timer is run in oneshot mode there will > be no lapic_delay(). > > This is fine if you have a constant TSC, because we have tsc_delay(). > > This is *very* bad for older amd64 machines, because you

Re: em(4) multiqueue

2022-08-15 Thread Hrvoje Popovski
On 12.8.2022. 22:15, Hrvoje Popovski wrote: > Hi, > > I'm testing forwarding over > > em0 at pci7 dev 0 function 0 "Intel 82576" rev 0x01, msix, 4 queues, > em1 at pci7 dev 0 function 1 "Intel 82576" rev 0x01, msix, 4 queues, > em2 at pci8 dev 0 function 0 "Intel I210" rev 0x03, msix, 4 queues, >

protocol attack wait

2022-08-15 Thread Alexander Bluhm
Hi, System calls should not fail due to temporary memory shortage in malloc(9) or pool_get(9). Pass down a wait flag to pru_attach(). During syscall socket(2) it is ok to wait, this logic was missing for internet pcb. Pfkey and route sockets were already waiting. sonewconn() cannot wait when c

Re: Introduce tcp_sogetpcb()

2022-08-15 Thread Alexander Bluhm
On Mon, Aug 15, 2022 at 05:05:23PM +0300, Vitaliy Makkoveev wrote: > This diff takes a references on sliced sockets and keeps them until > sounslice() called. I don't propose to commit it as is, may be sorele() > should be reworked to call sofree() itself. Exclusive netlock makes the current code

Re: Introduce tcp_sogetpcb()

2022-08-15 Thread Alexander Bluhm
On Mon, Aug 15, 2022 at 04:20:57PM +0300, Vitaliy Makkoveev wrote: > tcp_close(struct tcpcb *tp) > { > /* ... */ > inp->inp_ppcb = NULL; > soisdisconnected(so); > in_pcbdetach(inp); > return (NULL); > } > > soisdisconnected(struct socket *so) > { > s

Re: Introduce tcp_sogetpcb()

2022-08-15 Thread Vitaliy Makkoveev
On Mon, Aug 15, 2022 at 04:28:28PM +0300, Vitaliy Makkoveev wrote: > On Mon, Aug 15, 2022 at 04:20:57PM +0300, Vitaliy Makkoveev wrote: > > On Mon, Aug 15, 2022 at 02:36:34PM +0200, Alexander Bluhm wrote: > > > On Mon, Aug 15, 2022 at 02:29:02PM +0300, Vitaliy Makkoveev wrote: > > > > Nothing speci

Re: Introduce tcp_sogetpcb()

2022-08-15 Thread Vitaliy Makkoveev
On Mon, Aug 15, 2022 at 04:20:57PM +0300, Vitaliy Makkoveev wrote: > On Mon, Aug 15, 2022 at 02:36:34PM +0200, Alexander Bluhm wrote: > > On Mon, Aug 15, 2022 at 02:29:02PM +0300, Vitaliy Makkoveev wrote: > > > Nothing special, just get assign `inp' and `tp' from passed socket. I > > > want to do t

Re: Introduce tcp_sogetpcb()

2022-08-15 Thread Vitaliy Makkoveev
On Mon, Aug 15, 2022 at 02:36:34PM +0200, Alexander Bluhm wrote: > On Mon, Aug 15, 2022 at 02:29:02PM +0300, Vitaliy Makkoveev wrote: > > Nothing special, just get assign `inp' and `tp' from passed socket. I > > want to do this before (*pru_usrreq)() split to avoid huge code > > duplication. > > >

Re: bgpd better nexthop handling

2022-08-15 Thread Claudio Jeker
On Mon, Aug 15, 2022 at 03:00:36PM +0200, Theo Buehler wrote: > On Mon, Aug 15, 2022 at 02:26:32PM +0200, Claudio Jeker wrote: > > On Fri, Aug 12, 2022 at 03:30:16PM +0200, Claudio Jeker wrote: > > > On Fri, Aug 12, 2022 at 03:06:14PM +0200, Theo Buehler wrote: > > > > On Fri, Aug 12, 2022 at 12:43

Re: bgpd better nexthop handling

2022-08-15 Thread Theo Buehler
On Mon, Aug 15, 2022 at 02:26:32PM +0200, Claudio Jeker wrote: > On Fri, Aug 12, 2022 at 03:30:16PM +0200, Claudio Jeker wrote: > > On Fri, Aug 12, 2022 at 03:06:14PM +0200, Theo Buehler wrote: > > > On Fri, Aug 12, 2022 at 12:43:09PM +0200, Claudio Jeker wrote: > > > > There is currently a race in

Re: Introduce tcp_sogetpcb()

2022-08-15 Thread Alexander Bluhm
On Mon, Aug 15, 2022 at 02:29:02PM +0300, Vitaliy Makkoveev wrote: > Nothing special, just get assign `inp' and `tp' from passed socket. I > want to do this before (*pru_usrreq)() split to avoid huge code > duplication. > > We have "tp might get 0 when using socket splicing" commentary. I > checke

Re: bgpd better nexthop handling

2022-08-15 Thread Claudio Jeker
On Fri, Aug 12, 2022 at 03:30:16PM +0200, Claudio Jeker wrote: > On Fri, Aug 12, 2022 at 03:06:14PM +0200, Theo Buehler wrote: > > On Fri, Aug 12, 2022 at 12:43:09PM +0200, Claudio Jeker wrote: > > > There is currently a race in bgpd when multiple nexthop become invalid at > > > the same time. The

Re: IPv6 hop-by-hop check in parallel

2022-08-15 Thread Vitaliy Makkoveev
On Mon, Aug 15, 2022 at 11:47:03AM +0200, Alexander Bluhm wrote: > On Sun, Aug 14, 2022 at 02:04:09AM +0300, Vitaliy Makkoveev wrote: > > On Sat, Aug 13, 2022 at 09:08:36PM +0200, Alexander Bluhm wrote: > > > Hi, > > > > > > While running forwarding in parallel, I have introduced a hard > > > barr

Introduce tcp_sogetpcb()

2022-08-15 Thread Vitaliy Makkoveev
Nothing special, just get assign `inp' and `tp' from passed socket. I want to do this before (*pru_usrreq)() split to avoid huge code duplication. We have "tp might get 0 when using socket splicing" commentary. I checked where we set `inp_ppcb' to NULL and found, tcp_close() is the only place, and

Re: libsoup2/3 conflicts and gstreamer1 [Re: audio/quodlibet & devel/libsoup]

2022-08-15 Thread Jeremie Courreges-Anglas
On Thu, Aug 11 2022, Stuart Henderson wrote: > Moving from ports@. > > Quick intro: > > A library (gstreamer1) uses functions from another library (libsoup) > which exists in two incompatible versions (libsoup-2.4.so.XX and > libsoup-3.0.so.XX). > > Other software calling gstreamer might use one o

Re: httpd, use proper type for clt_descreq and clt_descresp

2022-08-15 Thread Theo Buehler
On Mon, Aug 15, 2022 at 12:35:14PM +0200, Claudio Jeker wrote: > There is no need to use void * for clt_descreq and clt_descresp. > The only thing these point to are struct http_descriptor. So make > them struct http_descriptor pointers. This kills a typecast in > server_fcgi.c. ok I suspect a fe

httpd, use proper type for clt_descreq and clt_descresp

2022-08-15 Thread Claudio Jeker
There is no need to use void * for clt_descreq and clt_descresp. The only thing these point to are struct http_descriptor. So make them struct http_descriptor pointers. This kills a typecast in server_fcgi.c. -- :wq Claudio Index: httpd.h =

Re: IPv6 hop-by-hop check in parallel

2022-08-15 Thread Alexander Bluhm
On Sun, Aug 14, 2022 at 02:04:09AM +0300, Vitaliy Makkoveev wrote: > On Sat, Aug 13, 2022 at 09:08:36PM +0200, Alexander Bluhm wrote: > > Hi, > > > > While running forwarding in parallel, I have introduced a hard > > barrier for parallel local protocol processing. The packets are > > requeued fro

Re: httpd: plug fd/memory leaks in error paths

2022-08-15 Thread Theo Buehler
On Mon, Aug 15, 2022 at 10:54:57AM +0200, Omar Polo wrote: > Agreed. Even if some operation failed we can still generate an error > page; only after server_response_http things get trickier (headers are > set, logging is done, ...) and just shutting down the reply is easier. > (it also becomes a d

Re: httpd: plug fd/memory leaks in error paths

2022-08-15 Thread Omar Polo
On 2022/08/15 10:13:07 +0200, Theo Buehler wrote: > I think you should move the scandir() call to right before the for loop. > This way the two goto fail before the for loop don't leak the namelist > (one of these leaks was already there, the other one is added in your > diff). right, with the sk

Re: [RFC] acpi: add acpitimer_delay(), acpihpet_delay()

2022-08-15 Thread Jonathan Gray
On Sun, Aug 14, 2022 at 11:24:37PM -0500, Scott Cheloha wrote: > Hi, > > In the future when the LAPIC timer is run in oneshot mode there will > be no lapic_delay(). > > This is fine if you have a constant TSC, because we have tsc_delay(). > > This is *very* bad for older amd64 machines, because

Re: httpd: plug fd/memory leaks in error paths

2022-08-15 Thread Theo Buehler
On Mon, Aug 15, 2022 at 09:38:51AM +0200, Omar Polo wrote: > On 2022/08/15 08:53:05 +0200, Theo Buehler wrote: > > On Sun, Aug 14, 2022 at 11:15:16PM +0200, Omar Polo wrote: > > > I was looking for something different when I stumbled upon this. > > > > > > - in server_file_index `escapedpath' is

Re: httpd: plug fd/memory leaks in error paths

2022-08-15 Thread Omar Polo
On 2022/08/15 08:53:05 +0200, Theo Buehler wrote: > On Sun, Aug 14, 2022 at 11:15:16PM +0200, Omar Polo wrote: > > I was looking for something different when I stumbled upon this. > > > > - in server_file_index `escapedpath' is leaked if evbuffer_add_printf > >fails, similarly the directory