Re: What is ieee80211com->ic_ibss_chan?

2022-08-08 Thread Farhan Khan
On Monday, August 8, 2022 7:40:19 PM EDT Jonathan Gray wrote: > On Mon, Aug 08, 2022 at 11:40:17AM -0400, Farhan Khan wrote: > > Hi all, > > > > I am trying to understand the different channels in `struct ieee80211com`. > > I see 2 types of ieee80211_channel values: * ic_ibss_chan > > * ic_des_cha

Re: What is ieee80211com->ic_ibss_chan?

2022-08-08 Thread Jonathan Gray
On Mon, Aug 08, 2022 at 11:40:17AM -0400, Farhan Khan wrote: > Hi all, > > I am trying to understand the different channels in `struct ieee80211com`. I > see 2 types of ieee80211_channel values: > * ic_ibss_chan > * ic_des_chan - Desired channel, pretty straight forward > > What is ic_ibss_chan

Re: ipv6 fragment checksum

2022-08-08 Thread Moritz Buhl
On Sun, Aug 07, 2022 at 12:41:29AM +0200, Alexander Bluhm wrote: > Hi, > > If interface drivers have enabled transmit offloading for the payload > checksum , IPv6 fragments contain invalid checksum. For fragments > the protocol checksum has to be calculated before fragmentation. > Hardware cannot

Re: net*: Add *toc*() helpers to const-convert between AF specific and generic structs

2022-08-08 Thread Theo de Raadt
Klemens Nanni wrote: > On Fri, Aug 05, 2022 at 05:08:14PM +0200, Claudio Jeker wrote: > > We added the inline functions for these typecasts to add a minimal level > > of error protection. Now where do we hit const problems? I have not seen > > such issues and I wonder if those just come from ove

Re: net*: Add *toc*() helpers to const-convert between AF specific and generic structs

2022-08-08 Thread Klemens Nanni
On Fri, Aug 05, 2022 at 05:08:14PM +0200, Claudio Jeker wrote: > We added the inline functions for these typecasts to add a minimal level > of error protection. Now where do we hit const problems? I have not seen > such issues and I wonder if those just come from overzealous use of const > argumen

Re: fgetln->getline in games/* (Was: Re: quiz(6): fully switch to getline(3))

2022-08-08 Thread Todd C . Miller
Looks fine to me, though the free(answer) before exit(0) in quiz.c is not needed. OK millert@ - todd

What is ieee80211com->ic_ibss_chan?

2022-08-08 Thread Farhan Khan
Hi all, I am trying to understand the different channels in `struct ieee80211com`. I see 2 types of ieee80211_channel values: * ic_ibss_chan * ic_des_chan - Desired channel, pretty straight forward What is ic_ibss_chan used for? My initial guess was that it was the "current channel", but given

Re: rpki-client: add connect() MAX_CONTIMEOUT for rsync/rrdp

2022-08-08 Thread Job Snijders
On Tue, Aug 02, 2022 at 12:27:57PM -0600, Theo de Raadt wrote: > I think you intend for that to be two seperate diffs, not merged into > one. > > For connect < 15 seconds, I think that is a bit strict. > > For IO stalling 15 seconds, I suspect such IO stalls happen more than > we know, and will d

Re: Split (*pr_usrreq)() by multiple handlers

2022-08-08 Thread Vitaliy Makkoveev
On Mon, Aug 08, 2022 at 12:47:07AM +0200, Alexander Bluhm wrote: > On Mon, Aug 08, 2022 at 01:03:13AM +0300, Vitaliy Makkoveev wrote: > > > I prefer the first idiom. If there is an error, do something. We > > > should not change the style in opposite direction. This will prevent > > > consistenc

Re: [External] : inpcb lookup ref counting

2022-08-08 Thread Alexandr Nedvedicky
Hello, diff looks good to me as far as I can tell. OK sashan@

pfctl: fix POM_STICKYADDRESS check

2022-08-08 Thread Kristof Provost
Hi, This issue was reported to FreeBSD by Franco Fichtner and is relevant to OpenBSD as well. The POM_STICKYADDRESS flag is only ever set in pool_opts, but was checked in filter_opts. That’s clearly not intended. The parser tries to prevent "sticky-address sticky-address" syntax but was a

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-08 Thread Scott Cheloha
On Sun, Aug 07, 2022 at 11:05:37AM +, Visa Hankala wrote: > On Sun, Jul 31, 2022 at 01:28:18PM -0500, Scott Cheloha wrote: > > Apparently mips64, i.e. octeon and loongson, has the same problem as > > powerpc/macppc and powerpc64. The timer interrupt is normally only > > logically masked, not p

Re: top(1): display uptime in HH:MM:SS format

2022-08-08 Thread Alexander Bluhm
OK bluhm@ On Sun, Aug 07, 2022 at 06:22:38PM -0500, Scott Cheloha wrote: > On Fri, Sep 18, 2020 at 03:59:05PM -0500, Scott Cheloha wrote: > > > > [...] > > > > - An HH:MM:SS format uptime is useful in top(1). It's also more > > visually consistent with the local timestamp printed on the line

fgetln->getline in games/* (Was: Re: quiz(6): fully switch to getline(3))

2022-08-08 Thread Omar Polo
bump Omar Polo wrote: > Ben Fuller wrote: > > On Sun, Jul 03, 2022 at 02:31:42 +0100, Ben Fuller wrote: > > > One of the fgetln(3)s was previously converted to getline(3), but not > > > the other. > > > > > > diff --git games/quiz/quiz.c games/quiz/quiz.c > > > index d4fd0604e0d..362fb1e24a8 10