Re: pipex(4): remove PIPEXCSESSION ioctl(2) command

2022-07-11 Thread YASUOKA Masahiko
ok yasuoka On Mon, 11 Jul 2022 01:11:22 +0300 Vitaliy Makkoveev wrote: > Long time ago pipex(4) session can't be deleted until both pipex(4) > input and output queues become empty. Dead sessions were linked to the > stack and the `ip_forward' flag was used to prevent packets forwarding. > npppd(8

Re: interface media list mutex

2022-07-11 Thread Vitaliy Makkoveev
> On 11 Jul 2022, at 13:02, Alexander Bluhm wrote: > > Hi, > > Customer complains that routing video stream over OpenBSD stutters > when snmpd is runnning. It looks like ioctl(SIOCGIFMEDIA) may be > the culprit, so I want to get it out of the netlock. > > Start with a mutex around interface me

Re: Introduce uvm_pagewait()

2022-07-11 Thread Mark Kettenis
> Date: Mon, 11 Jul 2022 13:33:39 +0200 > From: Martin Pieuchot > > On 28/06/22(Tue) 14:13, Martin Pieuchot wrote: > > I'd like to abstract the use of PG_WANTED to start unifying & cleaning > > the various cases where a code path is waiting for a busy page. Here's > > the first step. > > > > ok

Re: bgpd document add-path send

2022-07-11 Thread Stuart Henderson
On 2022/07/11 19:12, Claudio Jeker wrote: > This is my try at documenting the just added add-path bits. > > -- > :wq Claudio > > Index: bgpd.8 > === > RCS file: /cvs/src/usr.sbin/bgpd/bgpd.8,v > retrieving revision 1.74 > diff -u -p

Re: What is ieee80211com.ic_max_nnodes?

2022-07-11 Thread Farhan Khan
On Mon, Jul 11, 2022, at 2:24 PM, Stefan Sperling wrote: Thank you so much for your prompt reply! > In AP mode, max nodes effectively sets a limit on how many clients can > be connected concurrently. Because athn(4) USB firmware has an internal > limit of 8 stations in its station table, and one e

Re: echo(1): check for stdio errors

2022-07-11 Thread Scott Cheloha
On Mon, Jul 11, 2022 at 08:31:04AM -0600, Todd C. Miller wrote: > On Sun, 10 Jul 2022 20:58:35 -0900, Philip Guenther wrote: > > > Three thoughts: > > 1) Since stdio errors are sticky, is there any real advantage to checking > > each call instead of just checking the final fclose()? My thinking w

Re: What is ieee80211com.ic_max_nnodes?

2022-07-11 Thread Stefan Sperling
On Mon, Jul 11, 2022 at 11:32:12AM -0400, Farhan Khan wrote: > Hi all, > > I am reading through the athn(4) driver and see a reference to > ieee80211com.ic_max_nnodes here > (http://bxr.su/OpenBSD/sys/dev/ic/athn.c#294). What is this variable? The > comment immediately above says "In HostAP mod

Re: bgpd document add-path send

2022-07-11 Thread Jason McIntyre
On Mon, Jul 11, 2022 at 07:12:11PM +0200, Claudio Jeker wrote: > This is my try at documenting the just added add-path bits. > > -- > :wq Claudio > some comments: > Index: bgpd.8 > === > RCS file: /cvs/src/usr.sbin/bgpd/bgpd.8,v >

Re: bgpd document add-path send

2022-07-11 Thread Jason McIntyre
On Mon, Jul 11, 2022 at 07:12:11PM +0200, Claudio Jeker wrote: > This is my try at documenting the just added add-path bits. > > -- > :wq Claudio > some comments inline: > Index: bgpd.8 > === > RCS file: /cvs/src/usr.sbin/bgpd/bgp

bgpd document add-path send

2022-07-11 Thread Claudio Jeker
This is my try at documenting the just added add-path bits. -- :wq Claudio Index: bgpd.8 === RCS file: /cvs/src/usr.sbin/bgpd/bgpd.8,v retrieving revision 1.74 diff -u -p -r1.74 bgpd.8 --- bgpd.8 28 Jun 2022 11:52:24 -

What is ieee80211com.ic_max_nnodes?

2022-07-11 Thread Farhan Khan
Hi all, I am reading through the athn(4) driver and see a reference to ieee80211com.ic_max_nnodes here (http://bxr.su/OpenBSD/sys/dev/ic/athn.c#294). What is this variable? The comment immediately above says "In HostAP mode, the number of STAs that we can handle...". What does "handle" this mea

Re: bgpd: add add-path send support

2022-07-11 Thread Theo Buehler
On Fri, Jul 08, 2022 at 06:43:17PM +0200, Claudio Jeker wrote: > Add the missing bits for add-path send support. > The config options allows for a fair amount of configuration and not all > have been tested: > announce add-path send best [ plus X ] > announce add-path send ecmp [ plus X

Replace selwakeup() with KNOTE() in audio(4)

2022-07-11 Thread Visa Hankala
Replace selwakeup() with KNOTE() in audio(4). KNOTE() can be used up to IPL_SCHED. IPL_SCHED is higher than IPL_AUDIO, so the deferring through soft interrupts is no longer necessary. In audio_detach(), the selwakeup() calls should not need replacing. Any remaining kevent/poll/select waiters are

Re: echo(1): check for stdio errors

2022-07-11 Thread Todd C . Miller
On Sun, 10 Jul 2022 20:58:35 -0900, Philip Guenther wrote: > Three thoughts: > 1) Since stdio errors are sticky, is there any real advantage to checking > each call instead of just checking the final fclose()? Will that really catch all errors? From what I can tell, fclose(3) can succeed even if

Re: ampintc: minor nits

2022-07-11 Thread Anton Lindqvist
On Mon, Jul 11, 2022 at 09:02:20AM +0200, Mark Kettenis wrote: > > Date: Mon, 11 Jul 2022 08:35:44 +0200 > > From: Anton Lindqvist > > > > Hi, > > Addressing the following nits made it easier for me to grasp the ampintc > > implementation while reading the specification. There's also one missing

Re: Introduce uvm_pagewait()

2022-07-11 Thread Sebastien Marie
On Tue, Jun 28, 2022 at 02:13:04PM +0200, Martin Pieuchot wrote: > I'd like to abstract the use of PG_WANTED to start unifying & cleaning > the various cases where a code path is waiting for a busy page. Here's > the first step. > > ok? if it helps you, yes it is fine. ok semarie@ just one nit

Re: Introduce uvm_pagewait()

2022-07-11 Thread Martin Pieuchot
On 28/06/22(Tue) 14:13, Martin Pieuchot wrote: > I'd like to abstract the use of PG_WANTED to start unifying & cleaning > the various cases where a code path is waiting for a busy page. Here's > the first step. > > ok? Anyone? > Index: uvm/uvm_amap.c > ==

interface media list mutex

2022-07-11 Thread Alexander Bluhm
Hi, Customer complains that routing video stream over OpenBSD stutters when snmpd is runnning. It looks like ioctl(SIOCGIFMEDIA) may be the culprit, so I want to get it out of the netlock. Start with a mutex around interface media list. ok? bluhm Index: dev/ic/gem.c ==

Re: ampintc: minor nits

2022-07-11 Thread Mark Kettenis
> Date: Mon, 11 Jul 2022 08:35:44 +0200 > From: Anton Lindqvist > > Hi, > Addressing the following nits made it easier for me to grasp the ampintc > implementation while reading the specification. There's also one missing > NULL check included. > > Too verbose or does anyone else consider this a