Don't build lldb on archs where it's not supported

2022-07-09 Thread Jeremie Courreges-Anglas
We currently build most of the lldb support code on all archs, even though we only build and install the lldb executable (and lldb-server) on amd64 and arm64. This wastes a significant amount of CPU cycles during all base builds for no good reason that I can see. The diff below puts the lldb-or

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

2022-07-09 Thread YASUOKA Masahiko
ok yasuoka On Sat, 9 Jul 2022 18:04:04 +0300 Vitaliy Makkoveev wrote: > On Sat, Jul 09, 2022 at 10:46:56PM +0900, YASUOKA Masahiko wrote: >> Hello, >> >> On Sat, 9 Jul 2022 01:43:41 +0300 >> Vitaliy Makkoveev wrote: >> > On Sat, Jul 09, 2022 at 12:08:49AM +0300, Vitaliy Makkoveev wrote: >> >> T

iked: generate stronger ECDSA keys by default

2022-07-09 Thread Tobias Heider
Hi, we currently generate one pair of 2048 bit RSA keys for isakmpd and iked by default on new installations. In 2022 this seems a little outdated and iked has had proper support for EC keys for quite some time now, so I propose we switch to P-256 ECDSA keys by default. It looks like isakmpd

Re: rename ifm_status in struct ifmedia

2022-07-09 Thread Vitaliy Makkoveev
ok mvs@ > On 9 Jul 2022, at 22:23, Alexander Bluhm wrote: > > Hi, > > ifm_status name is used twice in struct ifmediareq and ifmedia. > > net/if.h: uint64_tifm_status; /* media status */ > net/if_media.h: ifm_stat_cb_t ifm_status; /* media status driver > callb

Re: pppoe(4): fix the 'SIOCSIFMTU' ioctl(2) error path

2022-07-09 Thread Alexander Bluhm
On Sat, Jul 09, 2022 at 10:16:02PM +0300, Vitaliy Makkoveev wrote: > We set the `error' but we forgot to return it and continue to > sppp_ioctl(). This bug was introduced in rev 1.51. OK bluhm@ > Index: sys/net/if_pppoe.c > === > RC

rename ifm_status in struct ifmedia

2022-07-09 Thread Alexander Bluhm
Hi, ifm_status name is used twice in struct ifmediareq and ifmedia. net/if.h: uint64_tifm_status; /* media status */ net/if_media.h: ifm_stat_cb_t ifm_status; /* media status driver callback */ Can we rename one of them? Makes reading the code and grepping easie

pppoe(4): fix the 'SIOCSIFMTU' ioctl(2) error path

2022-07-09 Thread Vitaliy Makkoveev
We set the `error' but we forgot to return it and continue to sppp_ioctl(). Index: sys/net/if_pppoe.c === RCS file: /cvs/src/sys/net/if_pppoe.c,v retrieving revision 1.81 diff -u -p -r1.81 if_pppoe.c --- sys/net/if_pppoe.c 29 Jun 202

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

2022-07-09 Thread Alexander Bluhm
On Sat, Jul 09, 2022 at 06:04:04PM +0300, Vitaliy Makkoveev wrote: > Sorry, I sent the previous diff again. There is the right one. OK bluhm@ > Index: sys/net/pipex.c > === > RCS file: /cvs/src/sys/net/pipex.c,v > retrieving revision

Re: ftp(1) connection timeouts and hostnames with multiple addresses

2022-07-09 Thread Todd C . Miller
Instead of the existing alarm() mechanism, how about using timeout_connect() from usr.bin/nc/netcat.c? - todd

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

2022-07-09 Thread Vitaliy Makkoveev
On Sat, Jul 09, 2022 at 10:46:56PM +0900, YASUOKA Masahiko wrote: > Hello, > > On Sat, 9 Jul 2022 01:43:41 +0300 > Vitaliy Makkoveev wrote: > > On Sat, Jul 09, 2022 at 12:08:49AM +0300, Vitaliy Makkoveev wrote: > >> Thanks for pointing. > >> > >> > On 8 Jul 2022, at 23:13, Alexander Bluhm wrote

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

2022-07-09 Thread YASUOKA Masahiko
Hello, On Sat, 9 Jul 2022 01:43:41 +0300 Vitaliy Makkoveev wrote: > On Sat, Jul 09, 2022 at 12:08:49AM +0300, Vitaliy Makkoveev wrote: >> Thanks for pointing. >> >> > On 8 Jul 2022, at 23:13, Alexander Bluhm wrote: >> > >> > On Fri, Jul 08, 2022 at 05:42:23PM +0300, Vitaliy Makkoveev wrote: >>

Re: vldcp(4): Add missing device_unref() calls

2022-07-09 Thread Mark Kettenis
> Date: Sat, 9 Jul 2022 13:47:18 + > From: Visa Hankala > > Add missing device_unref() calls to vldcpkqfilter(). > > The knote that vldcpkqfilter() sets up does not take a device reference. > > OK? looks correct to me. ok kettenis@ > Index: arch/sparc64/dev/vldcp.c >

vldcp(4): Fix event filters

2022-07-09 Thread Visa Hankala
vldcp(4)'s read and write event filters have a discrepancy relative to the old poll code. They should report non-activeness when the condition (err == 0 && state == LDC_CHANNEL_UP && head != tail) is false. Now they can return a stale value, causing a spurious wakeup of kevent/poll/select. This can

vldcp(4): Add missing device_unref() calls

2022-07-09 Thread Visa Hankala
Add missing device_unref() calls to vldcpkqfilter(). The knote that vldcpkqfilter() sets up does not take a device reference. OK? Index: arch/sparc64/dev/vldcp.c === RCS file: src/sys/arch/sparc64/dev/vldcp.c,v retrieving revision 1

Re: pppoe(4): reorder interface destruction and initialization

2022-07-09 Thread Bjorn Ketelaars
On Tue 05/07/2022 21:15, Vitaliy Makkoveev wrote: > pppoe_timeout() and pppoe_clone_destroy() are both executed with kernel > lock held, but they are not serialized because pppoe_timeout() has the > sleep point provided by netlock. We should use timeout_del_barrier(9) to > ensure pppoe_timeout() fi

ftp(1) connection timeouts and hostnames with multiple addresses

2022-07-09 Thread Stuart Henderson
I'm trying to teach ftp(1) to do something like gui web browsers do and reduce the HTTP/HTTPS connection timeout from the default (75 seconds) if there are multiple addresses behind a hostname. There's an existing connection timeout mechanism that I thought it might make sense to reuse... -w

Re: Build and install llvm-readelf (and llvm-readobj)

2022-07-09 Thread Mark Kettenis
> From: Jeremie Courreges-Anglas > Date: Sat, 09 Jul 2022 13:02:57 +0200 > > On riscv64 I miss having a usable readelf. We could just build > llvm-readelf instead. The actual tool is called llvm-readobj, with > GNU compat when called under the llvm-readelf or readelf names. > > People will pro

Build and install llvm-readelf (and llvm-readobj)

2022-07-09 Thread Jeremie Courreges-Anglas
On riscv64 I miss having a usable readelf. We could just build llvm-readelf instead. The actual tool is called llvm-readobj, with GNU compat when called under the llvm-readelf or readelf names. People will probably find this useful on arm64 and powerpc64 too. This shouldn't have a negative im

Re: tcpdump: Explicitly set the default value for Bflag

2022-07-09 Thread Klemens Nanni
On Sat, Jul 09, 2022 at 01:44:10AM +0200, Alexander Hall wrote: > We currently do not explicitly set the value for Bflag. Since it's > a static variable it is initialized to 0, which just so conveniently > happen to match the default constant. > > So, this is technically a no-op since the value of

Re: pppoe(4): reorder interface destruction and initialization

2022-07-09 Thread Klemens Nanni
On Tue, Jul 05, 2022 at 09:15:48PM +0300, Vitaliy Makkoveev wrote: > pppoe_timeout() and pppoe_clone_destroy() are both executed with kernel > lock held, but they are not serialized because pppoe_timeout() has the > sleep point provided by netlock. We should use timeout_del_barrier(9) to > ensure p