Re: bgpd kroute_node cleanup

On Wed, Jun 22, 2022 at 06:17:30PM +0200, Claudio Jeker wrote: > Diff is huge but mostly mechanical. Remove kroute_node, kroute6_node and > use struct kroute and kroute6 directly. Also do a similar dance for > struct knexthop_node. Went over it three times carefully and can't spot anything wrong.

bgpd kroute_node cleanup

Diff is huge but mostly mechanical. Remove kroute_node, kroute6_node and use struct kroute and kroute6 directly. Also do a similar dance for struct knexthop_node. I left kredist_node and kif_node for now since this diff is already large enough. -- :wq Claudio Index: bgpd.h ==

Re: bgpd move struct kroute definition to kroute.c

On Wed, Jun 22, 2022 at 05:00:38PM +0200, Claudio Jeker wrote: > Both struct kroute and struct kroute6 are no longer used outside of > kroute.c. As a first step move the definitions over to that file. > More will follow :) ok tb

bgpd move struct kroute definition to kroute.c

Both struct kroute and struct kroute6 are no longer used outside of kroute.c. As a first step move the definitions over to that file. More will follow :) -- :wq Claudio ? obj ? test ? test.c Index: bgpd.h === RCS file: /cvs/src/usr

Re: bgpd use struct kroute_full for bgpd_filternexthop

On Wed, Jun 22, 2022 at 04:46:41PM +0200, Claudio Jeker wrote: > Instead of passing either a struct kroute or struct kroute6 pointer > use kr_tofull() and use struct kroute_full. This makes the code in > bgpd_filternexthop() a lot cleaner. Nice. ok tb

bgpd use struct kroute_full for bgpd_filternexthop

Instead of passing either a struct kroute or struct kroute6 pointer use kr_tofull() and use struct kroute_full. This makes the code in bgpd_filternexthop() a lot cleaner. -- :wq Claudio Index: bgpd.c === RCS file: /cvs/src/usr.sbin/

Re: bgpd/bgpctl use struct kroute_full in nexthop messages

On Wed, Jun 22, 2022 at 04:37:44PM +0200, Theo Buehler wrote: > On Wed, Jun 22, 2022 at 04:13:43PM +0200, Claudio Jeker wrote: > > Do not leak the address family specific struct kroute into bgpctl if there > > is struct kroute_full which is address family independent. > > The result is mostly minus

Re: bgpd/bgpctl use struct kroute_full in nexthop messages

On Wed, Jun 22, 2022 at 04:13:43PM +0200, Claudio Jeker wrote: > Do not leak the address family specific struct kroute into bgpctl if there > is struct kroute_full which is address family independent. > The result is mostly minus because the code no longer needs address family > specific code paths

Bug in iked

Dear OpenBSD developers I would like to report an error in iked. The error occurs with the processing logic in case of simultaneous Child SA rekeying. That is, by simultaneous rekeying, two Child SAs are created and “the SA created with the lowest of the four nonces used in the two exchan

bgpd/bgpctl use struct kroute_full in nexthop messages

Do not leak the address family specific struct kroute into bgpctl if there is struct kroute_full which is address family independent. The result is mostly minus because the code no longer needs address family specific code paths. This changes 'bgpctl show nexthop' but not its output. OK? -- :wq

Re: pipex(4): protect global lists with mutex(9)

Please drop previous diff. counters_read(9) could sleep, so we can't call it with mutex(9) held. The diff below still uses `pipex_list_mtx' mutex(9) for pipex(4) lists protection, but for safe `session' dereference it user reference counters. Index: sys/net/if_ethersubr.c

Re: netstart(8): don't lie

On Tue, Jun 21, 2022 at 07:07:25AM +0100, Stuart Henderson wrote: > any comments? does it need a "does not clear things" caveat? ok? OK kn as-is