Re: Change behaviour of vis(3) in syslogd concerning backslash escaping

2022-06-03 Thread Theo de Raadt
Ted Unangst wrote: > I think not. If you intentionally store binary data in syslog (why?) you can > use > base64. The vis call is to prevent harm, not guarantee it's unambiguous. > Lots of potential syslog calls are already ambiguous if the user provides > inputs containing spaces. A structured

Re: Change behaviour of vis(3) in syslogd concerning backslash escaping

2022-06-03 Thread Ted Unangst
On 2022-06-02, Theo de Raadt wrote: But please consider this impact of the change you propose. > > There is one additional flag, VIS_NOSLASH, which inhibits the doubling of > backslashes and the backslash before the default format (that is, control > characters are represented by `

Re: bgpd: cleanup fib_priority

2022-06-03 Thread Theo Buehler
On Fri, Jun 03, 2022 at 03:33:57PM +0200, Claudio Jeker wrote: > fib_priority was slapped into the code by passing it around all the time. > It is much smarter to use a global value in kr_state for the fib_prio and > then tag F_BGP_INSERTED routes with RTP_MINE (0xff) which is an impossible > RTP v

bgpd: cleanup fib_priority

2022-06-03 Thread Claudio Jeker
fib_priority was slapped into the code by passing it around all the time. It is much smarter to use a global value in kr_state for the fib_prio and then tag F_BGP_INSERTED routes with RTP_MINE (0xff) which is an impossible RTP value. With that changing the prio requires "only" a fib decouple, chang