Re: igc checksum offloading

2022-05-25 Thread Moritz Buhl
On Wed, May 25, 2022 at 04:18:00PM +0200, Moritz Buhl wrote: > Dear tech@, > > The attached diff should handle checksum offloading for igc(4) > for IPv4, TCP, and UDP. > > I tested with "Intel I225-LM" rev 0x03, > kevlo@ tested this with "Intel I225-V" rev 0x03 > > OK? The diff doesn't look rig

Re: bgpd implement max-communities filter

2022-05-25 Thread Theo Buehler
On Wed, May 25, 2022 at 07:09:04PM +0200, Claudio Jeker wrote: > This introduces max-communities, max-ext-communities and > max-large-communities for filters which allows to limit the number of > communities in a path. > > The 3 filters can all be used together and also with other match filters >

bgpd implement max-communities filter

2022-05-25 Thread Claudio Jeker
This introduces max-communities, max-ext-communities and max-large-communities for filters which allows to limit the number of communities in a path. The 3 filters can all be used together and also with other match filters including community X:Y. -- :wq Claudio Index: bgpd.conf.5 ==

Re: bgpd fix for non-transitive extended communities

2022-05-25 Thread Theo Buehler
On Wed, May 25, 2022 at 04:27:46PM +0200, Claudio Jeker wrote: > On Wed, May 25, 2022 at 03:50:38PM +0200, Theo Buehler wrote: > > On Wed, May 25, 2022 at 02:46:55PM +0200, Claudio Jeker wrote: > > > Noticed this morning working on something else. The non-transitive > > > extended community support

tcpudmp: no more AS_DOT encoding in bgp output

2022-05-25 Thread Claudio Jeker
Long long ago it was considered chique to use AS_DOT to write 4-byte AS numbers. Like 3.10 instead of 196618. tcpdump also followed this trend but then the world switched to AS_PLAIN so did bgpd. It is time for tcpdump to follow. Now the ugly bit about the ASPATH attribute is that it is not known

Re: bgpd fix for non-transitive extended communities

2022-05-25 Thread Claudio Jeker
On Wed, May 25, 2022 at 03:50:38PM +0200, Theo Buehler wrote: > On Wed, May 25, 2022 at 02:46:55PM +0200, Claudio Jeker wrote: > > Noticed this morning working on something else. The non-transitive > > extended community support is fairly messed up. In my case (set > > ext-community rt 1:1) it caus

igc checksum offloading

2022-05-25 Thread Moritz Buhl
Dear tech@, The attached diff should handle checksum offloading for igc(4) for IPv4, TCP, and UDP. I tested with "Intel I225-LM" rev 0x03, kevlo@ tested this with "Intel I225-V" rev 0x03 OK? Index: /sys/dev/pci/if_igc.c === RCS fil

Re: tcpdump: add RFC9234 "BGP Role" support

2022-05-25 Thread Claudio Jeker
On Tue, May 24, 2022 at 08:12:25PM +, Job Snijders wrote: > Hi all, > > I based this off reading https://datatracker.ietf.org/doc/html/rfc9234 > > This code is untested! I haven't had a chance yet to tcpdump a RFC 9234 > capable BGP speaker. There might be some out there, according to > https

Re: bgpd fix for non-transitive extended communities

2022-05-25 Thread Theo Buehler
On Wed, May 25, 2022 at 02:46:55PM +0200, Claudio Jeker wrote: > Noticed this morning working on something else. The non-transitive > extended community support is fairly messed up. In my case (set > ext-community rt 1:1) it causes the community to be skipped. > > First of all the check in non_tra

bgpd fix for non-transitive extended communities

2022-05-25 Thread Claudio Jeker
Noticed this morning working on something else. The non-transitive extended community support is fairly messed up. In my case (set ext-community rt 1:1) it causes the community to be skipped. First of all the check in non_transitive_community() is messed up. It uses the wrong data field, does a un