Re: Unlock umask(2)

> On 13 May 2022, at 00:02, Alexander Bluhm wrote: > > On Wed, May 11, 2022 at 11:20:15AM +0300, Vitaliy Makkoveev wrote: >> sys_umask() only modifies `fd_cmask', which modification is already >> protected by `fd_lock' rwlock(9). > > I did run full regress on amd64. > > OK bluhm@ > Thanks! I’

Re: changelist: add /etc/login.conf.d/*

Hello, I take this is an ok by deraadt@ Regards, Raf On Thu, May 12, 2022 at 01:40:40PM BST, Theo de Raadt wrote: > Yep > > Raf Czlonka wrote: > > > On Thu, May 12, 2022 at 11:58:22AM BST, Stuart Henderson wrote: > > > changelist already has /etc/login.conf, but I think files in the .d > > >

libcrypto/err_prn.c: skip BIO*

Hi As far as I can tell, this ends up calling vprintf eventually, so skip the steps inbetween. Best, Martin Index: err_prn.c === RCS file: /home/reposync/cvs/src/lib/libcrypto/err/err_prn.c,v retrieving revision 1.19 diff -u -p -r1

Re: rpki-client: ASN.1 bit string flag errors

On Thu, May 12, 2022 at 07:44:51PM +0200, Theo Buehler wrote: > ip_addr_parse() sticks its fingers into undocumented API surface of > libcrypto. What is true is that the unused bit count is in the lower > three bits of p->flags, provided that ASN1_STRING_FLAG_BITS_LEFT is set. > This is "documented

apply(1): constify two arguments

Index: apply.c === RCS file: /cvs/src/usr.bin/apply/apply.c,v retrieving revision 1.29 diff -u -p -r1.29 apply.c --- apply.c 1 Apr 2018 17:45:05 - 1.29 +++ apply.c 12 May 2022 21:14:04 - @@ -54,7 +54,7 @@ char *s

Re: Unlock umask(2)

On Wed, May 11, 2022 at 11:20:15AM +0300, Vitaliy Makkoveev wrote: > sys_umask() only modifies `fd_cmask', which modification is already > protected by `fd_lock' rwlock(9). I did run full regress on amd64. OK bluhm@ > Index: sys/kern/syscalls.master >

rpki-client: ASN.1 bit string flag errors

ip_addr_parse() sticks its fingers into undocumented API surface of libcrypto. What is true is that the unused bit count is in the lower three bits of p->flags, provided that ASN1_STRING_FLAG_BITS_LEFT is set. This is "documented" in asn1.h #define ASN1_STRING_FLAG_BITS_LEFT 0x08 /* Set if 0x07 h

Re: uvm_pagedequeue()

On 10/05/22(Tue) 20:23, Mark Kettenis wrote: > > Date: Tue, 10 May 2022 18:45:21 +0200 > > From: Martin Pieuchot > > > > On 05/05/22(Thu) 14:54, Martin Pieuchot wrote: > > > Diff below introduces a new wrapper to manipulate active/inactive page > > > queues. > > > > > > ok? > > > > Anyone? >

Re: changelist: add /etc/login.conf.d/*

On Thu, May 12, 2022 at 11:58:22AM BST, Stuart Henderson wrote: > changelist already has /etc/login.conf, but I think files in the .d > directory should be checked too, both so we have notification of changes > (as it can set environment variables this is a very powerful file), and > also so we kee

changelist: add /etc/login.conf.d/*

changelist already has /etc/login.conf, but I think files in the .d directory should be checked too, both so we have notification of changes (as it can set environment variables this is a very powerful file), and also so we keep old versions in /var/backup. ok? Index: changelist =

Re: Unlock umask(2)

On Wed, May 11, 2022 at 11:41:18PM +0300, Vitaliy Makkoveev wrote: > > Both of the resizes should happen first, in case there is fallout in > > userland which isn't visible yet. > > No problem. OK bluhm@ > Index: sys/sys/filedesc.h > =

Re: rpki-client: fewer reallocarrays() for IPAddrBlocks

On Thu, May 12, 2022 at 11:27:21AM +0200, Theo Buehler wrote: > This aligns sbgp_ipaddrblk() with sbgp_assysnum(), giving it a similar > treatment. We trade the reallocarray() per prefix or range with at most > two recallocarray(). I took the liberty of trimming some RFC section > numbers in warnin

rpki-client: fewer reallocarrays() for IPAddrBlocks

This aligns sbgp_ipaddrblk() with sbgp_assysnum(), giving it a similar treatment. We trade the reallocarray() per prefix or range with at most two recallocarray(). I took the liberty of trimming some RFC section numbers in warnings to avoid awkward line wrapping. Index: cert.c

Re: rpki-client: clean up ip handling in cert.c

On Thu, May 12, 2022 at 10:17:30AM +0200, Theo Buehler wrote: > Before refactoring the IP side, let's streamline the code a little. > Populate struct ip in the leaf functions instead of handing it through > several layers and copying it along the way. Pass in the afi instead of > letting struct ip

rpki-client: clean up ip handling in cert.c

Before refactoring the IP side, let's streamline the code a little. Populate struct ip in the leaf functions instead of handing it through several layers and copying it along the way. Pass in the afi instead of letting struct ip carry it. Index: cert.c =