On Tue, May 10, 2022 at 08:38:32AM +0200, Theo Buehler wrote:
> On Tue, May 10, 2022 at 08:28:10AM +0200, Claudio Jeker wrote:
> > On Tue, May 10, 2022 at 08:05:00AM +0200, Theo Buehler wrote:
> > > This moves valid_filename() to validate.c and splits out a helper
> > > portable_filename() which ca
On Tue, May 10, 2022 at 08:28:10AM +0200, Claudio Jeker wrote:
> On Tue, May 10, 2022 at 08:05:00AM +0200, Theo Buehler wrote:
> > This moves valid_filename() to validate.c and splits out a helper
> > portable_filename() which can be used from the RSC code. While moving
> > valid_filename() is not
On Tue, May 10, 2022 at 08:05:00AM +0200, Theo Buehler wrote:
> This moves valid_filename() to validate.c and splits out a helper
> portable_filename() which can be used from the RSC code. While moving
> valid_filename() is not necessary, I thought it makes sense to keep the
> two functions next t
This moves valid_filename() to validate.c and splits out a helper
portable_filename() which can be used from the RSC code. While moving
valid_filename() is not necessary, I thought it makes sense to keep the
two functions next to each other.
I could not find a short name with valid_ prefix for po
Hello,
On Tue, May 10, 2022 at 12:18:15AM +0200, Alexander Bluhm wrote:
> On Mon, May 09, 2022 at 11:11:03PM +0200, Alexandr Nedvedicky wrote:
> > > ... and then we insert a destroyed p
> >
> > yes. you are right. new diff addresses that with change as follows:
> >
> > @@ -1542,9 +1542,8 @@ pf
On Mon, May 09, 2022 at 11:11:03PM +0200, Alexandr Nedvedicky wrote:
> > ... and then we insert a destroyed p
>
> yes. you are right. new diff addresses that with change as follows:
>
> @@ -1542,9 +1542,8 @@ pfr_add_tables(struct pfr_table ...)
> pfr_destroy_
On 2022/05/09 23:16, Alexandr Nedvedicky wrote:
> Hello,
>
> I'm sorry I was too fast with commit. I've just committed
> what's been suggested by bluhm@:
That's totally ok, my diff is on top and wasn't written until you
committed yours :-)
> @@ -2186,6 +2186,7 @@ It cannot be used with
>
On Mon, May 09, 2022 at 10:08:24PM +0100, Stuart Henderson wrote:
> This is helpful, but because it's so surprising that "pass proto icmp"
> doesn't pass all icmp traffic, I think it would help to mention it where
> "proto icmp" is described too.
>
> Also, the top of the text about "sloppy" just t
Hello,
I'm sorry I was too fast with commit. I've just committed
what's been suggested by bluhm@:
@@ -2186,6 +2186,7 @@ It cannot be used with
.Cm modulate state
or
.Cm synproxy state .
+With this option ICMP replies can create states.
.It Ar timeout seconds
Chang
Hello,
thanks for taking a look.
> > + SLIST_FOREACH(q, &auxq, pfrkt_workq) {
> > + if (!pfr_ktable_compare(p, q)) {
> > + /*
> > +* We need no lock here, because `p` is empty,
> > +* th
This is helpful, but because it's so surprising that "pass proto icmp"
doesn't pass all icmp traffic, I think it would help to mention it where
"proto icmp" is described too.
Also, the top of the text about "sloppy" just talks about the sloppy
TCP connection tracker, I think perhaps it would be be
On Mon, May 09, 2022 at 10:42:29AM -0600, Theo de Raadt wrote:
> Martin Vahlensieck wrote:
>
> > if (!qflag) {
> > - fprintf(stderr, "Identity removed: %s %s (%s)\n", path,
> > - sshkey_type(key), comment);
> > + fprintf(stderr, "Identity removed: %s %s%s%s%s
On Sun, May 08, 2022 at 06:15:49PM +0200, Alexandr Nedvedicky wrote:
> OK ?
3 comments inline
> 8<---8<---8<--8<
> diff --git a/sys/net/pf_ioctl.c b/sys/net/pf_ioctl.c
> index 8315b115474..1f036e1368f 100644
> --- a/sys/net/pf_ioctl.c
> +++
Martin Vahlensieck wrote:
> if (!qflag) {
> - fprintf(stderr, "Identity removed: %s %s (%s)\n", path,
> - sshkey_type(key), comment);
> + fprintf(stderr, "Identity removed: %s %s%s%s%s\n", path,
> + sshkey_type(key), comment ? " (" : "
Hi
When removing an identity from the agent using the private key file,
ssh-add first tries to find the public key file. If that fails,
it loads the public key from the private key file, but no comment
is loaded. This means comment is NULL when it is used inside
delete_one to print `Identity rem
Hello,
On Mon, May 09, 2022 at 04:34:00PM +0200, Alexander Bluhm wrote:
> On Sun, May 08, 2022 at 10:54:01PM +0200, Alexandr Nedvedicky wrote:
> > what bothers me is the situation where there are
> > more than one reader. The line 350 is executed by
> > the first reader which drops the
On Mon, May 09, 2022 at 05:08:53PM +0200, Theo Buehler wrote:
> On Mon, May 09, 2022 at 02:59:06PM +0200, Claudio Jeker wrote:
> > On Mon, May 09, 2022 at 12:53:05PM +0200, Theo Buehler wrote:
> > > Regarding the spec:
> > >
> > > * isn't it a bit unfortunate that the ResourceBlock contains an
>
On Mon, May 09, 2022 at 01:07:17PM +, Job Snijders wrote:
> On Mon, May 09, 2022 at 12:11:22PM +0200, Claudio Jeker wrote:
> > why does the draft allow for optional filenames? What the heck is the
> > digest then covering some random gunk?
>
> Yes, that is entirely possible. Some folks in the
On Mon, May 09, 2022 at 02:59:06PM +0200, Claudio Jeker wrote:
> On Mon, May 09, 2022 at 12:53:05PM +0200, Theo Buehler wrote:
> > Regarding the spec:
> >
> > * isn't it a bit unfortunate that the ResourceBlock contains an ipAddrBlocks
> > member which isn't an IPAddrBlocks as in RFC 3779 but ra
On Mon, May 09, 2022 at 01:07:17PM +, Job Snijders wrote:
> On Mon, May 09, 2022 at 12:11:22PM +0200, Claudio Jeker wrote:
> > why does the draft allow for optional filenames? What the heck is the
> > digest then covering some random gunk?
>
> Yes, that is entirely possible. Some folks in the
On Sun, May 08, 2022 at 10:54:01PM +0200, Alexandr Nedvedicky wrote:
> what bothers me is the situation where there are
> more than one reader. The line 350 is executed by
> the first reader which drops the lock. So the process
> woken up by wakeup(rwl) are going to find out the
>
tech@,
Another vmm/vmd update: fix `vmctl receive` on Intel hosts by adding
another fault enum value to disambiguate fault reasons.
It's expected that the guest will trigger nested page faults after being
received by vmd. When you connect to the vm using `vmctl console` and
interact with the gues
This patch adds support for AX210/AX211 devices to iwx(4).
While this patch attempts to make a couple of devices work which
are part of this device family, so far only one specific AX210
device has been tested:
iwx0 at pci4 dev 0 function 0 "Intel Wi-Fi 6 AX210" rev 0x1a, msix
iwx0: hw rev 0x420,
On Mon, May 09, 2022 at 12:11:22PM +0200, Claudio Jeker wrote:
> why does the draft allow for optional filenames? What the heck is the
> digest then covering some random gunk?
Yes, that is entirely possible. Some folks in the working group
requested the filename to be optional, I abided. In inter-
On Mon, May 09, 2022 at 12:53:05PM +0200, Theo Buehler wrote:
> > As the various same-named-but-different 'parse' structs are not easily
> > interchangeable without more refactoring, I marked them "XXX:". Perhaps
> > we can work on that in tree?
>
> I'm fine with fixing that in-tree. Sorry about t
On 05/05/22(Thu) 10:56, Bob Beck wrote:
> On Thu, May 05, 2022 at 10:16:23AM -0600, Bob Beck wrote:
> > Ugh. You???re digging in the most perilous parts of the pile.
> >
> > I will go look with you??? sigh. (This is not yet an ok for that.)
> >
> > > On May 5, 2022, at 7:53 AM, Martin Pieuchot
> As the various same-named-but-different 'parse' structs are not easily
> interchangeable without more refactoring, I marked them "XXX:". Perhaps
> we can work on that in tree?
I'm fine with fixing that in-tree. Sorry about this mistake, I made it
many times. I wish the various 'struct parse' wer
On Sun, May 08, 2022 at 08:05:08PM +, Job Snijders wrote:
> Dear Theo, fellow developers,
>
> Many thanks for the first review pass, much appreciated.
>
> > This is a good first step. I have a few initial comments inline. Once you
> > fix
> > those, review of the rest will be easier.
> >
>
28 matches
Mail list logo
