Re: xenodm and login_fbtab

2022-04-20 Thread Jonathan Gray
On Wed, Apr 20, 2022 at 05:17:58PM -0500, joshua stein wrote: > xenodm supports login_fbtab(3) to chown devices but it currently > doesn't do anything because /etc/fbtab does not list /dev/ttyC4. It > uses the GiveConsole and TakeConsole scripts in /etc/X11/xenodm/ to > do this manually, but th

xenodm and login_fbtab

2022-04-20 Thread joshua stein
xenodm supports login_fbtab(3) to chown devices but it currently doesn't do anything because /etc/fbtab does not list /dev/ttyC4. It uses the GiveConsole and TakeConsole scripts in /etc/X11/xenodm/ to do this manually, but the file lists are not complete. I would like to remove all of the cust

Re: [External] : Re: pfsync(4) snapshot lists must have dedicated link element

2022-04-20 Thread Alexandr Nedvedicky
Hello, On Wed, Apr 20, 2022 at 03:43:06PM +0200, Alexander Bluhm wrote: > On Sat, Apr 09, 2022 at 01:51:05AM +0200, Alexandr Nedvedicky wrote: > > updated diff is below. > > I am not sure what Hrvoje actually did test and what not. My > impression was, that he got a panic with the previous versi

Re: rpki-client factor out the filemode code

2022-04-20 Thread Claudio Jeker
On Wed, Apr 20, 2022 at 08:07:06PM +0200, Theo Buehler wrote: > On Wed, Apr 20, 2022 at 07:14:23PM +0200, Claudio Jeker wrote: > > The filemode code is enough different from the regular parser code that it > > makes sense to totally split it out. Only proc_parser_cert_validate() and > > proc_parser

Re: pfsync debug bye-bye

2022-04-20 Thread David Gwynne
> On 21 Apr 2022, at 02:14, Alexander Bluhm wrote: > > Hi, > > In pfsync there are some KASSERT hidden behind #ifdef PFSYNC_DEBUG. > That does not make sense to me. Either they are correct, then they > should actively check in production. Or they got wrong over time, > then they should not

Re: [External] : pfsync debug bye-bye

2022-04-20 Thread Alexandr Nedvedicky
Hello, On Wed, Apr 20, 2022 at 06:14:37PM +0200, Alexander Bluhm wrote: > Hi, > > In pfsync there are some KASSERT hidden behind #ifdef PFSYNC_DEBUG. > That does not make sense to me. Either they are correct, then they > should actively check in production. Or they got wrong over time, > then t

router timer mutex

2022-04-20 Thread Alexander Bluhm
Hi, mvs@ reminded me of a crash I have seen in December. Route timers are not MP safe, but I think this can be fixed with a mutex. The idea is to protect the global lists with a mutex and move the rttimer into a temporary list. Then the callback and pool put can be called later without mutex.

Re: rpki-client factor out the filemode code

2022-04-20 Thread Theo Buehler
On Wed, Apr 20, 2022 at 07:14:23PM +0200, Claudio Jeker wrote: > The filemode code is enough different from the regular parser code that it > makes sense to totally split it out. Only proc_parser_cert_validate() and > proc_parser_root_cert() had to be duplicated which is IMO acceptable. I'm not a

rpki-client factor out the filemode code

2022-04-20 Thread Claudio Jeker
The filemode code is enough different from the regular parser code that it makes sense to totally split it out. Only proc_parser_cert_validate() and proc_parser_root_cert() had to be duplicated which is IMO acceptable. The valid_x509() plus static functions are moved to validate.c. The crl_tree co

pfsync debug bye-bye

2022-04-20 Thread Alexander Bluhm
Hi, In pfsync there are some KASSERT hidden behind #ifdef PFSYNC_DEBUG. That does not make sense to me. Either they are correct, then they should actively check in production. Or they got wrong over time, then they should not make debugging harder. Some basic testing did not show problems. ok?

Re: amdgpio(4) : preserve pin configuration on resume

2022-04-20 Thread Mike Larkin
On Wed, Apr 20, 2022 at 11:39:00AM +0200, Mark Kettenis wrote: > > Date: Tue, 19 Apr 2022 22:02:00 -0700 > > From: Mike Larkin > > > > On at least the Asus ROG Zephyrus 14 (2020), the trackpad fails to generate > > any interrupts after resume. I tracked this down to amdgpio(4) not > > generating

Re: login_fbtab glob

2022-04-20 Thread Todd C . Miller
On Wed, 20 Apr 2022 09:18:20 -0500, joshua stein wrote: > I like it. Here's the full diff: OK millert@ - todd

Re: login_fbtab glob

2022-04-20 Thread joshua stein
On Fri, 15 Apr 2022 at 18:54:49 -0600, Todd C. Miller wrote: > On Fri, 15 Apr 2022 13:28:33 -0500, joshua stein wrote: > > > Anyone want to bikeshed this language? > > I think it is more helpful to refer to glob(7) than glob(3). > Perhaps something like this. I like it. Here's the full diff:

Re: const openpty et al.

2022-04-20 Thread Todd C . Miller
On Tue, 19 Apr 2022 21:30:25 -0500, Matthew Martin wrote: > On Thu, Apr 07, 2022 at 06:11:45PM -0500, Matthew Martin wrote: > > const the termp and winp arguments for openpty and related. This matches > > the prototypes for openpty and forkpty in glibc and musl libc. > > ping; has an ok from tb@ [

Re: [External] : Re: pfsync(4) snapshot lists must have dedicated link element

2022-04-20 Thread Alexander Bluhm
On Sat, Apr 09, 2022 at 01:51:05AM +0200, Alexandr Nedvedicky wrote: > updated diff is below. I am not sure what Hrvoje actually did test and what not. My impression was, that he got a panic with the previous version of this diff, but the machine was stable with the code in current. But maybe I

Re: rpki-client: TZ=UTC + localtime -> gmtime?

2022-04-20 Thread Claudio Jeker
On Wed, Apr 20, 2022 at 03:00:15PM +0200, Theo Buehler wrote: > Found this when looking at the timezone issue a couple of weeks back and > then forgot about it: > > This setenv() + localtime() looks like a hack to me and I don't really > understand why it should be preferable over using gmtime() d

rpki-client: TZ=UTC + localtime -> gmtime?

2022-04-20 Thread Theo Buehler
Found this when looking at the timezone issue a couple of weeks back and then forgot about it: This setenv() + localtime() looks like a hack to me and I don't really understand why it should be preferable over using gmtime() directly. The only change in output that I can see is that it causes %Z t

Re: amdgpio(4) : preserve pin configuration on resume

2022-04-20 Thread Mark Kettenis
> Date: Tue, 19 Apr 2022 22:02:00 -0700 > From: Mike Larkin > > On at least the Asus ROG Zephyrus 14 (2020), the trackpad fails to generate > any interrupts after resume. I tracked this down to amdgpio(4) not generating > interrupts after resume, and started looking at missing soft state. > > Th

Re: route timer queues

2022-04-20 Thread Claudio Jeker
On Tue, Apr 19, 2022 at 10:49:44PM +0200, Alexander Bluhm wrote: > Hi, > > I had a look in route timer queues in netinet and netinet6 and found > some inconsistencies. > > - Timeout was a mixture of int, u_int and long. Make timeout > int with sysctl bounds checking and make absolute time time