Re: sshd_config(5): Use correct path for system-wide known_hosts

2022-04-11 Thread Darren Tucker
On Mon, 11 Apr 2022 at 16:12, Martin Vahlensieck wrote: > The path to the system-wide known_hosts file is /etc/ssh/ssh_known_hosts > and not /etc/ssh/known_hosts. See auth2-hostbased.c line 221-223. Applied, thanks. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 58

Re: ddb: simplify "machine" command handling

2022-04-11 Thread Jeremie Courreges-Anglas
On Mon, Apr 11 2022, Christian Weisgerber wrote: > Christian Weisgerber: > >> This will allow constifying the ddb command tables in a subsequent >> step. > > And here's that boring follow-up diff. sparc64 and riscv64 GENERIC and GENERIC.MP build successfully with this diff and the previous one, "

Re: rpki-client: extend -f to print TAL details

2022-04-11 Thread Claudio Jeker
On Mon, Apr 11, 2022 at 07:37:51PM +0200, Theo Buehler wrote: > On Mon, Apr 11, 2022 at 05:11:30PM +, Job Snijders wrote: > > On Mon, Apr 11, 2022 at 06:46:20PM +0200, Theo Buehler wrote: > > > Is this base64 blob really useful? The exact same thing is contained in > > > a more readable fashion

Re: rpki-client: extend -f to print TAL details

2022-04-11 Thread Theo Buehler
On Mon, Apr 11, 2022 at 05:11:30PM +, Job Snijders wrote: > On Mon, Apr 11, 2022 at 06:46:20PM +0200, Theo Buehler wrote: > > Is this base64 blob really useful? The exact same thing is contained in > > a more readable fashion (i.e. with line breaks) in the .tal file itself. > > OK, cat(1) can

Re: refcount btrace

2022-04-11 Thread Martin Pieuchot
On 08/04/22(Fri) 12:16, Alexander Bluhm wrote: > On Fri, Apr 08, 2022 at 02:39:34AM +, Visa Hankala wrote: > > On Thu, Apr 07, 2022 at 07:55:11PM +0200, Alexander Bluhm wrote: > > > On Wed, Mar 23, 2022 at 06:13:27PM +0100, Alexander Bluhm wrote: > > > > In my opinion tracepoints give insight a

Kill selrecord()

2022-04-11 Thread Martin Pieuchot
Now that poll(2) & select(2) use the kqueue backend under the hood we can start retiring the old machinery. The diff below does not touch driver definitions, however it : - kills selrecord() & doselwakeup() - make it obvious that `kern.nselcoll' is now always 0 - Change all poll/select hooks

Re: rpki-client: extend -f to print TAL details

2022-04-11 Thread Job Snijders
On Mon, Apr 11, 2022 at 06:46:20PM +0200, Theo Buehler wrote: > Is this base64 blob really useful? The exact same thing is contained in > a more readable fashion (i.e. with line breaks) in the .tal file itself. OK, cat(1) can also be used indeed :-) > Apart from that, I'm fine with having somethi

Re: rpki-client: extend -f to print TAL details

2022-04-11 Thread Theo Buehler
On Mon, Apr 11, 2022 at 04:05:27PM +, Job Snijders wrote: > Hi, > > This changeset extends rpki-client to print more detail encapsulated > inside TAL files, of specific interest is printing the Subject Key > Identifier (SKI) of the Trust Anchor you'd find if you download the > referenced .cer

rpki-client: extend -f to print TAL details

2022-04-11 Thread Job Snijders
Hi, This changeset extends rpki-client to print more detail encapsulated inside TAL files, of specific interest is printing the Subject Key Identifier (SKI) of the Trust Anchor you'd find if you download the referenced .cer file. The SPKI is printed as base64 encoded DER. Example: $ rpki-cli

Re: rpki-client refactor process startup

2022-04-11 Thread Theo Buehler
On Mon, Apr 11, 2022 at 04:43:33PM +0200, Claudio Jeker wrote: > rpki-client starts a few processes and it can do this a bit more elegant > by factoring the common code out into process_start(). This makes the code > in main a fair bit shorter. > > I decided to move all pledge calles into the indi

rpki-client refactor process startup

2022-04-11 Thread Claudio Jeker
rpki-client starts a few processes and it can do this a bit more elegant by factoring the common code out into process_start(). This makes the code in main a fair bit shorter. I decided to move all pledge calles into the individual processes. In my opinion there is little benefit in keeping them i

Re: ddb: simplify "machine" command handling

2022-04-11 Thread Christian Weisgerber
Christian Weisgerber: > This will allow constifying the ddb command tables in a subsequent > step. And here's that boring follow-up diff. M sys/arch/alpha/alpha/db_interface.c M sys/arch/amd64/amd64/db_interface.c M sys/arch/arm/arm/db_interface.c M sys/arch/arm64/arm64/db_interface.c M sy

Re: rpki-client: simplify SIA parsing

2022-04-11 Thread Claudio Jeker
On Mon, Apr 11, 2022 at 11:37:11AM +0200, Theo Buehler wrote: > This should be the last step. It inlines sbgp_sia_resource_entry() into > sbgp_sia() and dedups the sbgp_sia_resource_{notify,mft,carepo}() using > a new sbgp_sia_location(). Move the GEN_URI check to sbgp_sia_location() > since that s

Re: rpki-client: simplify SIA parsing

2022-04-11 Thread Theo Buehler
This should be the last step. It inlines sbgp_sia_resource_entry() into sbgp_sia() and dedups the sbgp_sia_resource_{notify,mft,carepo}() using a new sbgp_sia_location(). Move the GEN_URI check to sbgp_sia_location() since that seems cleaner. Index: cert.c =

Re: rpki-client: simplify SIA parsing

2022-04-11 Thread Claudio Jeker
On Mon, Apr 11, 2022 at 09:41:05AM +0200, Theo Buehler wrote: > On Sun, Apr 10, 2022 at 12:40:08PM +0200, Claudio Jeker wrote: > > This is a lot cleaner and indeed an improvement. I think some of the rc > > handling can also be simplified. The code in sbgp_sia_resource_entry() > > and sbgp_sia_reso

Re: rpki-client: simplify SIA parsing

2022-04-11 Thread Theo Buehler
On Sun, Apr 10, 2022 at 12:40:08PM +0200, Claudio Jeker wrote: > This is a lot cleaner and indeed an improvement. I think some of the rc > handling can also be simplified. The code in sbgp_sia_resource_entry() > and sbgp_sia_resource() no longer require cleanup on error so we can just > return 0 in