Re: fix very small ntpd leak

2022-03-23 Thread Otto Moerbeek
On Thu, Mar 24, 2022 at 10:34:52AM +1000, Jonathan Matthew wrote: > On Wed, Mar 23, 2022 at 04:59:06PM +0100, Otto Moerbeek wrote: > > On Wed, Mar 23, 2022 at 09:09:01PM +1000, Jonathan Matthew wrote: > > > > > We noticed that the ntpd engine process was getting a bit big on some > > > boxes > >

Re: sndio: add sio_flush() function

2022-03-23 Thread Alexandre Ratchov
On Thu, Mar 24, 2022 at 07:11:42AM +0100, Alexandre Ratchov wrote: > Most audio/video players do a stop/start cycle whenever the play > position is changed, track is changed, etc. Currently, stopping drains > the play buffer, which by default is very large (to workaround very > long kernel non-pree

sndio: add sio_flush() function

2022-03-23 Thread Alexandre Ratchov
Most audio/video players do a stop/start cycle whenever the play position is changed, track is changed, etc. Currently, stopping drains the play buffer, which by default is very large (to workaround very long kernel non-preemptive code-paths). This makes player controls sluggish. This diff adds a

Re: fix very small ntpd leak

2022-03-23 Thread Jonathan Matthew
On Wed, Mar 23, 2022 at 04:59:06PM +0100, Otto Moerbeek wrote: > On Wed, Mar 23, 2022 at 09:09:01PM +1000, Jonathan Matthew wrote: > > > We noticed that the ntpd engine process was getting a bit big on some boxes > > that we'd accidentally cut off from the ntp servers (routing is hard). > > Readin

kernel panic from scsi_get_target_luns

2022-03-23 Thread jungle Boogie
Hi, I don't see this reported, but I may have overlooked it. From this morning's snapshot, I'm getting a panic on reboot. This is happening on at least one of my machines, possibly two, but I don't have serial access to the other to confirm. ddb{0}> bt scsi_detach_link(8011a500,1,1e6a129

Re: clang: compile static analyzer

2022-03-23 Thread Joerg Sonnenberger
Am Fri, Jan 21, 2022 at 12:45:56AM +0100 schrieb Steffen Nurpmeso: > Fwiw, i have been astonished by this thread. I found scan-build > to generate a lot of false warnings, so much indeed that i stopped > using it .. in summer 2017. I've spend time on the static analyzer output in NetBSD and I wou

Re: refcount btrace

2022-03-23 Thread Alexander Bluhm
On Mon, Mar 21, 2022 at 01:22:22PM +0100, Martin Pieuchot wrote: > On 20/03/22(Sun) 05:39, Visa Hankala wrote: > > On Sat, Mar 19, 2022 at 12:10:11AM +0100, Alexander Bluhm wrote: > > > On Thu, Mar 17, 2022 at 07:25:27AM +, Visa Hankala wrote: > > > > On Thu, Mar 17, 2022 at 12:42:13AM +0100, A

Re: clang: compile static analyzer

2022-03-23 Thread Steffen Nurpmeso
Hello. Steffen Nurpmeso wrote in <20220121154612.frou2%stef...@sdaoden.eu>: |Andre Smagin wrote in | <20220120231806.0463e0c792db3e3e5fc07...@smagin.com>: ||On Fri, 21 Jan 2022 00:45:56 +0100 ||Steffen Nurpmeso wrote: ||> I found scan-build to generate a lot of false warnings, so much indee

Re: fix very small ntpd leak

2022-03-23 Thread Todd C . Miller
On Wed, 23 Mar 2022 16:59:06 +0100, Otto Moerbeek wrote: > This is a bug that dlg reported last week. Serendepity or not? :-) > > This is my diff that uses an approach I like a litle bit better. Since client_peer_init() is always called after new_peer() there's no reason I can see for query to be

Re: fix very small ntpd leak

2022-03-23 Thread Otto Moerbeek
On Wed, Mar 23, 2022 at 09:09:01PM +1000, Jonathan Matthew wrote: > We noticed that the ntpd engine process was getting a bit big on some boxes > that we'd accidentally cut off from the ntp servers (routing is hard). > Reading through the code, I noticed the 'query' member of struct ntp_peer > is

Re: [External] : pfioctl goto fail

2022-03-23 Thread Alexandr Nedvedicky
On Wed, Mar 23, 2022 at 03:53:21PM +0100, Alexander Bluhm wrote: > Hi, > > pfioctl() is inconsistent when to use break or goto fail. There > is a big switch and when looking at a break you need more context > to see where it jumps to. > > I would like to use goto fail consistently to leave the b

Re: pfioctl goto fail

2022-03-23 Thread Todd C . Miller
On Wed, 23 Mar 2022 15:53:21 +0100, Alexander Bluhm wrote: > Hi, > is a big switch and when looking at a break you need more context > to see where it jumps to. > > I would like to use goto fail consistently to leave the big switch. > break is used for inner switches and loops. This makes it easi

Re: fix very small ntpd leak

2022-03-23 Thread Alexander Bluhm
On Wed, Mar 23, 2022 at 09:09:01PM +1000, Jonathan Matthew wrote: > We noticed that the ntpd engine process was getting a bit big on some boxes > that we'd accidentally cut off from the ntp servers (routing is hard). > Reading through the code, I noticed the 'query' member of struct ntp_peer > is n

pfioctl goto fail

2022-03-23 Thread Alexander Bluhm
Hi, pfioctl() is inconsistent when to use break or goto fail. There is a big switch and when looking at a break you need more context to see where it jumps to. I would like to use goto fail consistently to leave the big switch. break is used for inner switches and loops. No binary diff. ok? b

fix very small ntpd leak

2022-03-23 Thread Jonathan Matthew
We noticed that the ntpd engine process was getting a bit big on some boxes that we'd accidentally cut off from the ntp servers (routing is hard). Reading through the code, I noticed the 'query' member of struct ntp_peer is never freed, which seems to account for the leak. If you have a server poo