Re: initial 11ac support for iwm(4)

2022-03-17 Thread Landry Breuil
Le Wed, Mar 16, 2022 at 11:17:47PM +0100, Stefan Sperling a écrit : > On Wed, Mar 16, 2022 at 04:11:41PM +0100, Stefan Sperling wrote: > > This patch adds initial 11ac support to the iwm(4) driver. > > It allows use of 80 MHz channels and VHT MCS. > > Updated patch. Fixes a fatal firmware error on

Re: XBox One gamecontroller support

2022-03-17 Thread Thomas Frohwein
On Thu, Mar 17, 2022 at 10:58:21PM +0100, Solene Rapenne wrote: [...] > > > > ping > > this diff is still applying to the kernel and allows to use a popular > and affordable game controller The diff was written fairly conservatively based on pre-existing code and NetBSD's solution. It would b

document route sourceaddr limits with raw sockets

2022-03-17 Thread Denis Fondras
This is a recurring complaint so better document it. Denis Index: route.8 === RCS file: /cvs/src/sbin/route/route.8,v retrieving revision 1.102 diff -u -p -r1.102 route.8 --- route.8 26 Oct 2021 15:48:25 - 1.102 +++ rout

Re: initial 11ac support for iwm(4)

2022-03-17 Thread Stefan Sperling
On Thu, Mar 17, 2022 at 02:43:14PM -0700, Mike Larkin wrote: > On Wed, Mar 16, 2022 at 11:17:47PM +0100, Stefan Sperling wrote: > > On Wed, Mar 16, 2022 at 04:11:41PM +0100, Stefan Sperling wrote: > > > This patch adds initial 11ac support to the iwm(4) driver. > > > It allows use of 80 MHz channel

Re: initial 11ac support for iwm(4)

2022-03-17 Thread Mike Larkin
On Wed, Mar 16, 2022 at 11:17:47PM +0100, Stefan Sperling wrote: > On Wed, Mar 16, 2022 at 04:11:41PM +0100, Stefan Sperling wrote: > > This patch adds initial 11ac support to the iwm(4) driver. > > It allows use of 80 MHz channels and VHT MCS. > > Updated patch. Fixes a fatal firmware error on dev

Re: initial 11ac support for iwm(4)

2022-03-17 Thread Stefan Sperling
On Thu, Mar 17, 2022 at 07:02:06PM +0100, Marcus MERIGHI wrote: > Hello! > > Thanks for your work on this! > > s...@stsp.name (Stefan Sperling), 2022.03.16 (Wed) 16:11 (CET): > > This patch adds initial 11ac support to the iwm(4) driver. > > It allows use of 80 MHz channels and VHT MCS. > [...] >

Re: wg: remove argument names from prototypes

2022-03-17 Thread Theo Buehler
On Thu, Mar 17, 2022 at 07:17:40PM +0100, Martin Vahlensieck wrote: > None of the other prototypes have argument names. Committed, thanks

Re: rpki-client(8): properly zero terminate pretty printed key

2022-03-17 Thread Theo Buehler
On Thu, Mar 17, 2022 at 07:24:34PM +0100, Martin Vahlensieck wrote: > Hi > > It seems the pretty printed key is zero terminated only if the size > of hex stays the same or increases between calls. This diff fixes > it, so it is always properly terminated. While here, also drop > *hex != '\0' fro

Re: two small typos

2022-03-17 Thread Stuart Henderson
thanks, committed. On 2022/03/17 19:16, Martin Vahlensieck wrote: > Index: if_wg.c > === > RCS file: /home/reposync/cvs/src/sys/net/if_wg.c,v > retrieving revision 1.22 > diff -u -p -r1.22 if_wg.c > --- if_wg.c 22 Feb 2022 01:15:02

rpki-client(8): properly zero terminate pretty printed key

2022-03-17 Thread Martin Vahlensieck
Hi It seems the pretty printed key is zero terminated only if the size of hex stays the same or increases between calls. This diff fixes it, so it is always properly terminated. While here, also drop *hex != '\0' from the if inside the loop, as it is checked directly above in the loop condition

wg: remove argument names from prototypes

2022-03-17 Thread Martin Vahlensieck
None of the other prototypes have argument names. Index: if_wg.c === RCS file: /home/reposync/cvs/src/sys/net/if_wg.c,v retrieving revision 1.22 diff -u -p -r1.22 if_wg.c --- if_wg.c 22 Feb 2022 01:15:02 - 1.22 +++ if_wg.

two small typos

2022-03-17 Thread Martin Vahlensieck
Index: if_wg.c === RCS file: /home/reposync/cvs/src/sys/net/if_wg.c,v retrieving revision 1.22 diff -u -p -r1.22 if_wg.c --- if_wg.c 22 Feb 2022 01:15:02 - 1.22 +++ if_wg.c 15 Mar 2022 21:10:37 - @@ -2023,7 +2023,7

Re: refcount btrace

2022-03-17 Thread Alexander Bluhm
On Thu, Mar 17, 2022 at 07:25:27AM +, Visa Hankala wrote: > On Thu, Mar 17, 2022 at 12:42:13AM +0100, Alexander Bluhm wrote: > > I would like to use btrace to debug refernce counting. The idea > > is to a a tracepoint for every type of refcnt we have. When it > > changes, print the actual obj

Re: Use refcnt API with struct plimit

2022-03-17 Thread Alexander Bluhm
On Thu, Mar 17, 2022 at 04:07:24PM +, Visa Hankala wrote: > Use the refcnt API with struct plimit. > > OK? OK bluhm@ > Index: kern/kern_resource.c > === > RCS file: src/sys/kern/kern_resource.c,v > retrieving revision 1.71 > dif

Re: initial 11ac support for iwm(4)

2022-03-17 Thread Florian Obser
Still works fine on 9260. While playing around with this I noticed something else which is probably not a regression: I have two SSIDs, "normal" and NAT64, they are on the same AP and just come out on different vlans, they use the same channel. They are also on 2.4GHz. Switching between them wit

Use refcnt API with struct plimit

2022-03-17 Thread Visa Hankala
Use the refcnt API with struct plimit. OK? Index: kern/kern_resource.c === RCS file: src/sys/kern/kern_resource.c,v retrieving revision 1.71 diff -u -p -r1.71 kern_resource.c --- kern/kern_resource.c8 Feb 2021 10:51:01 -

Re: pcb mutex userland

2022-03-17 Thread Alexander Bluhm
On Thu, Mar 17, 2022 at 02:09:39PM +0100, Mark Kettenis wrote: > I fear the fundamental problem is that we should not expose data > structures internal to the kernel to userland. What I don't > understand though is how that happens. The sysctl code doesn't seem > to export "struct inpcb" instance

Re: pcb mutex userland

2022-03-17 Thread Claudio Jeker
On Thu, Mar 17, 2022 at 02:09:39PM +0100, Mark Kettenis wrote: > > Date: Thu, 17 Mar 2022 13:24:24 +0100 > > From: Alexander Bluhm > > > > On Thu, Mar 17, 2022 at 08:24:10AM +0100, Claudio Jeker wrote: > > > On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote: > > > > Hi, > > > > > >

Re: pcb mutex userland

2022-03-17 Thread Mark Kettenis
> Date: Thu, 17 Mar 2022 13:24:24 +0100 > From: Alexander Bluhm > > On Thu, Mar 17, 2022 at 08:24:10AM +0100, Claudio Jeker wrote: > > On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote: > > > Hi, > > > > > > My previous atempt to add a mutex to in_pcb.h was reverted as it > > > bro

Re: initial 11ac support for iwm(4)

2022-03-17 Thread Stefan Sperling
On Thu, Mar 17, 2022 at 01:07:42AM +, Stuart Henderson wrote: > 802.11 flags=0<>: beacon, ... > 191:12 0xb109cb33aaff1806aaff1806, 192:5 0x00aaff, Now is probably a good time to start pretty-printing these fields in tcpdump. ok? diff 140ae54c8a573c04824dd96957ebff4e069b2dfd /usr/src blo

Re: network drivers' manual page consistency

2022-03-17 Thread Jason McIntyre
On Thu, Mar 17, 2022 at 09:17:04AM +, Miod Vallat wrote: > I have noticed that a few manual page for network drivers mention the > duplex options in square brackets. This is inconsistent with the vast > majority of the network drivers' manual pages, so let's homogeneize > this. > hi. i'm fin

Re: pcb mutex userland

2022-03-17 Thread Alexander Bluhm
On Thu, Mar 17, 2022 at 08:24:10AM +0100, Claudio Jeker wrote: > On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote: > > Hi, > > > > My previous atempt to add a mutex to in_pcb.h was reverted as it > > broke userland build. > > > > Is the correct fix to include sys/mutex.h in every .

Re: fix boot timeout on arm64

2022-03-17 Thread Miod Vallat
> This issue has been fixed somewhat recently in U-Boot. It only > happens if you connect a USB keyboard to the machine. With the > exception of Apple machines and possibly the Raspberry Pi, I expect > most people to use a serial console on arm64 (and armv7 and riscv64) > machines. And Apple mac

Re: fix boot timeout on arm64

2022-03-17 Thread Mark Kettenis
> Date: Thu, 17 Mar 2022 11:02:00 + > From: Miod Vallat > > By default (with no override in /etc/boot.conf), the arm64 boot loader > will attempt to boot the kernel after a 5 second timeout. > > On the RPi 4b here, it will indeed boot the kernel, but after about 80 > seconds. > > The reason

fix boot timeout on arm64

2022-03-17 Thread Miod Vallat
By default (with no override in /etc/boot.conf), the arm64 boot loader will attempt to boot the kernel after a 5 second timeout. On the RPi 4b here, it will indeed boot the kernel, but after about 80 seconds. The reason for this delay is that there is logic in the boot code, while waiting for key

Re: sdmmc: simplify devlist2h

2022-03-17 Thread Jonathan Gray
On Thu, Mar 17, 2022 at 08:03:20AM +, Miod Vallat wrote: > sys/dev/sdmmc/devlist2h.awk was based upon sys/dev/pcmcia/devlist2h.awk. > The latter contains code to define optional CIS tuple overrides, which > are not used in sdmmc - there is only one override and it is applied in > sdmmc_check_ci

Re: bwfm@sdmmc: use symbolic constants for matching

2022-03-17 Thread Jonathan Gray
On Thu, Mar 17, 2022 at 08:05:38AM +, Miod Vallat wrote: > The following diff declares the various devices bwfm@sdmmc checks for, > and introduces no functional change. > > Index: if_bwfm_sdio.c > === > RCS file: /OpenBSD/src/sys/

network drivers' manual page consistency

2022-03-17 Thread Miod Vallat
I have noticed that a few manual page for network drivers mention the duplex options in square brackets. This is inconsistent with the vast majority of the network drivers' manual pages, so let's homogeneize this. Index: bse.4 === RCS

Re: Remove data dependency barrier from atomic_load_*

2022-03-17 Thread Alexander Bluhm
On Thu, Mar 17, 2022 at 07:12:16AM +, Visa Hankala wrote: > On Wed, Mar 16, 2022 at 11:09:12PM +0100, Alexander Bluhm wrote: > > On Tue, Mar 15, 2022 at 09:15:34AM +, Visa Hankala wrote: > > > However, some DEC Alpha CPUs have their data caches divided into cache > > > banks to improve band

bwfm@sdmmc: use symbolic constants for matching

2022-03-17 Thread Miod Vallat
The following diff declares the various devices bwfm@sdmmc checks for, and introduces no functional change. Index: if_bwfm_sdio.c === RCS file: /OpenBSD/src/sys/dev/sdmmc/if_bwfm_sdio.c,v retrieving revision 1.42 diff -u -p -r1.42 if_

sdmmc: simplify devlist2h

2022-03-17 Thread Miod Vallat
sys/dev/sdmmc/devlist2h.awk was based upon sys/dev/pcmcia/devlist2h.awk. The latter contains code to define optional CIS tuple overrides, which are not used in sdmmc - there is only one override and it is applied in sdmmc_check_cis_quirks(). The following diff removes this feature from devlist2h.

Re: refcount btrace

2022-03-17 Thread Visa Hankala
On Thu, Mar 17, 2022 at 12:42:13AM +0100, Alexander Bluhm wrote: > I would like to use btrace to debug refernce counting. The idea > is to a a tracepoint for every type of refcnt we have. When it > changes, print the actual object, the current counter and the change > value. > Do we want that fe

Re: pcb mutex userland

2022-03-17 Thread Claudio Jeker
On Thu, Mar 17, 2022 at 12:47:15AM +0100, Alexander Bluhm wrote: > Hi, > > My previous atempt to add a mutex to in_pcb.h was reverted as it > broke userland build. > > Is the correct fix to include sys/mutex.h in every .c file that > includes netinet/in_pcb.h ? I made a release with it. > Or sho

Re: Remove data dependency barrier from atomic_load_*

2022-03-17 Thread Visa Hankala
On Wed, Mar 16, 2022 at 11:09:12PM +0100, Alexander Bluhm wrote: > On Tue, Mar 15, 2022 at 09:15:34AM +, Visa Hankala wrote: > > However, some DEC Alpha CPUs have their data caches divided into cache > > banks to improve bandwidth. These cache banks are relatively > > independent. The system ma

Re: [External] : ipsec acquire mutex refcount

2022-03-17 Thread Alexandr Nedvedicky
Hello, > > > +ipsp_delete_acquire_locked(struct ipsec_acquire *ipa) > > > +{ > > > + if (timeout_del(&ipa->ipa_timeout) == 1) > > > + refcnt_rele(&ipa->ipa_refcnt); > >^^ > > can we also put ASSERT/check into this branch > > to verify we are no rele