Re: initial 11ac support for iwm(4)

2022-03-16 Thread Stuart Henderson
On 2022/03/16 23:17, Stefan Sperling wrote: > On Wed, Mar 16, 2022 at 04:11:41PM +0100, Stefan Sperling wrote: > > This patch adds initial 11ac support to the iwm(4) driver. > > It allows use of 80 MHz channels and VHT MCS. > > Updated patch. Fixes a fatal firmware error on devices which > do not

Re: pcb mutex userland

2022-03-16 Thread Alexander Bluhm
On Thu, Mar 17, 2022 at 01:07:12AM +0100, Mark Kettenis wrote: > > Date: Thu, 17 Mar 2022 01:01:46 +0100 (CET) > > From: Mark Kettenis > > > > > Date: Thu, 17 Mar 2022 00:47:15 +0100 > > > From: Alexander Bluhm > > > > > > Hi, > > > > > > My previous atempt to add a mutex to in_pcb.h was rever

Re: pcb mutex userland

2022-03-16 Thread Mark Kettenis
> Date: Thu, 17 Mar 2022 01:01:46 +0100 (CET) > From: Mark Kettenis > > > Date: Thu, 17 Mar 2022 00:47:15 +0100 > > From: Alexander Bluhm > > > > Hi, > > > > My previous atempt to add a mutex to in_pcb.h was reverted as it > > broke userland build. > > > > Is the correct fix to include sys/mu

Re: pcb mutex userland

2022-03-16 Thread Mark Kettenis
> Date: Thu, 17 Mar 2022 00:47:15 +0100 > From: Alexander Bluhm > > Hi, > > My previous atempt to add a mutex to in_pcb.h was reverted as it > broke userland build. > > Is the correct fix to include sys/mutex.h in every .c file that > includes netinet/in_pcb.h ? I made a release with it. > Or

pcb mutex userland

2022-03-16 Thread Alexander Bluhm
Hi, My previous atempt to add a mutex to in_pcb.h was reverted as it broke userland build. Is the correct fix to include sys/mutex.h in every .c file that includes netinet/in_pcb.h ? I made a release with it. Or should I include sys/mutex.h in netinet/in_pcb.h ? ok? bluhm Index: lib/libkvm/kv

refcount btrace

2022-03-16 Thread Alexander Bluhm
Hi, I would like to use btrace to debug refernce counting. The idea is to a a tracepoint for every type of refcnt we have. When it changes, print the actual object, the current counter and the change value. #!/usr/sbin/btrace tracepoint:refcnt:inpcb{ printf("%s %x %u %+d\n", probe, arg0

Re: initial 11ac support for iwm(4)

2022-03-16 Thread Stefan Sperling
On Wed, Mar 16, 2022 at 04:11:41PM +0100, Stefan Sperling wrote: > This patch adds initial 11ac support to the iwm(4) driver. > It allows use of 80 MHz channels and VHT MCS. Updated patch. Fixes a fatal firmware error on devices which do not support MIMO, such as the 3160. diff refs/heads/master

Re: Remove data dependency barrier from atomic_load_*

2022-03-16 Thread Alexander Bluhm
On Tue, Mar 15, 2022 at 09:15:34AM +, Visa Hankala wrote: > However, some DEC Alpha CPUs have their data caches divided into cache > banks to improve bandwidth. These cache banks are relatively > independent. The system maintains coherency, but bus contention can > delay propagation of cache up

Re: fix multiple iwm/iwx interfaces

2022-03-16 Thread Stefan Sperling
On Wed, Mar 16, 2022 at 08:46:01PM +0100, Jeremie Courreges-Anglas wrote: > On Mon, Mar 14 2022, Stefan Sperling wrote: > > It is currently impossible to use more than one iwm or iwx interface > > in a system because I don't understand C. > > > > Trying to bring up an uninitialized interface anywa

Re: [External] : ipsec acquire mutex refcount

2022-03-16 Thread Alexander Bluhm
On Mon, Mar 14, 2022 at 11:09:48AM +0100, Alexandr Nedvedicky wrote: > 667 ipsec_delete_policy(struct ipsec_policy *ipo) > > 668 { > 669 struct ipsec_acquire *ipa; > 670 struct radix_node_head *rnh; > 671 struct radix_node *rn =

Re: Use refcnt API with struct ucred

2022-03-16 Thread Alexander Bluhm
On Wed, Mar 16, 2022 at 04:14:05PM +, Visa Hankala wrote: > Use the refcnt API with struct ucred. > > OK? OK bluhm@ > Index: nfs/nfs_socket.c > === > RCS file: src/sys/nfs/nfs_socket.c,v > retrieving revision 1.139 > diff -u -p

Re: Use refcnt API in bpf

2022-03-16 Thread Alexander Bluhm
On Wed, Mar 16, 2022 at 04:11:43PM +, Visa Hankala wrote: > Use the refcnt API in bpf. > > OK? OK bluhm@ > Index: net/bpf.c > === > RCS file: src/sys/net/bpf.c,v > retrieving revision 1.215 > diff -u -p -r1.215 bpf.c > --- net/b

Re: fix multiple iwm/iwx interfaces

2022-03-16 Thread Jeremie Courreges-Anglas
On Mon, Mar 14 2022, Stefan Sperling wrote: > It is currently impossible to use more than one iwm or iwx interface > in a system because I don't understand C. > > Trying to bring up an uninitialized interface anyway results in a > kernel panic ("bogus channel pointer" from net80211), so prevent >

Re: initial 11ac support for iwm(4)

2022-03-16 Thread Kurt Mosiejczuk
On Wed, Mar 16, 2022 at 04:11:41PM +0100, Stefan Sperling wrote: > This patch adds initial 11ac support to the iwm(4) driver. > It allows use of 80 MHz channels and VHT MCS. > In net80211 I added a new rate control module to support VHT rates, as > a new file called ieee80211_ra_vht.c, derived fro

Re: initial 11ac support for iwm(4)

2022-03-16 Thread Florian Obser
This works fine on iwm0 at pci1 dev 0 function 0 "Intel Dual Band Wireless-AC 9260" rev 0x29, msix iwm0: hw rev 0x320, fw ver 46.4e1ceb39.0 and iwm0 at pci2 dev 0 function 0 "Intel AC 7260" rev 0x83, msi iwm0: hw rev 0x140, fw ver 17.3216344376.0 against UniFi UAP-AC-SHD and UAP-AC-Pro. I have

Re: initial 11ac support for iwm(4)

2022-03-16 Thread James Turner
On Wed, Mar 16, 2022 at 04:11:41PM +0100, Stefan Sperling wrote: > This patch adds initial 11ac support to the iwm(4) driver. > It allows use of 80 MHz channels and VHT MCS. > > In net80211 I added a new rate control module to support VHT rates, as > a new file called ieee80211_ra_vht.c, derived f

Re: [External] : Use refcnt API in bpf

2022-03-16 Thread Alexandr Nedvedicky
On Wed, Mar 16, 2022 at 04:11:43PM +, Visa Hankala wrote: > Use the refcnt API in bpf. > > OK? Looks OK to me. sashan

Use refcnt API with struct ucred

2022-03-16 Thread Visa Hankala
Use the refcnt API with struct ucred. OK? Index: nfs/nfs_socket.c === RCS file: src/sys/nfs/nfs_socket.c,v retrieving revision 1.139 diff -u -p -r1.139 nfs_socket.c --- nfs/nfs_socket.c22 Feb 2022 01:15:02 - 1.139 +++ nf

Use refcnt API in bpf

2022-03-16 Thread Visa Hankala
Use the refcnt API in bpf. OK? Index: net/bpf.c === RCS file: src/sys/net/bpf.c,v retrieving revision 1.215 diff -u -p -r1.215 bpf.c --- net/bpf.c 15 Feb 2022 08:43:50 - 1.215 +++ net/bpf.c 16 Mar 2022 15:42:05 - @@

initial 11ac support for iwm(4)

2022-03-16 Thread Stefan Sperling
This patch adds initial 11ac support to the iwm(4) driver. It allows use of 80 MHz channels and VHT MCS. In net80211 I added a new rate control module to support VHT rates, as a new file called ieee80211_ra_vht.c, derived from ieee80211_ra.c which we use in 11n mode. The task of this code is to de

Re: Use refcnt API in kqueue

2022-03-16 Thread Alexander Bluhm
On Tue, Mar 15, 2022 at 02:12:43PM +, Visa Hankala wrote: > Make kqueue use the refcnt API. > > OK? OK bluhm@ > Index: sys/kern/kern_event.c > === > RCS file: src/sys/kern/kern_event.c,v > retrieving revision 1.183 > diff -u -p

Re: PATCH: speed up pkg_add

2022-03-16 Thread Marc Espie
I got a new slightly different one. Specifically, the old one has a "fun" failure mode in case an old package got broken and is missing files. The heuristics correctly deduces that the files are not there, so it extracts in-place... then pkg_delete promptly deletes what it believes to be files fro