Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Ted Bullock
On 2022-02-14 12:50 a.m., Jonathan Gray wrote: On Mon, Feb 14, 2022 at 12:05:44AM -0700, Ted Bullock wrote: On 2022-02-13 11:02 p.m., Jonathan Gray wrote: On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: On 2022-02-12 6:46 p.m., Jonathan Gray wrote: I will review further when

Re: Power-up cc --print-file-name for .so names

2022-02-13 Thread Theo de Raadt
Philip Guenther wrote: > On Sun, Feb 13, 2022 at 11:18 PM Mark Kettenis > wrote: > > > > From: Greg Steuck > > > Date: Sun, 13 Feb 2022 22:37:13 -0800 > > > > > > To give a sense of the kind of change required to get the feature I > > > want, see the patch at the end. The change in DriverUtils

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Jonathan Gray
On Mon, Feb 14, 2022 at 12:05:44AM -0700, Ted Bullock wrote: > > On 2022-02-13 11:02 p.m., Jonathan Gray wrote: > > On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: > > > On 2022-02-12 6:46 p.m., Jonathan Gray wrote: > > > > I will review further when you drop the function. > > > > >

Re: Power-up cc --print-file-name for .so names

2022-02-13 Thread Theo de Raadt
Philip Guenther wrote: > Those of long memory will recall a hackathon where dependencies on libc > were put in place, the libm vs libc deps were changed as functions were > moved from libm to libc, and base builds completely broke. My recall is > that the diffs had to basically be unrolled to re

Re: Power-up cc --print-file-name for .so names

2022-02-13 Thread Theo de Raadt
> The solution would be to add symlinks like all the other OSes do. But > Theo doesn't like that. No, the problem is you add symbolic links, how long before software ecosystems in ports choose the short names in linkage -- "because it also works"? If they do so, all the transition benefits we ha

Re: Power-up cc --print-file-name for .so names

2022-02-13 Thread Philip Guenther
On Sun, Feb 13, 2022 at 11:29 PM Philip Guenther wrote: > On Sun, Feb 13, 2022 at 11:18 PM Mark Kettenis > wrote: > >> > From: Greg Steuck >> > Date: Sun, 13 Feb 2022 22:37:13 -0800 >> > >> > To give a sense of the kind of change required to get the feature I >> > want, see the patch at the end

Re: Power-up cc --print-file-name for .so names

2022-02-13 Thread Greg Steuck
Mark Kettenis writes: >> From: Greg Steuck >> Date: Sun, 13 Feb 2022 22:37:13 -0800 >> >> To give a sense of the kind of change required to get the feature I >> want, see the patch at the end. The change in DriverUtils.cpp is just to >> show that the same function is hiding in there. >> >> If

Re: Power-up cc --print-file-name for .so names

2022-02-13 Thread Philip Guenther
On Sun, Feb 13, 2022 at 11:18 PM Mark Kettenis wrote: > > From: Greg Steuck > > Date: Sun, 13 Feb 2022 22:37:13 -0800 > > > > To give a sense of the kind of change required to get the feature I > > want, see the patch at the end. The change in DriverUtils.cpp is just to > > show that the same fu

Re: Power-up cc --print-file-name for .so names

2022-02-13 Thread Mark Kettenis
> From: Greg Steuck > Date: Sun, 13 Feb 2022 22:37:13 -0800 > > To give a sense of the kind of change required to get the feature I > want, see the patch at the end. The change in DriverUtils.cpp is just to > show that the same function is hiding in there. > > If this looks like a good direction

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Ted Bullock
On 2022-02-13 11:02 p.m., Jonathan Gray wrote: On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: On 2022-02-12 6:46 p.m., Jonathan Gray wrote: I will review further when you drop the function. Alright try this again, I have committed some parts of this, with one commit per spec

Re: Power-up cc --print-file-name for .so names

2022-02-13 Thread Greg Steuck
To give a sense of the kind of change required to get the feature I want, see the patch at the end. The change in DriverUtils.cpp is just to show that the same function is hiding in there. If this looks like a good direction, I can cleanup the code and maybe it could be shared, though I'm not sure

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: > On 2022-02-12 6:46 p.m., Jonathan Gray wrote: > > I will review further when you drop the function. > > Alright try this again, I have committed some parts of this, with one commit per specific issue. pa_memex NULL test sparc64 ifnde

Re: Import seq(1) from FreeBSD

2022-02-13 Thread Greg Steuck
Jonathan Gray writes: > On Sun, Feb 13, 2022 at 12:07:31PM -0800, Greg Steuck wrote: >> Ingo Schwarze writes: >> >> > Hi Todd, >> > >> > in view of your arguments and sthen@'s OK, i'm also OK with this >> > going in. I think a bit of code cleanup and copy editing in the >> > manual page may be

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size = 42949672

Re: stpecpy(): A better string copy and concatenation function

2022-02-13 Thread Theo de Raadt
Alejandro Colomar (man-pages) wrote: > However, considering some systems don't have strl* functions, and > explicitly don't want to add them (glibc rejected strl* functions), > there it might be useful to add this function. So your position is that when a small number of people fight the emergen

Re: Import seq(1) from FreeBSD

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 12:07:31PM -0800, Greg Steuck wrote: > Ingo Schwarze writes: > > > Hi Todd, > > > > in view of your arguments and sthen@'s OK, i'm also OK with this > > going in. I think a bit of code cleanup and copy editing in the > > manual page may be useful afterwards, but that can

Re: stpecpy(): A better string copy and concatenation function

2022-02-13 Thread Alejandro Colomar (man-pages)
Hi Theo, On 2/13/22 23:45, Theo de Raadt wrote: > Your proposal isn't an improvement over the current situation with strl* > functions, and I don't think this is helpful. > > Alejandro Colomar (man-pages) wrote: >>Compared to other string copy and concatenation functions >>strlcat(3BS

Re: mvdog(4): add support for armada-380-wdg

2022-02-13 Thread Tobias Heider
On Sun, Feb 13, 2022 at 03:47:28PM +0100, Mark Kettenis wrote: > > I'm not sure this code should share a driver with the A3700 code. The > hardware doesn't seem to share any commonalities except for the > Marvell name. Linux has a separate driver which it calls "orion_wdt". > So maybe mvodog(4)

Re: stpecpy(): A better string copy and concatenation function

2022-02-13 Thread Theo de Raadt
Your proposal isn't an improvement over the current situation with strl* functions, and I don't think this is helpful. Alejandro Colomar (man-pages) wrote: > Hi, Todd and Theo! > > I wrote this function this week, based on strlcpy(3) and strecopy()[1], > which are the best string copy functions

stpecpy(): A better string copy and concatenation function

2022-02-13 Thread Alejandro Colomar (man-pages)
Hi, Todd and Theo! I wrote this function this week, based on strlcpy(3) and strecopy()[1], which are the best string copy functions I've seen so far. But I came to improvements that bring one function that I think is better than both of those. I posted the function for review on codidact.com[2].

Re: apm -m means one of two things now

2022-02-13 Thread Jason McIntyre
On Fri, Feb 11, 2022 at 05:31:43PM +, Jason McIntyre wrote: > On Thu, Feb 10, 2022 at 02:59:48PM +0100, Jan Stary wrote: > > With the recent change to apm -m, > > reporting either the battery lifetime > > or the estimated time to charge (thank you), > > the manpage seems to have been left behin

Re: Import seq(1) from FreeBSD

2022-02-13 Thread Greg Steuck
Ingo Schwarze writes: > Hi Todd, > > in view of your arguments and sthen@'s OK, i'm also OK with this > going in. I think a bit of code cleanup and copy editing in the > manual page may be useful afterwards, but that can be done in the > tree, no need for playing patch ping pong. I noticed that

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Ted Bullock
On 2022-02-12 6:46 p.m., Jonathan Gray wrote: > I will review further when you drop the function. Alright try this again, diff b5c3be43fcdaf7cbd7d070c07746b451413f6b4a 453e49da7f0804392d6d51fb578cfd8255f4fb77 blob - a2d53f752bccb1ab54993ec2a7d5791ec2216e0a blob + f6353eb5f76e0ae0e21277f82e86b70b

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Mark Kettenis
> Date: Mon, 14 Feb 2022 01:41:45 +1100 > From: Jonathan Gray > > On Mon, Feb 14, 2022 at 01:31:57AM +1100, Jonathan Gray wrote: > > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > > OF_getproplen() will retu

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Mark Kettenis
> Date: Mon, 14 Feb 2022 01:31:57 +1100 > From: Jonathan Gray > > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > > currently causes a pani

Re: mvdog(4): add support for armada-380-wdg

2022-02-13 Thread Mark Kettenis
> Date: Sun, 13 Feb 2022 14:56:11 +0100 > From: Patrick Wildt > > Am Sun, Feb 13, 2022 at 02:22:53PM +0100 schrieb Tobias Heider: > > Hey, > > > > I'm trying to get the Turris Omnia running and one thing missing > > is a driver for the armada-380-wdg. We already have a similar driver > > called

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Mon, Feb 14, 2022 at 01:31:57AM +1100, Jonathan Gray wrote: > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > > currently causes a panic:

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Mark Kettenis
> Date: Sun, 13 Feb 2022 14:30:21 +0100 > From: Tobias Heider > > OF_getproplen() will return -1 if "reset-gpios" is not found which > currently causes a panic: > > panic: malloc: allocation too large, type = 2, size = 4294967295 > > Below is a fix. > > ok? ok kettenis@ > Index: mvpcie.c > =

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size = 42949672

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Theo Buehler
On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > OF_getproplen() will return -1 if "reset-gpios" is not found which > currently causes a panic: > > panic: malloc: allocation too large, type = 2, size = 4294967295 > > Below is a fix. There are more of these: dev/ofw/ofw_regulator

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Patrick Wildt
Am Sun, Feb 13, 2022 at 01:39:22PM + schrieb Klemens Nanni: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size = 429496

Re: mvdog(4): add support for armada-380-wdg

2022-02-13 Thread Patrick Wildt
Am Sun, Feb 13, 2022 at 02:22:53PM +0100 schrieb Tobias Heider: > Hey, > > I'm trying to get the Turris Omnia running and one thing missing > is a driver for the armada-380-wdg. We already have a similar driver > called mvdog(4) that currently only supports the armada-3700 watchdog. > The diff be

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Klemens Nanni
On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > OF_getproplen() will return -1 if "reset-gpios" is not found which > currently causes a panic: > > panic: malloc: allocation too large, type = 2, size = 4294967295 > > Below is a fix. > > ok? OK kn > > Index: mvpcie.c > =

mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Tobias Heider
OF_getproplen() will return -1 if "reset-gpios" is not found which currently causes a panic: panic: malloc: allocation too large, type = 2, size = 4294967295 Below is a fix. ok? Index: mvpcie.c === RCS file: /mount/openbsd/cvs/src/

mvdog(4): add support for armada-380-wdg

2022-02-13 Thread Tobias Heider
Hey, I'm trying to get the Turris Omnia running and one thing missing is a driver for the armada-380-wdg. We already have a similar driver called mvdog(4) that currently only supports the armada-3700 watchdog. The diff below adds support for disabling the armada-380-wdg. ok? Index: mvdog.c

Re: tcpdump core's on the latest snapshot

2022-02-13 Thread Mikhail
On Sun, Feb 13, 2022 at 12:54:19PM +0100, Otto Moerbeek wrote: > I can see two problems: > > 1. setjump returning 1 > 2. freechunks() segfaulting. > > Here I'll concentrate on 2), as I suspect 1) has a cause that is already in > the process of being diagnosed/fixed elsewhere. The patch works - n

Re: tcpdump core's on the latest snapshot

2022-02-13 Thread Otto Moerbeek
On Sun, Feb 13, 2022 at 12:54:19PM +0100, Otto Moerbeek wrote: > On Sun, Feb 13, 2022 at 01:12:34PM +0300, Mikhail wrote: > > > Running this command on the latest snapshot produces core file for me: > > > > doas tcpdump -i urtwn0 proto ip6 BTW, the proper way to filter ipv6 packets is either d

Re: tcpdump core's on the latest snapshot

2022-02-13 Thread Otto Moerbeek
On Sun, Feb 13, 2022 at 01:12:34PM +0300, Mikhail wrote: > Running this command on the latest snapshot produces core file for me: > > doas tcpdump -i urtwn0 proto ip6 > > Core details: > > misha:/home/misha:3959$ doas lldb --core tcpdump.core tcpdump > (lldb) target create "tcpdump" --core "tcp

tcpdump core's on the latest snapshot

2022-02-13 Thread Mikhail
Running this command on the latest snapshot produces core file for me: doas tcpdump -i urtwn0 proto ip6 Core details: misha:/home/misha:3959$ doas lldb --core tcpdump.core tcpdump (lldb) target create "tcpdump" --core "tcpdump.core" Core file '/home/misha/tcpdump.core' (x86_64) was loaded. (lldb