Re: fw_update(8) Redownload files that fail validation

2022-01-21 Thread Andrew Hewus Fresh
Here's an updated patch that applies after recent commits. I'll commit this sometime this weekend unless someone has other ideas. On Sat, Jan 08, 2022 at 08:30:09PM -0800, Andrew Hewus Fresh wrote: > That last patch I committed made it so that if you specify a local path > to install from with -p

Re: perl clang -Wcompound-token-split-by-macro

2022-01-21 Thread Andrew Hewus Fresh
On Sat, Jan 22, 2022 at 02:24:51AM +0100, Marc Espie wrote: > Or we can automate this with something like this: I didn't try this, but it seems OK to me. I'll leave the final OK to sthen though as I would think it most likely to break things for him. (AFAIU new versions are not supposed to cause

Re: perl clang -Wcompound-token-split-by-macro

2022-01-21 Thread Marc Espie
Or we can automate this with something like this: Index: perl.port.mk === RCS file: /cvs/ports/infrastructure/mk/perl.port.mk,v retrieving revision 1.32 diff -u -p -r1.32 perl.port.mk --- perl.port.mk12 Dec 2021 19:25:39 -

Re: kubsan tcp timer shift

2022-01-21 Thread Ted Bullock
On 2022-01-21 8:40 a.m., Alexander Bluhm wrote: >>> There is no best, minimalistic and most consistent solution. >> >> I have always considered numberU as being the same type of thing as >> using 'u_int' instead of 'int' for a variable, it is idiomatic C >> to force all considerations into signed.

Re: kubsan tcp timer shift

2022-01-21 Thread Miod Vallat
> Sounds like a call for the huge U change. Since none of these #define seem to be used by .S files, go for it. We don't really want to bring Mach's U() macro back.

Re: rpki-client: factor filename extension parsing into a function

2022-01-21 Thread Bob Beck
I like that.. LGTM ok beck@ On Fri, Jan 21, 2022 at 08:37:27PM +0100, Theo Buehler wrote: > > Lets start with that and optimize this in tree. I think we can rename the > > function to something like rtype_from_mftfile(). In that case I would move > > the function as well... > > Like this? >

Re: perl clang -Wcompound-token-split-by-macro

2022-01-21 Thread Stuart Henderson
btw, bumping the library version for libperl is a safer way of triggering those updates than revision bumps; the latter are subject to a build timing problem, you have to hope that the ports build machines are running a version of base built with the updated perl. On 2022/01/21 18:27, Alexander Bl

Re: rpki-client: factor filename extension parsing into a function

2022-01-21 Thread Theo Buehler
> Lets start with that and optimize this in tree. I think we can rename the > function to something like rtype_from_mftfile(). In that case I would move > the function as well... Like this? Index: extern.h === RCS file: /cvs/src/usr.

Re: perl clang -Wcompound-token-split-by-macro

2022-01-21 Thread Alexander Bluhm
On Fri, Jan 21, 2022 at 08:39:34AM -0800, Andrew Hewus Fresh wrote: > On Fri, Jan 21, 2022 at 04:34:13PM +0100, Marc Espie wrote: > > So I don't really think perl requires any change. > > > > Possibly hacking a bit on ports that use an outdated version of ppport.h > > Updating ppport.h seems reaso

Re: rpki-client: factor filename extension parsing into a function

2022-01-21 Thread Claudio Jeker
On Fri, Jan 21, 2022 at 04:49:47PM +0100, Theo Buehler wrote: > On Fri, Jan 21, 2022 at 02:58:57PM +0100, Claudio Jeker wrote: > > On Wed, Jan 19, 2022 at 06:01:38PM +0100, Theo Buehler wrote: > > > Not sure if it is that much of a win, but it saves some repetition and > > > makes sure we don't for

Re: perl clang -Wcompound-token-split-by-macro

2022-01-21 Thread Andrew Hewus Fresh
On Fri, Jan 21, 2022 at 04:34:13PM +0100, Marc Espie wrote: > On Fri, Jan 21, 2022 at 02:12:25PM +0100, Alexander Bluhm wrote: > > Hi, > > > > Since clang 13 each Perl or Perl XS module compile spits out a lot > > of -Wcompound-token-split-by-macro warnings. E.g. p5-Net-SSLeay > > produces 3882 w

Re: rpki-client: factor filename extension parsing into a function

2022-01-21 Thread Theo Buehler
On Fri, Jan 21, 2022 at 02:58:57PM +0100, Claudio Jeker wrote: > On Wed, Jan 19, 2022 at 06:01:38PM +0100, Theo Buehler wrote: > > Not sure if it is that much of a win, but it saves some repetition and > > makes sure we don't forget checking the file name to be longer than 4 > > another time (misse

Re: clang: compile static analyzer

2022-01-21 Thread Steffen Nurpmeso
Andre Smagin wrote in <20220120231806.0463e0c792db3e3e5fc07...@smagin.com>: |On Fri, 21 Jan 2022 00:45:56 +0100 |Steffen Nurpmeso wrote: | |> I found scan-build to generate a lot of false warnings, so much indeed |> that i stopped using it .. in summer 2017. | |You, and most others, (no s

Re: kubsan tcp timer shift

2022-01-21 Thread Alexander Bluhm
On Thu, Jan 20, 2022 at 06:36:36PM -0700, Theo de Raadt wrote: > > Alternatives are: > > - put U to every TF_ TCP flag > > - put U to all TF_TMR_ timer flags > > - put U to TF_TMR_REXMT retransmit timer flag > > - cast TF_TIMER to unsigned (what I did) > > - cast to unsigned in the TCP_TIMER_ARM, T

Re: perl clang -Wcompound-token-split-by-macro

2022-01-21 Thread Marc Espie
On Fri, Jan 21, 2022 at 02:12:25PM +0100, Alexander Bluhm wrote: > Hi, > > Since clang 13 each Perl or Perl XS module compile spits out a lot > of -Wcompound-token-split-by-macro warnings. E.g. p5-Net-SSLeay > produces 3882 warnings generated. You cannot spot anything useful. > The problem is bu

Re: fix active scan on iwm and iwx

2022-01-21 Thread Jeremie Courreges-Anglas
On Thu, Jan 13 2022, Stefan Sperling wrote: > At present active scans (which send probe requests, as opposed to > just listening for beacons) are disabled on iwm 9k and iwx. This > was done because firmware misbehaved after association. > > zxystd from the OpenIntelWireless project has debugged th

Re: fix active scan on iwm and iwx

2022-01-21 Thread Mark Kettenis
> Date: Fri, 21 Jan 2022 16:05:49 +0100 > From: Stefan Sperling > > On Sun, Jan 16, 2022 at 07:38:11PM +0100, Mark Kettenis wrote: > > > Date: Sun, 16 Jan 2022 19:28:06 +0100 > > > From: Stefan Sperling > > > > > > On Sun, Jan 16, 2022 at 03:50:55PM +0100, Mark Kettenis wrote: > > > > However,

Re: perl clang -Wcompound-token-split-by-macro

2022-01-21 Thread Alexander Bluhm
This change would require a revision bump for all Perl XS ports Otherwise loading the .so module fails. $ perl -MNet::SSLeay SSLeay.c: loadable library and perl binaries are mismatched (got handshake key 0xec0, needed 0xf00) On Fri, Jan 21, 2022 at 02:12:25P

Re: fix active scan on iwm and iwx

2022-01-21 Thread Stefan Sperling
On Sun, Jan 16, 2022 at 07:38:11PM +0100, Mark Kettenis wrote: > > Date: Sun, 16 Jan 2022 19:28:06 +0100 > > From: Stefan Sperling > > > > On Sun, Jan 16, 2022 at 03:50:55PM +0100, Mark Kettenis wrote: > > > However, running this diff I had a problem after resuming my laptop > > > twice. After re

Re: rpki-client -f and multiple files

2022-01-21 Thread Theo Buehler
On Fri, Jan 21, 2022 at 03:22:51PM +0100, Claudio Jeker wrote: > I would like to change -f into a real mode and with that support to > show more then one file at a time. > > This is doing most of that. The output may need some extra fixing but the > logic itself works. > > Yay or nay? Yay. I lik

rpki-client -f and multiple files

2022-01-21 Thread Claudio Jeker
I would like to change -f into a real mode and with that support to show more then one file at a time. This is doing most of that. The output may need some extra fixing but the logic itself works. Yay or nay? -- :wq Claudio Index: main.c =

Re: rpki-client: factor filename extension parsing into a function

2022-01-21 Thread Claudio Jeker
On Wed, Jan 19, 2022 at 06:01:38PM +0100, Theo Buehler wrote: > Not sure if it is that much of a win, but it saves some repetition and > makes sure we don't forget checking the file name to be longer than 4 > another time (missed on review in main() and proc_parser_file()). I like the diff. It is

perl clang -Wcompound-token-split-by-macro

2022-01-21 Thread Alexander Bluhm
Hi, Since clang 13 each Perl or Perl XS module compile spits out a lot of -Wcompound-token-split-by-macro warnings. E.g. p5-Net-SSLeay produces 3882 warnings generated. You cannot spot anything useful. The problem is burried deeply in the Perl macros and copied to everywhere. If we compile Perl

Re: application.c be more paranoid for misbehaving backends

2022-01-21 Thread Sebastian Benoit
Martijn van Duren(openbsd+t...@list.imperialat.at) on 2022.01.20 22:53:06 +0100: > There's a missing NULL check in appl_response(). This should only happenwhen > a backend is misbehaving, so I only managed to find this because > I'm actively bashing it right now. This should make us a little more

Re: 'pseudo-device dt' on macppc

2022-01-21 Thread Klemens Nanni
On Tue, Jan 18, 2022 at 07:59:20AM +0300, Andrew Krasavin wrote: > Hello! > > Is there a reason not to enable dt(4) on macppc by default? I have > built a kernel with dt enabled for test purposes and it seems to work > correctly - commands like 'btrace /usr/share/btrace/kprofile.bt' > work and I g