Re: rev(1): pull MB_CUR_MAX out of the hot loop

2022-01-12 Thread Ingo Schwarze
Hi Martijn, Martijn van Duren wrote on Sun, Jan 09, 2022 at 08:09:20AM +0100: > I fully agree with your reasoning and also prefer this one over the > previous two diff. > > OK martijn@ Thanks for checking; committed. Also thanks to cheloha@ for his work on this issue and to milllert@ for his fe

Re: new: lang/polyml

2022-01-12 Thread Daniel Dickman
> On Jan 12, 2022, at 2:06 AM, Philip Guenther wrote: > >  >> On Tue, Jan 11, 2022 at 4:09 PM Daniel Dickman wrote: > >> On Mon, Jan 10, 2022 at 8:12 PM Leo Larnack wrote: >> > >> > i386 >> > >> >> >> >> with this diff I was able to install includes, rebuild ld.so and >> ctfconv. I've n

Re: ix(4): enable TCPv6/UDPv6 cksum offloading

2022-01-12 Thread Theo de Raadt
Jan Klemkow wrote: > On Wed, Jan 12, 2022 at 05:54:07PM +0100, Mark Kettenis wrote: > > > Date: Wed, 12 Jan 2022 17:45:57 +0100 > > > From: Jan Klemkow > > > > > > On Wed, Jan 12, 2022 at 05:36:01PM +0100, Mark Kettenis wrote: > > > > > Date: Wed, 12 Jan 2022 17:02:03 +0100 > > > > > From: Jan

Re: ix(4): enable TCPv6/UDPv6 cksum offloading

2022-01-12 Thread Jan Klemkow
On Wed, Jan 12, 2022 at 05:54:07PM +0100, Mark Kettenis wrote: > > Date: Wed, 12 Jan 2022 17:45:57 +0100 > > From: Jan Klemkow > > > > On Wed, Jan 12, 2022 at 05:36:01PM +0100, Mark Kettenis wrote: > > > > Date: Wed, 12 Jan 2022 17:02:03 +0100 > > > > From: Jan Klemkow > > > > > > > > Hi, > > >

Re: ix(4): enable TCPv6/UDPv6 cksum offloading

2022-01-12 Thread Mark Kettenis
> Date: Wed, 12 Jan 2022 17:45:57 +0100 > From: Jan Klemkow > > On Wed, Jan 12, 2022 at 05:36:01PM +0100, Mark Kettenis wrote: > > > Date: Wed, 12 Jan 2022 17:02:03 +0100 > > > From: Jan Klemkow > > > > > > Hi, > > > > > > This diff enables TCP and UDP checksum offloading in ix(4) for IPv6. >

Re: ix(4): enable TCPv6/UDPv6 cksum offloading

2022-01-12 Thread Theo de Raadt
> Yes, but we don't parse the TCP header here. As bluhm@ figured out: > The access to ip_hl does not generate an alignment problem on sparc64. > Because, the bits of ip_hl are on the other of the byte, as bits of > th_off. I think this is pure luck, and suspect the same problem will happen again

Re: ix(4): enable TCPv6/UDPv6 cksum offloading

2022-01-12 Thread Mark Kettenis
> Date: Wed, 12 Jan 2022 17:02:03 +0100 > From: Jan Klemkow > > Hi, > > This diff enables TCP and UDP checksum offloading in ix(4) for IPv6. > > IPv6 extension headers aren't a problem in this case. > in6_proto_cksum_out() in netinet6/ip6_output.c disables checksum > offloading if ip6_nxt is no

Re: uninitialized stack memory possibly passed to m_freem

2022-01-12 Thread Stefan Sperling
On Wed, Jan 12, 2022 at 11:30:44AM +0100, Moritz Buhl wrote: > Hi tech@, > > https://github.com/openbsd/src/commit/0ea6bae06233cd25645df14602c3eda6bdff7dca.patch > > the patch forgot to add mrep to the info struct, nfsm_dissect could > pass info.nmi_mrep to m_freem, which is currently uninitializ

uninitialized stack memory possibly passed to m_freem

2022-01-12 Thread Moritz Buhl
Hi tech@, https://github.com/openbsd/src/commit/0ea6bae06233cd25645df14602c3eda6bdff7dca.patch the patch forgot to add mrep to the info struct, nfsm_dissect could pass info.nmi_mrep to m_freem, which is currently uninitialized stack memory. Index: sys/nfs/nfs_subs.c =

Re: new: lang/polyml

2022-01-12 Thread Stuart Henderson
On 2022/01/11 23:06, Philip Guenther wrote: > On Tue, Jan 11, 2022 at 4:09 PM Daniel Dickman wrote: > > > On Mon, Jan 10, 2022 at 8:12 PM Leo Larnack wrote: > > > > > > i386 > > > > > > > > > > > with this diff I was able to install includes, rebuild ld.so and > > ctfconv. I've not managed to bu