Re: ip_deliver without kernel lock

2021-12-24 Thread Klemens Nanni
On Fri, Dec 24, 2021 at 11:17:46PM +0100, Alexander Bluhm wrote: > ip_deliver() has been called without kernel lock from ip_ours() and > ip6_ours() for a long time. It looks like these two callers in ip6 > input were forgotten to be unlocked. OK kn

Re: ip_deliver without kernel lock

2021-12-24 Thread Vitaliy Makkoveev
ok mvs@ > On 25 Dec 2021, at 01:17, Alexander Bluhm wrote: > > Hi, > > ip_deliver() has been called without kernel lock from ip_ours() and > ip6_ours() for a long time. It looks like these two callers in ip6 > input were forgotten to be unlocked. > > ok? > > bluhm > > Index: netinet6/ip6_in

Re: hangman(6): skip retguard symbols

2021-12-24 Thread Theo Buehler
> Tempting to skip all symbols with more than one digit (or maybe just more > than one consecutive digit?), as guessing among per-chip symbols from, say, > the ar* or dc* families is an exercise in futility. Maybe. However, I couldn't come up with a criterion I was happy with. Filtering three cons

Re: parallel ip forwarding

2021-12-24 Thread Vitaliy Makkoveev
`rtt_link’ list also has missing protection when rtfree() called outside netlock. > On 25 Dec 2021, at 01:34, Alexander Bluhm wrote: > > On Fri, Dec 24, 2021 at 02:04:17PM +0100, Alexander Bluhm wrote: >> On Fri, Dec 24, 2021 at 12:55:04AM +0100, Alexander Bluhm wrote: >>> If you use only regul

Re: parallel ip forwarding

2021-12-24 Thread Alexander Bluhm
On Fri, Dec 24, 2021 at 02:04:17PM +0100, Alexander Bluhm wrote: > On Fri, Dec 24, 2021 at 12:55:04AM +0100, Alexander Bluhm wrote: > > If you use only regular IPsec or forwarding, I hope it is stable. > > false hope > > rt_timer_add(fd81b97f5390,814218b0,802040c0,0) at > rt_

ip_deliver without kernel lock

2021-12-24 Thread Alexander Bluhm
Hi, ip_deliver() has been called without kernel lock from ip_ours() and ip6_ours() for a long time. It looks like these two callers in ip6 input were forgotten to be unlocked. ok? bluhm Index: netinet6/ip6_input.c === RCS file: /d

Re: hangman(6): skip retguard symbols

2021-12-24 Thread Philip Guenther
Skipping all leading double-underbar symbols makes sense to me. Tempting to skip all symbols with more than one digit (or maybe just more than one consecutive digit?), as guessing among per-chip symbols from, say, the ar* or dc* families is an exercise in futility. On Fri, Dec 24, 2021 at 5:23 AM

hangman(6): skip retguard symbols

2021-12-24 Thread Theo Buehler
__retguard_ symbols are easy to recognize and no real fun to guess. I suggest we skip them. Perhaps we should even skip all __* symbols? Index: ksyms.c === RCS file: /cvs/src/games/hangman/ksyms.c,v retrieving revision 1.12 diff -

Re: parallel ip forwarding

2021-12-24 Thread Alexander Bluhm
On Fri, Dec 24, 2021 at 12:55:04AM +0100, Alexander Bluhm wrote: > If you use only regular IPsec or forwarding, I hope it is stable. false hope rt_timer_add(fd81b97f5390,814218b0,802040c0,0) at rt_timer_ add+0xc7 icmp_mtudisc_clone(2438040a,0,1) at icmp_mtudisc_clone+0x174 ip_

Re: parallel ip forwarding

2021-12-24 Thread Alexander Bluhm
On Fri, Dec 24, 2021 at 04:16:28PM +0900, YASUOKA Masahiko wrote: > > - npppd l2pt ipsecflowinfo is not MP safe > > Does this mean the things we are discussing on the "Fix > ipsp_spd_lookup() for transport mode" thread? I wonder if there is > another issue. In this mail thread I was concerned ab

Re: kern.file in sysctl(8)

2021-12-24 Thread Jan Stary
On Dec 24 10:20:03, h...@stare.cz wrote: > Similarly for kern.proc and ps(1). In fact, warnx("use netstat to view %s", string); warnx("use dmesg to view %s", string); warnx("use ps to view %s information", string); warnx("use vmstat or systat to view %s information", warnx("use fstat to view %s i

Re: kern.file in sysctl(8)

2021-12-24 Thread Jan Stary
Similarly for kern.proc and ps(1). On Dec 24 10:18:15, h...@stare.cz wrote: > The sysctl(2) manpage also lists the corresponding sysctl(8) variables: > > Information may be retrieved and set using the sysctl(8) utility; > the variable names used by this utility are given here in parentheses.

kern.file in sysctl(8)

2021-12-24 Thread Jan Stary
The sysctl(2) manpage also lists the corresponding sysctl(8) variables: Information may be retrieved and set using the sysctl(8) utility; the variable names used by this utility are given here in parentheses. Among these is kern.file, which, understandably, just points to fstat(8). Would it b

dhcpleased(8): host name DHCP option

2021-12-24 Thread Florian Obser
Make host name DHCP option configurable. Diff from ha...@sdf.org, tweaks by me. RFC 2132 says a host name must have a lenght of at least 1, so we can use strlen(h_name) == 0 to not send a host name option at all and h_name == NULL to send the default host name option. OK? diff --git dhcpleased.c