Re: adduser: Document created backup files

2021-12-03 Thread Jason McIntyre
On Fri, Dec 03, 2021 at 05:59:08PM +, Jason McIntyre wrote: > On Tue, Nov 23, 2021 at 04:31:19PM +0100, Leon Fischer wrote: > > I had trouble finding what program kept randomly creating /etc/group.bak > > and it turns out to be adduser(8)'s fault. > > > > This documents group.bak so it can be

Re: vmm(4): restore vmcs after sleep points [vmx 2/3]

2021-12-03 Thread Mike Larkin
On Mon, Nov 29, 2021 at 08:41:22PM -0500, Dave Voutila wrote: > > Dave Voutila writes: > > > This diff removes instability from VMX-based hosts by either removing > > the possibility of the process sleeping while the VMCS is active or > > reloading it if we had no choice. > > > > A mutex is added

net write in pcb hash

2021-12-03 Thread Alexander Bluhm
Hi, As I want a read-only net lock for forwarding, all paths should be checked for the correct net lock and asserts. I found code in in_pcbhashlookup() where reading the PCB table results in a write to optimize the cache. Porperly protecting PCB hashes is out of scope for parallel forwarding. Ca

Re: parallel ip forwarding

2021-12-03 Thread Vitaliy Makkoveev
On Fri, Dec 03, 2021 at 08:35:45PM +0100, Alexander Bluhm wrote: > Hi, > > After implementing MP safe refcounting for IPsec TDB, I wonder how > stable my diff for forwarding on multiple CPU is. > > Note that IPsec still has the workaround to disable multiple queues. > We do not have a mutex that

parallel ip forwarding

2021-12-03 Thread Alexander Bluhm
Hi, After implementing MP safe refcounting for IPsec TDB, I wonder how stable my diff for forwarding on multiple CPU is. Note that IPsec still has the workaround to disable multiple queues. We do not have a mutex that protects the TDB fields yet. We have only fixed the memory management. My goa

Re: usbd_new_device: consolidate error paths

2021-12-03 Thread Alexander Bluhm
On Fri, Dec 03, 2021 at 08:06:36AM +0100, Anton Lindqvist wrote: > Consolidate error paths in usbd_new_device, shaving of 14 lines. > > Comments? OK? OK bluhm@ > diff --git sys/dev/usb/usb_subr.c sys/dev/usb/usb_subr.c > index a11bc448ece..74fe4c3b4db 100644 > --- sys/dev/usb/usb_subr.c > +++ sy

Re: adduser: Document created backup files

2021-12-03 Thread Jason McIntyre
On Tue, Nov 23, 2021 at 04:31:19PM +0100, Leon Fischer wrote: > I had trouble finding what program kept randomly creating /etc/group.bak > and it turns out to be adduser(8)'s fault. > > This documents group.bak so it can be found by apropos(1). > While here, document all the other .bak files that

Re: tdb_delete_locked for pfkey

2021-12-03 Thread Vitaliy Makkoveev
ok mvs@ > On 3 Dec 2021, at 20:25, Tobias Heider wrote: > > Hi, > > the diff below adds tdb_delete_locked() for use in pfkeyv2_sa_flush(). > This way we won't have to worry about keeping the inline code and > tdb_delete() in sync. > > ok? > > Index: net/pfkeyv2.c > ===

Re: tdb_delete_locked for pfkey

2021-12-03 Thread Alexander Bluhm
On Fri, Dec 03, 2021 at 06:25:46PM +0100, Tobias Heider wrote: > the diff below adds tdb_delete_locked() for use in pfkeyv2_sa_flush(). > This way we won't have to worry about keeping the inline code and > tdb_delete() in sync. > > ok? OK bluhm@ > Index: net/pfkeyv2.c > =

tdb_delete_locked for pfkey

2021-12-03 Thread Tobias Heider
Hi, the diff below adds tdb_delete_locked() for use in pfkeyv2_sa_flush(). This way we won't have to worry about keeping the inline code and tdb_delete() in sync. ok? Index: net/pfkeyv2.c === RCS file: /cvs/src/sys/net/pfkeyv2.c,v r

rpki-client: use single function to build basedir

2021-12-03 Thread Claudio Jeker
Currently ta, rrdp and rsync repositories use different functions to build their base path. This diff changes this so that all can use the same function. This is a first step to introduce a common validated repository. -- :wq Claudio Index: repo.c

Re: [External] : Re: make 'set skip on ...' dynamic

2021-12-03 Thread Claudio Jeker
On Fri, Nov 26, 2021 at 11:37:37PM +0100, Alexandr Nedvedicky wrote: > Hello, > > On Fri, Nov 26, 2021 at 01:01:40PM +0100, Claudio Jeker wrote: > > > > One more thing to consider, I think the following test in pfi_set_flags(): > > > > > + if ((p->pfik_flags_new != p->pfik_flags)

Re: dhcpleased - set ciaddr per RFC

2021-12-03 Thread Florian Obser
Last one, Joel spotted one more bug in the previous one, I was missing an assignment to dhcp_server in the ACK case. This is a rewrite of the package construction logic to send the correct information in the right states: RFC 2131 4.3.6, Table 4 ---

Re: ipsp_spd_lookup tdb refcount

2021-12-03 Thread Hrvoje Popovski
On 2.12.2021. 0:49, Alexander Bluhm wrote: > Hi, > > This adds TDB ref counting to ipsp_spd_lookup(). > > While there make ip6_output() look a bit more like ip_output(). > > ok? Hi, i'm hitting this diff for one day and sasyncd boxes didn't panic.