Re: bsd.upgrade fails `umount /mnt` with a single partition disk.

2021-12-01 Thread Theo de Raadt
Yuichiro NAITO wrote: > bsd.upgrade fails and shows following messages with a single partition disk. > > ``` > Force checking of clean non-root filesystems? [no] no > umount: /mnt: Device busy > Can't umount sd0a! OK, we figured out what is going on. During upgrade, the async random seed feedi

ipsec useless inner header

2021-12-01 Thread Alexander Bluhm
Hi, ipsec_common_input_cb() extracts the inner IP header of IPsec tunnels. It is never used, so this is useless code. ok? bluhm Index: netinet/ipsec_input.c === RCS file: /data/mirror/openbsd/cvs/src/sys/netinet/ipsec_input.c,v re

Re: Rework UNIX sockets locking to be fine grained

2021-12-01 Thread Vitaliy Makkoveev
This diff included into the snaps. > On 30 Nov 2021, at 19:48, Vitaliy Makkoveev wrote: > > Include missing "sys/refcnt.h" header to unpcb.h to fix libkvm and > netstat(1) build. No functional changes. > > Index: sys/kern/uipc_socket.c > =

ifdef ipsec inet6

2021-12-01 Thread Alexander Bluhm
Hi, This allows to build a kernel without ipsec or inet6. ok? bluhm Index: netinet/ip_ah.c === RCS file: /data/mirror/openbsd/cvs/src/sys/netinet/ip_ah.c,v retrieving revision 1.167 diff -u -p -r1.167 ip_ah.c --- netinet/ip_ah.c

ipsp_spd_lookup tdb refcount

2021-12-01 Thread Alexander Bluhm
Hi, This adds TDB ref counting to ipsp_spd_lookup(). While there make ip6_output() look a bit more like ip_output(). ok? bluhm Index: net/if_bridge.c === RCS file: /data/mirror/openbsd/cvs/src/sys/net/if_bridge.c,v retrieving revi

hotplugd: do not log device de/attach

2021-12-01 Thread Klemens Nanni
Just enabled hotplugd(8) to handle a single device I'm interested in and saw it basically duplicating kernel de/attach messages in /var/log/daemon: Dec 1 23:36:27 eru hotplugd[26475]: started Dec 1 23:36:27 eru hotplugd[26475]: uhidev4 attached, class 0 Dec 1 23:36:27 eru hotplugd[26475]: wskbd

Re: sshd poll index events unclaimed

2021-12-01 Thread Kirill Miazine
• Visa Hankala [2021-12-01 13:21]: > > sshd[389547]: poll index 1 fd 4 events 0x0 filter -9/0x9005 unclaimed > > sshd[63996]: poll index 1 fd 4 events 0x0 filter -9/0x9005 unclaimed > > sshd[406934]: poll index 1 fd 4 events 0x0 filter -9/0x9005 unclaimed > > sshd[107091]: poll index 1 fd 4 events

Re: sppp(4)/pppoe(4) - avoid endless loop in remote ip negotiation

2021-12-01 Thread Krzysztof Kanas
On 2021-12-01 10:21, Klemens Nanni wrote: > On Fri, Nov 26, 2021 at 01:35:14PM +0100, Krzysztof Kanas wrote: > > Hi. When remote side in sppp doesn't reply for to PPP IPCP IP-Address > > sppp will try to negotiate remote IP in endless loop. Instead use > > 10.64.64.1 + if_index as remote IP. > >

Re: tdb refcounting debug

2021-12-01 Thread Alexander Bluhm
On Thu, Nov 25, 2021 at 07:17:21PM +0100, Alexander Bluhm wrote: > To find the ref counting bugs in IPsec tdb I use this trace code. > Per default there is no change due to #ifdef. > > tdb_trace[72]: 3944909: refs 5 +1 cpu1 gettdb_dir:360 > tdb_trace[73]: 3944910: refs 6 +0 cpu1 pfkeyv2_

Re: Rework UNIX sockets locking to be fine grained

2021-12-01 Thread Vitaliy Makkoveev
On Wed, Dec 01, 2021 at 12:55:06PM +0100, Martin Pieuchot wrote: > On 24/11/21(Wed) 15:04, Vitaliy Makkoveev wrote: > > [...] > > Really, this is the simplest way. The shared lock for the pair of > > sockets moves re-lock dances to the connect and disconnect stages which > > should be also protect

Re: sshd poll index events unclaimed

2021-12-01 Thread Visa Hankala
On Wed, Dec 01, 2021 at 11:18:13AM +0100, Kirill Miazine wrote: > After installing the most recent snapshot earlier today, I'm seeing > following messages: > > sshd[389547]: poll index 1 fd 4 events 0x0 filter -9/0x9005 unclaimed > sshd[63996]: poll index 1 fd 4 events 0x0 filter -9/0x9005 unclaim

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-01 Thread prx
> * Martin Pieuchot wrote: > > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > > Diff below unlock the bottom part of the UVM fault handler. I'm > > > interested in squashing the remaining bugs. Please test with your usual > > > setup & report back. > > > > Thanks to all the testers, here's a

Re: Fix ipsp_spd_lookup() for transport mode

2021-12-01 Thread YASUOKA Masahiko
On Wed, 1 Dec 2021 00:27:06 +0100 Alexander Bluhm wrote: > On Tue, Nov 30, 2021 at 05:53:34PM +0300, Vitaliy Makkoveev wrote: >> Hi, >> >> This question is mostly for bluhm@. Should the gettdbbyflow() grab the >> extra reference on returned `tdbp' like other other gettdb*() do? I'm >> pointing th

Re: Rework UNIX sockets locking to be fine grained

2021-12-01 Thread Martin Pieuchot
On 24/11/21(Wed) 15:04, Vitaliy Makkoveev wrote: > [...] > Really, this is the simplest way. The shared lock for the pair of > sockets moves re-lock dances to the connect and disconnect stages which > should be also protected by locks. And not for the pair. Many SOCK_DGRAM > sockets could be conne

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-01 Thread Matthias Schmidt
Hi Martin, * Martin Pieuchot wrote: > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > Diff below unlock the bottom part of the UVM fault handler. I'm > > interested in squashing the remaining bugs. Please test with your usual > > setup & report back. > > Thanks to all the testers, here's a n

Re: ipsp_spd_lookup error

2021-12-01 Thread Vitaliy Makkoveev
On Wed, Dec 01, 2021 at 12:18:30AM +0100, Alexander Bluhm wrote: > Hi, > > I want to ref count the TDB that is returned by ipsp_spd_lookup(). > > Sometimes the TDB returned by ipsp_spd_lookup() is not used. So > refcounting that, does not make sense. As a first step I want to > convert ipsp_spd

sshd poll index events unclaimed

2021-12-01 Thread Kirill Miazine
After installing the most recent snapshot earlier today, I'm seeing following messages: sshd[389547]: poll index 1 fd 4 events 0x0 filter -9/0x9005 unclaimed sshd[63996]: poll index 1 fd 4 events 0x0 filter -9/0x9005 unclaimed sshd[406934]: poll index 1 fd 4 events 0x0 filter -9/0x9005 unclaimed s

Re: sppp(4)/pppoe(4) - avoid endless loop in remote ip negotiation

2021-12-01 Thread Klemens Nanni
On Fri, Nov 26, 2021 at 01:35:14PM +0100, Krzysztof Kanas wrote: > Hi. When remote side in sppp doesn't reply for to PPP IPCP IP-Address > sppp will try to negotiate remote IP in endless loop. Instead use > 10.64.64.1 + if_index as remote IP. Why add some arbitrary RFC 1918 IP if negotiation fai

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-01 Thread Alexander Bluhm
On Mon, Nov 29, 2021 at 10:50:32PM +0100, Martin Pieuchot wrote: > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > Diff below unlock the bottom part of the UVM fault handler. I'm > > interested in squashing the remaining bugs. Please test with your usual > > setup & report back. > > Thanks to

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-01 Thread Jan Stary
> > > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > > > Diff below unlock the bottom part of the UVM fault handler. I'm > > > > interested in squashing the remaining bugs. Please test with your usual > > > > setup & report back. > > > > > > Thanks to all the testers, here's a new version th