utvfu(4) frame size query busted

2021-11-24 Thread Marcus Glocker
When I understand it correctly, an utvfu(4) device supports either the frame size for PAL or NTSC. So, the VIDIOC_ENUM_FRAMESIZES ioctl should only return one frame size, which isn't the case currently. video(1) repeatedly returns various times the same frame size, ffmpeg(1) and ffplay(1) even go

Re: smtpd: LINE_MAX might not be enough for a response

2021-11-24 Thread Jan Stary
On Nov 25 01:38:35, h...@stare.cz wrote: > On Nov 24 14:47:48, j...@maudlin.dev wrote: > > > > Jan Stary writes: > > > smtpd just failed to parse a SMTP response (below), > > > saying 'line too long'. > > > > > > Looking at the source, this seems to be parse_smtp_response() in util.c, > > > which

Re: smtpd: LINE_MAX might not be enough for a response

2021-11-24 Thread Jan Stary
On Nov 24 14:47:48, j...@maudlin.dev wrote: > > Jan Stary writes: > > smtpd just failed to parse a SMTP response (below), > > saying 'line too long'. > > > > Looking at the source, this seems to be parse_smtp_response() in util.c, > > which errors out right away with > > > > if (len >= LINE_M

Re: IPsec tdb ref counting

2021-11-24 Thread Vitaliy Makkoveev
> On 24 Nov 2021, at 22:14, Tobias Heider wrote: > > On Wed, Nov 24, 2021 at 03:52:26PM +0100, Alexander Bluhm wrote: >> On Wed, Nov 24, 2021 at 05:12:36PM +0300, Vitaliy Makkoveev wrote: >>> Understood. But his means we encoded double unref when we calling >>> tdb_unref() just after tdb_delete(t

Re: IPsec tdb ref counting

2021-11-24 Thread Vitaliy Makkoveev
It was not clean for me because we has no extra reference for parallel tdb_delete(). Now I understand how it should work and why ‘TDBF_DELETED’ fixed this. Thanks for explanation. > On 24 Nov 2021, at 17:52, Alexander Bluhm wrote: > > On Wed, Nov 24, 2021 at 05:12:36PM +0300, Vitaliy Makkoveev

openssl passwd: we know how to print a size_t

2021-11-24 Thread Theo Buehler
BIO_printf() is a wrapper around vfprintf, so we can remove this comment and the cast. Index: passwd.c === RCS file: /cvs/src/usr.bin/openssl/passwd.c,v retrieving revision 1.10 diff -u -p -r1.10 passwd.c --- passwd.c14 Jul 2019 0

Re: IPsec tdb ref counting

2021-11-24 Thread Tobias Heider
On Wed, Nov 24, 2021 at 03:52:26PM +0100, Alexander Bluhm wrote: > On Wed, Nov 24, 2021 at 05:12:36PM +0300, Vitaliy Makkoveev wrote: > > Understood. But his means we encoded double unref when we calling > > tdb_unref() just after tdb_delete(tdb). To me it looks better to avoid > > this and rework

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-11-24 Thread Matthias Schmidt
Hi Martin, * Martin Pieuchot wrote: > Diff below unlock the bottom part of the UVM fault handler. I'm > interested in squashing the remaining bugs. Please test with your usual > setup & report back. I have the diff running on a Thinkpad T450s and noticed no regessions so far. Will continue run

smtpd: LINE_MAX might not be enough for a response

2021-11-24 Thread Jan Stary
This is current/amd64 on a PC. smtpd just failed to parse a SMTP response (below), saying 'line too long'. Looking at the source, this seems to be parse_smtp_response() in util.c, which errors out right away with if (len >= LINE_MAX) return "line too long"; Apparently,

Re: rpki-client code shuffle

2021-11-24 Thread Theo de Raadt
Shuffling approved. Claudio Jeker wrote: > For a RRDP regress test I would like to move some functions to better > places. hex_decode() belongs into encoding.c and the publish XML code > is now in rpki_util.c. > > -- > :wq Claudio > > Index: Makefile >

Re: IPsec tdb ref counting

2021-11-24 Thread Alexander Bluhm
On Wed, Nov 24, 2021 at 05:12:36PM +0300, Vitaliy Makkoveev wrote: > Understood. But his means we encoded double unref when we calling > tdb_unref() just after tdb_delete(tdb). To me it looks better to avoid > this and rework handlers like below: I have tried this before. It creates a tdb leak.

Re: rpki-client code shuffle

2021-11-24 Thread Job Snijders
On Wed, Nov 24, 2021 at 03:09:02PM +0100, Claudio Jeker wrote: > For a RRDP regress test I would like to move some functions to better > places. hex_decode() belongs into encoding.c and the publish XML code > is now in rrdp_util.c. OK job@

Re: IPsec tdb ref counting

2021-11-24 Thread Vitaliy Makkoveev
On Wed, Nov 24, 2021 at 02:12:15PM +0100, Alexander Bluhm wrote: > On Wed, Nov 24, 2021 at 02:48:06AM +0300, Vitaliy Makkoveev wrote: > > >> ddb{2}> show panic > > >> *cpu2: pool_do_get: tdb free list modified: page 0x8801; > > >> item addr 0 > > >> x8801c998; offset 0x28=0xdea

rpki-client code shuffle

2021-11-24 Thread Claudio Jeker
For a RRDP regress test I would like to move some functions to better places. hex_decode() belongs into encoding.c and the publish XML code is now in rpki_util.c. -- :wq Claudio Index: Makefile === RCS file: /cvs/src/usr.sbin/rpki-c

Re: IPsec tdb ref counting

2021-11-24 Thread Alexander Bluhm
On Wed, Nov 24, 2021 at 02:48:06AM +0300, Vitaliy Makkoveev wrote: > >> ddb{2}> show panic > >> *cpu2: pool_do_get: tdb free list modified: page 0x8801; item > >> addr 0 > >> x8801c998; offset 0x28=0xdeadbeee > >> > >> ddb{2}> show tdb /f 0x8801c998 > >> tdb at 0x8

Re: Rework UNIX sockets locking to be fine grained

2021-11-24 Thread Vitaliy Makkoveev
On Wed, Nov 24, 2021 at 11:36:22AM +0100, Martin Pieuchot wrote: > On 22/11/21(Mon) 14:42, Vitaliy Makkoveev wrote: > > On Sat, Nov 20, 2021 at 03:12:31AM +0300, Vitaliy Makkoveev wrote: > > > Updated diff. Re-lock dances were simplified in the unix(4) sockets > > > layer. > > > > > > Reference co

Re: dhcpleased - set ciaddr per RFC

2021-11-24 Thread Florian Obser
On 2021-11-23 21:30 -07, Joel Knight wrote: > On Fri, Nov 19, 2021 at 1:01 PM Joel Knight wrote: >> >> One thing that got missed in the refactor was that the requested-ip >> option should not be set in a RENEWING or BINDING state (or in other >> words, when ciaddr is set). This chunk on top of yo

Re: Rework UNIX sockets locking to be fine grained

2021-11-24 Thread Martin Pieuchot
On 22/11/21(Mon) 14:42, Vitaliy Makkoveev wrote: > On Sat, Nov 20, 2021 at 03:12:31AM +0300, Vitaliy Makkoveev wrote: > > Updated diff. Re-lock dances were simplified in the unix(4) sockets > > layer. > > > > Reference counters added to unix(4) sockets layer too. This makes > > pointer dereferenc

Please test: UVM fault unlocking (aka vmobjlock)

2021-11-24 Thread Martin Pieuchot
Diff below unlock the bottom part of the UVM fault handler. I'm interested in squashing the remaining bugs. Please test with your usual setup & report back. Thanks, Martin diff --git sys/arch/amd64/conf/GENERIC.MP sys/arch/amd64/conf/GENERIC.MP index bb842f6d96e..e5334c19eac 100644 --- sys/arch

Re: vport: set UP on ip assign

2021-11-24 Thread Stuart Henderson
How about a flag that can be passed via ifconfig to disable the implicit up? Then netstart could use it to enaure that an interface is only brought up after it has finished configuration (which *is* a problem for pppoe and carp at least) and it suits people's finger memory for ifconfig? Of course