Re: new site.8: document site*.tgz and /{upgrade,install}.site

2021-11-05 Thread Klemens Nanni
On Fri, Nov 05, 2021 at 05:36:48PM -0700, Andrew Hewus Fresh wrote: > I like it, some comments in-line but overall I think this would have > helped me get started with siteXX stuff, so OK afresh1@ Great, I'll commit with tweaks as per below, thanks! > > +If existent and executable, > > This whol

Re: new site.8: document site*.tgz and /{upgrade,install}.site

2021-11-05 Thread Andrew Hewus Fresh
I like it, some comments in-line but overall I think this would have helped me get started with siteXX stuff, so OK afresh1@ On Fri, Nov 05, 2021 at 03:19:03PM +, Klemens Nanni wrote: > On Wed, Oct 27, 2021 at 07:35:28PM -0500, Aaron Poffenberger wrote: > > Looks good. Nice to see this moving

ftp: do not URI encode tilde as per RFC 2396

2021-11-05 Thread Klemens Nanni
ftp(1) implements RFC 1738 from Dec. 1994 but RFC 2396 from Aug. 1998 updated this and the tl;dr is: do not encode the tilde character. In theory, this shouldn't make a difference as servers should decode "%7e" to "~", BUT not all servers do so and thus some respond with 404. I've hit this in th

Re: [patch] httpd static gzip compression

2021-11-05 Thread Steffen Nurpmeso
... |You would be asking for | |https://exmaple.com/whatever/ls.1 | |and with Accept-Encoding: gzip in the http header, and the |webserver would then look if it has a file | |/whatever/ls.1.gz | |(instead of without .gz) in its document tree and send you that, with |"Content-Encoding:

Re: [patch] httpd static gzip compression

2021-11-05 Thread Crystal Kolipe
On Fri, Nov 05, 2021 at 08:24:21AM -0600, Theo de Raadt wrote: > prx wrote: > > > I think this remark should be placed into perspective. > > > > When a file is requested, its gzipped version is send if : > > * The client ask for it with appropriate header. > > * The server admin configured http

Re: [patch] httpd static gzip compression

2021-11-05 Thread Sebastian Benoit
Theo de Raadt(dera...@openbsd.org) on 2021.11.05 08:24:21 -0600: > prx wrote: > > > I think this remark should be placed into perspective. > > > > When a file is requested, its gzipped version is send if : > > * The client ask for it with appropriate header. > > * The server admin configured ht

Re: rpki-client show attr name in rrdp parse errors

2021-11-05 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.11.05 15:26:57 +0100: > On Wed, Nov 03, 2021 at 12:58:17PM +0100, Claudio Jeker wrote: > > In one place this is already done but this makes sure we show the bad > > attribute in all cases where a non conforming attribute is found. > > Found another b

Re: [patch] httpd static gzip compression

2021-11-05 Thread Sebastian Benoit
Ingo Schwarze(schwa...@usta.de) on 2021.11.05 14:37:15 +0100: > Hi Theo, > > Theo de Raadt wrote on Thu, Nov 04, 2021 at 08:27:47AM -0600: > > prx wrote: > >> On 2021/11/04 14:21, prx wrote: > > >>> The attached patch add support for static gzip compression. > >>> > >>> In other words, if a cli

Re: new site.8: document site*.tgz and /{upgrade,install}.site

2021-11-05 Thread Klemens Nanni
On Wed, Oct 27, 2021 at 07:35:28PM -0500, Aaron Poffenberger wrote: > Looks good. Nice to see this moving forward. Thanks. > > On 2021-10-27 21:13 +, Klemens Nanni wrote: > > On Mon, Sep 06, 2021 at 02:29:50PM -0500, Aaron Poffenberger wrote: > > > Ping. > > > > > > Will someone commit this?

Re: rpki-client show attr name in rrdp parse errors

2021-11-05 Thread Claudio Jeker
On Wed, Nov 03, 2021 at 12:58:17PM +0100, Claudio Jeker wrote: > In one place this is already done but this makes sure we show the bad > attribute in all cases where a non conforming attribute is found. Found another bunch of those non conforming attribute errors. Adjust them as well. OK? -- :wq

Re: [patch] httpd static gzip compression

2021-11-05 Thread Theo de Raadt
prx wrote: > I think this remark should be placed into perspective. > > When a file is requested, its gzipped version is send if : > * The client ask for it with appropriate header. > * The server admin configured httpd to do so **and** compressed files. and if the gzipd file does not contain

Re: [patch] httpd static gzip compression

2021-11-05 Thread prx
* Theo de Raadt le [04-11-2021 08:27:47 -0600]: > prx wrote: > > > * Stuart Henderson le [04-11-2021 14:09:39 +]: > > > On 2021/11/04 14:21, prx wrote: > > > > Hello, > > > > The attached patch add support for static gzip compression. > > > > > > > > In other words, if a client support gzi

Re: [patch] httpd static gzip compression

2021-11-05 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Thu, Nov 04, 2021 at 08:27:47AM -0600: > prx wrote: >> On 2021/11/04 14:21, prx wrote: >>> The attached patch add support for static gzip compression. >>> >>> In other words, if a client support gzip compression, when "file" is >>> requested, httpd will check if

Re: UNIX sockets: use vnode(9) lock to protect `v_socket' dereference

2021-11-05 Thread Vitaliy Makkoveev
On Fri, Nov 05, 2021 at 08:31:07AM +0100, Martin Pieuchot wrote: > On 26/10/21(Tue) 14:12, Vitaliy Makkoveev wrote: > > Another step to make UNIX sockets locking fine grained. > > > > The listening socket has the references from file descriptors layer and > > from the vnode(9) layer. This means wh

Re: UNIX sockets: make `unp_rights', `unp_msgcount' and `unp_file' atomic

2021-11-05 Thread Vitaliy Makkoveev
On Fri, Nov 05, 2021 at 09:50:05AM +0100, Mark Kettenis wrote: > > Date: Fri, 5 Nov 2021 07:18:03 +0100 > > From: Martin Pieuchot > > > > On 30/10/21(Sat) 21:22, Vitaliy Makkoveev wrote: > > > This completely removes global rwlock(9) from the unp_internalize() and > > > unp_externalize() normal p

Re: speedup io marshal in rpki-client

2021-11-05 Thread Job Snijders
On Fri, Nov 05, 2021 at 09:18:15AM +0100, Claudio Jeker wrote: > Noticed the other day. The ip addr arrays and as number array are > marshalled element by element which is not very efficent. > All the data is in one big blob of memory so just use the basic io > operations for a memory blob and ship

Re: speedup io marshal in rpki-client

2021-11-05 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.11.05 09:18:15 +0100: > Noticed the other day. The ip addr arrays and as number array are > marshalled element by element which is not very efficent. > All the data is in one big blob of memory so just use the basic io > operations for a memory blob a

poll/select: Lazy removal of knotes

2021-11-05 Thread Martin Pieuchot
New poll/select(2) implementation convert 'struct pollfd' and 'fdset' to knotes (kqueue event descriptors) then pass them to the kqueue subsystem. A knote is allocated, with kqueue_register(), for every read, write and except condition watched on a given FD. That means at most 3 allocations might

Re: UNIX sockets: make `unp_rights', `unp_msgcount' and `unp_file' atomic

2021-11-05 Thread Mark Kettenis
> Date: Fri, 5 Nov 2021 07:18:03 +0100 > From: Martin Pieuchot > > On 30/10/21(Sat) 21:22, Vitaliy Makkoveev wrote: > > This completely removes global rwlock(9) from the unp_internalize() and > > unp_externalize() normal paths but only leaves it in unp_externalize() > > error path. Also we don't

speedup io marshal in rpki-client

2021-11-05 Thread Claudio Jeker
Noticed the other day. The ip addr arrays and as number array are marshalled element by element which is not very efficent. All the data is in one big blob of memory so just use the basic io operations for a memory blob and ship the full array at once. This seems to reduce runtime by 5-10% (in my

Re: UNIX sockets: use vnode(9) lock to protect `v_socket' dereference

2021-11-05 Thread Martin Pieuchot
On 26/10/21(Tue) 14:12, Vitaliy Makkoveev wrote: > Another step to make UNIX sockets locking fine grained. > > The listening socket has the references from file descriptors layer and > from the vnode(9) layer. This means when we close(2)'ing such socket it > still referenced by concurrent thread t