Re: ucc: ignore get encoding requests

2021-10-19 Thread Landry Breuil
Le Wed, Oct 20, 2021 at 07:43:36AM +0200, Anton Lindqvist a écrit : > Hi, > landry@ reported that he ended up with the wrong encoding in X11 while > having a ucc keyboard attached and /etc/kbdtype being present. The > advertised encoding of a wsmux is a bit fragile as the last attached > device wil

ucc: ignore get encoding requests

2021-10-19 Thread Anton Lindqvist
Hi, landry@ reported that he ended up with the wrong encoding in X11 while having a ucc keyboard attached and /etc/kbdtype being present. The advertised encoding of a wsmux is a bit fragile as the last attached device will dictate it. If this happens to be a ucc keyboard, KB_US will always be the a

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Jonathan Gray
On Tue, Oct 19, 2021 at 07:37:36AM -0600, Todd C. Miller wrote: > On Tue, 19 Oct 2021 18:08:04 +1100, Jonathan Gray wrote: > > > There are many others along those lines in the kernel, for example > > sparse complains about these in vfs_subr.c > > > > /sys/kern/vfs_subr.c:274:64: warning: Using pla

Re: relayd patch for websocket upgrade

2021-10-19 Thread Jonathon Fletcher
On Sun, May 02, 2021 at 11:05:16AM -0700, Jonathon Fletcher wrote: > On Sun, Mar 07, 2021 at 06:22:04PM -0800, Jonathon Fletcher wrote: > > On Sun, Mar 07, 2021 at 06:46:33PM +0100, Marcus MERIGHI wrote: > > > Hello Jonathon! > > > > > > welcome to the party: > > > > > > https://marc.info

pax(1): Don't open files that will be skipped

2021-10-19 Thread Jeremy Evans
Currently, when creating an archive file with pax(1), pax will attempt to open a file even if the file will be skipped due to an -s replacement with the empty string. With this change, pax will not attempt to open files that it knows will be skipped. When doing direct copies to a directory (-rw),

Re: patch: move vnode lock from FS implementation to struct vnode

2021-10-19 Thread Visa Hankala
On Tue, Oct 19, 2021 at 09:02:53AM +0200, Sebastien Marie wrote: > Hi, > > The following diff is a bit large. it could be splitted for easy > review, but I tought having the full view would be good too. > > It moves the current vnode lock mecanism, implemented inside FS > specific struct, to `str

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Todd C . Miller
On Tue, 19 Oct 2021 18:08:04 +1100, Jonathan Gray wrote: > There are many others along those lines in the kernel, for example > sparse complains about these in vfs_subr.c > > /sys/kern/vfs_subr.c:274:64: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:275:64: warning: Using pla

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Sebastien Marie
On Tue, Oct 19, 2021 at 06:08:04PM +1100, Jonathan Gray wrote: > On Tue, Oct 19, 2021 at 08:32:57AM +0200, Sebastien Marie wrote: > > Hi, > > > > Simple online diff for properly nullify v_data (which is `void *`) > > with NULL instead of 0. > > > > Comments or OK ? > > -- > > Sebastien Marie > >

Re: patch: move vnode lock from FS implementation to struct vnode - FS part (cd9660)

2021-10-19 Thread Sebastien Marie
And here it is the cd9660 part. I prefered showing cd9660 over ffs, as ffs lock is shared between more FS implementation (ext2fs, ffs). else, cd9660 is similar to other implementations. blob - 5082a7ad64a7c73a250023dd9e833b7ff91893b2 blob + 368b0a5b1252ba6b57401f28a8e0aad585828abb --- sys/isofs

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Jonathan Gray
On Tue, Oct 19, 2021 at 08:32:57AM +0200, Sebastien Marie wrote: > Hi, > > Simple online diff for properly nullify v_data (which is `void *`) > with NULL instead of 0. > > Comments or OK ? > -- > Sebastien Marie > There are many others along those lines in the kernel, for example sparse compla

Re: patch: move vnode lock from FS implementation to struct vnode - new vnode code only

2021-10-19 Thread Sebastien Marie
Below is the part of the full diff which is adding generic vnode lock inside struct vnode. blob - 7df5a5757b90244ab361f0687bd2eabf3e7093c2 blob + 53fb67ace69ada6faf768a6e7b20a48e2b6e9740 --- sys/kern/vfs_default.c +++ sys/kern/vfs_default.c @@ -167,6 +167,34 @@ vop_generic_abortop(void *v)

patch: move vnode lock from FS implementation to struct vnode

2021-10-19 Thread Sebastien Marie
Hi, The following diff is a bit large. it could be splitted for easy review, but I tought having the full view would be good too. It moves the current vnode lock mecanism, implemented inside FS specific struct, to `struct vnode`. I used `vop_generic_lock`, `vop_generic_unlock` and `vop_generic_i