Re: Variable type fix in parse.y (all of them)

2021-09-30 Thread Todd C . Miller
On Thu, 30 Sep 2021 22:15:39 +0200, Christian Weisgerber wrote: > E.g. like this? Yes, that looks correct. However, this is a bit ugly: if (pushback_index < MAXPUSHBACK-1) return (unsigned char)(pushback_buffer[pushback_index++] = c); else return

Re: Variable type fix in parse.y (all of them)

2021-09-30 Thread Christian Weisgerber
Todd C. Miller: > On Thu, 30 Sep 2021 21:37:06 +0200, Christian Weisgerber wrote: > > > Unfortunately that also affects the parsebuf/pushback_buffer complex > > used in some parser.y files. > > That would require a few extra casts but it is straightforward. E.g. like this? Index: bin/chio/pars

Re: OpenBSD Errata: September 30, 2021 (libressl)

2021-09-30 Thread Stuart Henderson
On 2021/09/30 21:45, Sebastian Benoit wrote: > An errata patch for LibreSSL has been released for OpenBSD 6.8 and > OpenBSD 6.9. > > Compensate for the expiry of the DST Root X3 certificate. The use of an > unnecessary expired certificate in certificate chains can cause validation > errors. > >

Re: Variable type fix in parse.y (all of them)

2021-09-30 Thread Todd C . Miller
On Thu, 30 Sep 2021 21:37:06 +0200, Christian Weisgerber wrote: > Unfortunately that also affects the parsebuf/pushback_buffer complex > used in some parser.y files. That would require a few extra casts but it is straightforward. - todd

OpenBSD Errata: September 30, 2021 (libressl)

2021-09-30 Thread Sebastian Benoit
An errata patch for LibreSSL has been released for OpenBSD 6.8 and OpenBSD 6.9. Compensate for the expiry of the DST Root X3 certificate. The use of an unnecessary expired certificate in certificate chains can cause validation errors. Binary updates for the amd64, i386 and arm64 platform are ava

Re: Variable type fix in parse.y (all of them)

2021-09-30 Thread Christian Weisgerber
Todd C. Miller: > lungetc((u_char)*p); > ... > c = (u_char)*--p; > > Since we use casts sparingly, when they are present they indicate > something you need to pay attention to. That is not the case when > we simply change the type. Unfortunately that also affects the parsebuf/

Re: Variable type fix in parse.y (all of them)

2021-09-30 Thread Todd C . Miller
On Thu, 30 Sep 2021 12:33:58 +0100, Stuart Henderson wrote: > > revision 1.628 > date: 2013/11/25 12:52:45; author: benno; state: Exp; lines: +7 -7; > use u_char for buffers in yylex, for ctype calls > found by millert@, ok deraadt@ > T

Re: Variable type fix in parse.y (all of them)

2021-09-30 Thread Stuart Henderson
On 2021/09/29 21:21, Christian Weisgerber wrote: > The oft-copied parse.y code declares some variables as "unsigned char *" > but passes them to functions that take "char *" arguments and doesn't > make any use of the unsigned property. btw, those used to be char: rev

Re: Variable type fix in parse.y (all of them)

2021-09-30 Thread Christian Weisgerber
Christian Weisgerber: > The oft-copied parse.y code declares some variables as "unsigned char *" > but passes them to functions that take "char *" arguments and doesn't > make any use of the unsigned property. While I'm here... > int > yylex(void) > { > - u_char buf[8096]; > - u_cha